From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga17.intel.com ([192.55.52.151]:56972 "EHLO mga17.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390040AbeIUU05 (ORCPT ); Fri, 21 Sep 2018 16:26:57 -0400 Subject: Re: [PATCH] perf/x86/intel/uncore: Fix PCI BDF address of M3UPI on SKX To: Peter Zijlstra Cc: tglx@linutronix.de, mingo@redhat.com, linux-kernel@vger.kernel.org, ak@linux.intel.com, eranian@google.com, stable@vger.kernel.org References: <1537538826-55489-1-git-send-email-kan.liang@linux.intel.com> <20180921141437.GE24124@hirez.programming.kicks-ass.net> From: "Liang, Kan" Message-ID: Date: Fri, 21 Sep 2018 10:37:22 -0400 MIME-Version: 1.0 In-Reply-To: <20180921141437.GE24124@hirez.programming.kicks-ass.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: stable-owner@vger.kernel.org List-ID: On 9/21/2018 10:14 AM, Peter Zijlstra wrote: > On Fri, Sep 21, 2018 at 07:07:06AM -0700, kan.liang@linux.intel.com wrote: >> From: Kan Liang >> >> The counters on M3UPI Link 0 and Link 3 don't count. Writing 0 to >> these counters may causes system crash on some machines. >> >> The PCI BDF addresses of M3UPI in current code are incorrect. >> The correct addresses should be >> D18:F1 0x204D >> D18:F2 0x204E >> D18:F5 0x204D > > Should this have a Fixes: tag? > Yes, sorry for missing it. Here it is. Fixes: cd34cd97b7b4 ("perf/x86/intel/uncore: Add Skylake server uncore support") Thanks, Kan