From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.128.47 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794214668; b=4W5c3GyZXrDHDfR6dANJW7R7Jt3vlMS53JtS6oHntpobwZIvUkwYs9Igu9Wm2VsvSJOe H6W0sJngESeY9ICMSH8FyMWuwldeFeksOAcbj07Ws18UP7ctvy/ZZKOvrtmwEk93vmUwT HVEA9gK7ntKixb20Mn5JWrnPoMNCBxRe3yttVoKDzwXYTQkvdKqAQP2TIzRIJeCaChkcu DPQ1W1Oju1h4hzwxnuAM2UVsEZL1dx5R+RaJAlHxJ0Z6jb9ClHxEcxJyRWjOGL1o1SHey Y5oFeTzBlGrIk+nrf6bsMSfaLWEnXRahjZvJkgq9zAhZeoFUGKKoq1AwsBYluxIE/zA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794214668; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: Message-ID:Date:MIME-Version:User-Agent:Subject:To:Cc:References: Content-Language:From:In-Reply-To:Content-Type: Content-Transfer-Encoding; bh=6gPNbhKnS4UiPYe9GkhcEdm+Vle3xI8UXMcC7kdMJ/8=; b=bnTWh+tscofj0krfW1HBR9YIgplzQXIgw7VjGsW526WZkSGljsjxVpmVBHq4Az5S8QBM ts57Viv7yjk8u8/WrgfeEDGsa0WRGhuJ/T9/XlBOnWbRjq/ngisLm8Ls19eD1fT2ORfJS M0o7uvf57gqyzgc9l70iZQCACKTmDO1zD97N2mZ9alNbm67pytEmWvwHv8fUkxhjqrVWq SwffR/mFaxCVw2rcBcnun096WuveycmTvOJ9QSRtNtjzFm2QpRGiLm8dY23/ku2XVMnaG lfRh7BT/44MeUzwIWk1DfJEl6EKTNofJ0dF23J6RbUwspXakVcPfHBGjxCdEvR2JwDw== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=WX99d5g8; arc=none smtp.remote-ip=209.85.128.47 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 82F8E606A322 for ; Mon, 9 Nov 2026 08:57:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 82F8E606A322 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=WX99d5g8 Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-4a60f9474c4so7505565e9.0 for ; Mon, 09 Nov 2026 00:57:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20260707; t=1794214667; x=1794819467; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=6gPNbhKnS4UiPYe9GkhcEdm+Vle3xI8UXMcC7kdMJ/8=; b=WX99d5g8HsNJ2Xc3dJWqBEteZ1Yzefr2XigtdxHvKUPJpgca1CoZqq4dp9NTaNP6YU bfxXvVbrXNq1MdQzDcVoMJst5p/JdASrGhqAQ35GgrQgGpWZpMZlArfgaA1khdBAvC3f UCgBrQaf6/SWaIrIz1cfg3VI8DlRIOxG1IFQ8rIXoFZQPGYzqcNzDEqWjIR9CgfeTAw8 NE+Bm718A9eCD1tFyyGwavlgkgZz4MK9/UkYHD7WODjq9NCi/wfmLAsHbxT2jEtokNMQ 8Q5NxTbvsYh5rJzdZ+Fl9IzESFScMGEZ1Re6QX6Qo6SLBiZakqLIE2CVv/0RDj39F8Jv /HqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794214667; x=1794819467; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=6gPNbhKnS4UiPYe9GkhcEdm+Vle3xI8UXMcC7kdMJ/8=; b=JQgriSJecqeA++k0pYg3vYgfFw1Nc7/r6F+5dGJbU/cSkGkiKK34YYee3ZoQ5SsYwo x+gAeAMFiZE8NXYGsj9HGXzQq5yPONeiMLKqiVo0/n045xgBTkgy6sxrPpCb87NknRub ncFOhiFw2fV0qAX9XqGrpr6JiHhLXRrX2R4P3vPTT/jiu+iRRy6sOIcoi/OuEnGU0pp6 N7EVhQD1naEaKusLKrI0zLMp+HVhxGTT/3msjEUxLMPN1buCmqQ+FreqaVVReHuKbqxJ oWp7qOsbHwH2FoRgK0tOd4UxxlpIzPrk4gsosjAmFsFuqDeMYl5YKq707dJywjo8g7Sc qESw== X-Forwarded-Encrypted: i=1; AL+hErH4bGLnb4OwKLYz0bzYCl7amyX779uwUKjNp+nL7Zc787yEUs1iXMPYS+3GFYAnAZcyCyyzOHs=@vger.kernel.org X-Gm-Message-State: APuU4Z8uJeWtC8/cJkWVCxWRTfkS1BwbPGu0fzysu/MCjC2ItKNG1Psj wOgmJ6IX++STroAb1KtT3wUveCesy4neAzup4+4+Lj6B+8z9URcMPWW+ X-Gm-Gg: AYBFou3jjt/RMeEw2mfw5Grn1qtTmQyofYv5hDlQCL/+vIp14RIhcZMNKnYQNkraeVP HwsRiICb1ooYnRDpQ2h8NawEN0e9Wn7LPE50IYQAirJbsAUiOKNsGMQ8/vUbb2k24TTNc1bpM6m q8OjP9ser1rDPf3sraQSSRRHXNo8KJ+eJQpwvMsAdkNCH1ARCzeQG8APmujZsUXL2ZJ2oDbGJL9 WafYlGYhViCXU/DQA8lWZ5b2UhsNY0jqRotJUzS0GBVbOpo3rB1oG7DW0jctQsTXeDWvXJ6CmBA YtvVDPiojOaUZAmZRrjqv8tdJYjAQf2JFm4OVjh7qvZwGcrdLLjThgyBYZTltMhJFyvG3jW8X2w GigXNTspX/o1ZqaHuZpleStl0xsmYm5fwB5T9mEFzU8/jtRyMX3PB+bMwo9N0chY5y8hh5+BkgD F9rgQSMkx3yxmN44dCgK7Ve9leTta0BH79Lplq4feWLalyP2xKt9Z1lwU/2tCSbFX68sti0vzZG cNSmXiYlT8fG6KCluC7OGIzdi92kHU2wBby0XvpH9pK8fW0VaRPnxttpO7D3XL0MHRZLVsNCojz jel8KPmXfVwDg1UFuM8bilw= X-Received: by 2002:a05:600c:4f86:b0:4a1:fa21:fd90 with SMTP id 5b1f17b1804b1-4b960d9b17dmr61969495e9.9.1794214666809; Mon, 09 Nov 2026 00:57:46 -0800 (PST) Received: from [192.168.1.22] ([83.231.69.9]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4b79501502asm149200295e9.2.2026.11.09.00.57.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 09 Nov 2026 00:57:46 -0800 (PST) Message-ID: Date: Mon, 9 Nov 2026 09:57:43 +0100 X-Mailing-List: stable@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/5] mm: limit pagecache folio refcount when splicing into pipes To: "David Hildenbrand (Arm)" , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , "Matthew Wilcox (Oracle)" , Jan Kara , Andrew Morton , Zi Yan , Baolin Wang , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Lance Yang , Usama Arif , Kiryl Shutsemau , Matthew Brost , Joshua Hahn , Byungchul Park , Gregory Price , Ying Huang , Alistair Popple , Peter Xu , Johannes Weiner , Song Liu , Rik van Riel , Miklos Szeredi , Alexander Viro , Christian Brauner , Hugh Dickins , Will Deacon , "Aneesh Kumar K.V" , Nick Piggin , Peter Zijlstra , Arnd Bergmann , Jason Gunthorpe , Kevin Tian , "Joerg Roedel (AMD)" , Robin Murphy , Steve Sistare , John Hubbard , Josef Bacik Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, fuse-devel@lists.linux.dev, linux-arch@vger.kernel.org, iommu@lists.linux.dev, stable@vger.kernel.org References: <20261107-refcount_overflow_stable-v2-0-c38f6809b106@kernel.org> <20261107-refcount_overflow_stable-v2-2-c38f6809b106@kernel.org> Content-Language: en-US From: "Jose A. Perez de Azpillaga" In-Reply-To: <20261107-refcount_overflow_stable-v2-2-c38f6809b106@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 11/7/26 11:23 PM, David Hildenbrand (Arm) wrote: > Similar to mapping pagecache folios into page tables, let's reject > additional references when splicing folios into a pipe if the refcount > is at its limit, similar to how we handle it during GUP. > > This will prevent more cases of possible folio refcount overflows with > large pagecache folios. > > Let's keep it simple and check in the two callers of > splice_folio_into_pipe(). Return -EOVERFLOW if the limit prevents any > progress, so do_splice_read() can fall back to copy_splice_read() when > read_iter is available. This keeps sendfile() and other splice users > working when ordinary reads would still succeed. > > Also fall back to copying in FUSE when taking another reference through > fuse_ref_folio() would exceed the limit. > > Also check in try_get_page() to cover pipe-buffer duplication by tee() > and partial pipe-to-pipe splicing. > > Fixes: 800d8c63b2e9 ("shmem: add huge pages support") > Fixes: 99cb0dbd47a1 ("mm,thp: add read-only THP support for (non-shmem) FS") > Fixes: 793917d997df ("mm/readahead: Add large folio readahead") > Cc: stable@vger.kernel.org > Signed-off-by: David Hildenbrand (Arm) > --- > fs/fuse/dev.c | 5 +++-- > fs/splice.c | 8 +++++++- > include/linux/mm.h | 9 ++++++--- > mm/filemap.c | 11 ++++++++--- > mm/shmem.c | 4 ++++ > 5 files changed, 28 insertions(+), 9 deletions(-) > > diff --git a/fs/fuse/dev.c b/fs/fuse/dev.c > index 3641abb90d6bb..4f6b7b42bfd3e 100644 > --- a/fs/fuse/dev.c > +++ b/fs/fuse/dev.c > @@ -1265,9 +1265,10 @@ int fuse_copy_folio(struct fuse_copy_state *cs, struct folio **foliop, > if (cs->write && cs->pipebufs && folio) { > /* > * Can't control lifetime of pipe buffers, so always > - * copy user pages. > + * copy user pages. Also copy folios at their refcount limit. > */ > - if (cs->req->args->user_pages) { > + if (cs->req->args->user_pages || > + unlikely(folio_ref_count_over_limit(folio))) { > err = fuse_copy_fill(cs); > if (err) > return err; > diff --git a/fs/splice.c b/fs/splice.c > index e6d43329ed3f0..df73a4e65118b 100644 > --- a/fs/splice.c > +++ b/fs/splice.c > @@ -956,6 +956,7 @@ static ssize_t do_splice_read(struct file *in, loff_t *ppos, > unsigned int flags) > { > unsigned int p_space; > + ssize_t ret; > > if (unlikely(!(in->f_mode & FMODE_READ))) > return -EBADF; > @@ -977,7 +978,12 @@ static ssize_t do_splice_read(struct file *in, loff_t *ppos, > */ > if ((in->f_flags & O_DIRECT) || IS_DAX(in->f_mapping->host)) > return copy_splice_read(in, ppos, pipe, len, flags); > - return in->f_op->splice_read(in, ppos, pipe, len, flags); > + ret = in->f_op->splice_read(in, ppos, pipe, len, flags); > + > + /* Fallback to copying when hitting folio refcount limits. */ > + if (unlikely(ret == -EOVERFLOW) && in->f_op->read_iter) > + ret = copy_splice_read(in, ppos, pipe, len, flags); here it can't tell where the -EOVERFLOW came from, if another file returns -EOVERFLOW (i.e. tty_fops uses copy_splice_read, and n_hdlc_tty_read() returns -EOVERFLOW after dropping the frame), it now gets a second read. also, the first read already lost data. so the data read returns different data, the dropped frame is never reported and returns the next frame instead. -- cheers, jose a. p-a