From: Catalin Marinas <catalin.marinas@arm.com>
To: will@kernel.org, nathan@kernel.org,
nick.desaulniers+lkml@gmail.com, morbo@google.com,
justinstitt@google.com, broonie@kernel.org, maz@kernel.org,
oliver.upton@linux.dev, joey.gouly@arm.com,
shameerali.kolothum.thodi@huawei.com, james.morse@arm.com,
hardevsinh.palaniya@siliconsignals.io, ardb@kernel.org,
ryan.roberts@arm.com, Yeoreum Yun <yeoreum.yun@arm.com>
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, llvm@lists.linux.dev,
stable@vger.kernel.org
Subject: Re: [PATCH v2] arm64/cpufeature: annotate arm64_use_ng_mappings with ro_after_init to prevent wrong idmap generation
Date: Sat, 3 May 2025 15:11:36 +0100 [thread overview]
Message-ID: <aBYkGJmfWDZHBEzp@arm.com> (raw)
In-Reply-To: <174626735218.2189871.10298017577558632540.b4-ty@arm.com>
On Sat, May 03, 2025 at 11:16:12AM +0100, Catalin Marinas wrote:
> On Fri, 02 May 2025 19:04:12 +0100, Yeoreum Yun wrote:
> > create_init_idmap() could be called before .bss section initialization
> > which is done in early_map_kernel().
> > Therefore, data/test_prot could be set incorrectly by PTE_MAYBE_NG macro.
> >
> > PTE_MAYBE_NG macro set NG bit according to value of "arm64_use_ng_mappings".
> > and this variable places in .bss section.
> >
> > [...]
>
> Applied to arm64 (for-next/fixes), with some slight tweaking of the
> comment, thanks!
>
> [1/1] arm64/cpufeature: annotate arm64_use_ng_mappings with ro_after_init to prevent wrong idmap generation
> https://git.kernel.org/arm64/c/12657bcd1835
I'm going to drop this for now. The kernel compiled with a clang 19.1.5
version I have around (Debian sid) fails to boot, gets stuck early on:
$ clang --version
Debian clang version 19.1.5 (1)
Target: aarch64-unknown-linux-gnu
Thread model: posix
InstalledDir: /usr/lib/llvm-19/bin
I didn't have time to investigate, disassemble etc. I'll have a look
next week.
--
Catalin
next prev parent reply other threads:[~2025-05-03 14:11 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-02 18:04 [PATCH v2] arm64/cpufeature: annotate arm64_use_ng_mappings with ro_after_init to prevent wrong idmap generation Yeoreum Yun
2025-05-03 10:16 ` Catalin Marinas
2025-05-03 14:11 ` Catalin Marinas [this message]
2025-05-03 20:23 ` Yeoreum Yun
2025-05-05 19:05 ` Catalin Marinas
2025-05-06 8:09 ` Yeoreum Yun
2025-05-06 8:15 ` Ryan Roberts
2025-05-06 8:53 ` Yeoreum Yun
2025-05-06 10:12 ` Catalin Marinas
2025-05-06 10:38 ` Yeoreum Yun
2025-05-06 10:13 ` Ryan Roberts
2025-05-06 9:41 ` Ard Biesheuvel
2025-05-06 10:08 ` Ryan Roberts
2025-05-06 10:47 ` Yeoreum Yun
2025-05-06 10:49 ` Catalin Marinas
2025-05-06 10:57 ` Yeoreum Yun
2025-05-06 10:17 ` Catalin Marinas
2025-05-06 10:22 ` Ryan Roberts
2025-05-06 10:29 ` Catalin Marinas
2025-05-06 10:36 ` Yeoreum Yun
2025-05-06 9:09 ` Catalin Marinas
2025-05-06 10:49 ` Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aBYkGJmfWDZHBEzp@arm.com \
--to=catalin.marinas@arm.com \
--cc=ardb@kernel.org \
--cc=broonie@kernel.org \
--cc=hardevsinh.palaniya@siliconsignals.io \
--cc=james.morse@arm.com \
--cc=joey.gouly@arm.com \
--cc=justinstitt@google.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=maz@kernel.org \
--cc=morbo@google.com \
--cc=nathan@kernel.org \
--cc=nick.desaulniers+lkml@gmail.com \
--cc=oliver.upton@linux.dev \
--cc=ryan.roberts@arm.com \
--cc=shameerali.kolothum.thodi@huawei.com \
--cc=stable@vger.kernel.org \
--cc=will@kernel.org \
--cc=yeoreum.yun@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).