Re: Patch "Bluetooth: MGMT: Remove unused mgmt_pending_find_data" has been added to the 6.6-stable tree

["Dr. David Alan Gilbert" <linux@treblig.org>]

* Sasha Levin (sashal@kernel.org) wrote:
> This is a note to let you know that I've just added the patch titled
> 
>     Bluetooth: MGMT: Remove unused mgmt_pending_find_data
> 
> to the 6.6-stable tree which can be found at:
>     http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
> 
> The filename of the patch is:
>      bluetooth-mgmt-remove-unused-mgmt_pending_find_data.patch
> and it can be found in the queue-6.6 subdirectory.
> 
> If you, or anyone else, feels it should not be added to the stable tree,
> please let <stable@vger.kernel.org> know about it.

<rewinds, copies same message I did for 6.12 - please take this to mean all of them>

It's a cleanup only, so I wouldn't backport it unless it makes backporting
a useful patch easier.

Dave

> 
> 
> 
> commit af31788b431f56d9b304d32701f1f9143aae8f95
> Author: Dr. David Alan Gilbert <linux@treblig.org>
> Date:   Mon Jan 27 21:37:15 2025 +0000
> 
>     Bluetooth: MGMT: Remove unused mgmt_pending_find_data
>     
>     [ Upstream commit 276af34d82f13bda0b2a4d9786c90b8bbf1cd064 ]
>     
>     mgmt_pending_find_data() last use was removed in 2021 by
>     commit 5a7501374664 ("Bluetooth: hci_sync: Convert MGMT_OP_GET_CLOCK_INFO")
>     
>     Remove it.
>     
>     Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
>     Reviewed-by: Simon Horman <horms@kernel.org>
>     Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
>     Stable-dep-of: 6fe26f694c82 ("Bluetooth: MGMT: Protect mgmt_pending list with its own lock")
>     Signed-off-by: Sasha Levin <sashal@kernel.org>
> 
> diff --git a/net/bluetooth/mgmt_util.c b/net/bluetooth/mgmt_util.c
> index 17e32605d9b00..dba6a0d66500f 100644
> --- a/net/bluetooth/mgmt_util.c
> +++ b/net/bluetooth/mgmt_util.c
> @@ -229,23 +229,6 @@ struct mgmt_pending_cmd *mgmt_pending_find(unsigned short channel, u16 opcode,
>  	return NULL;
>  }
>  
> -struct mgmt_pending_cmd *mgmt_pending_find_data(unsigned short channel,
> -						u16 opcode,
> -						struct hci_dev *hdev,
> -						const void *data)
> -{
> -	struct mgmt_pending_cmd *cmd;
> -
> -	list_for_each_entry(cmd, &hdev->mgmt_pending, list) {
> -		if (cmd->user_data != data)
> -			continue;
> -		if (cmd->opcode == opcode)
> -			return cmd;
> -	}
> -
> -	return NULL;
> -}
> -
>  void mgmt_pending_foreach(u16 opcode, struct hci_dev *hdev,
>  			  void (*cb)(struct mgmt_pending_cmd *cmd, void *data),
>  			  void *data)
> diff --git a/net/bluetooth/mgmt_util.h b/net/bluetooth/mgmt_util.h
> index bdf978605d5a8..f2ba994ab1d84 100644
> --- a/net/bluetooth/mgmt_util.h
> +++ b/net/bluetooth/mgmt_util.h
> @@ -54,10 +54,6 @@ int mgmt_cmd_complete(struct sock *sk, u16 index, u16 cmd, u8 status,
>  
>  struct mgmt_pending_cmd *mgmt_pending_find(unsigned short channel, u16 opcode,
>  					   struct hci_dev *hdev);
> -struct mgmt_pending_cmd *mgmt_pending_find_data(unsigned short channel,
> -						u16 opcode,
> -						struct hci_dev *hdev,
> -						const void *data);
>  void mgmt_pending_foreach(u16 opcode, struct hci_dev *hdev,
>  			  void (*cb)(struct mgmt_pending_cmd *cmd, void *data),
>  			  void *data);
-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/