From: Jiri Olsa <olsajiri@gmail.com>
To: Suleiman Souhlal <suleiman@google.com>
Cc: Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>,
Martin KaFai Lau <martin.lau@linux.dev>,
Eduard Zingerman <eddyz87@gmail.com>, Song Liu <song@kernel.org>,
Yonghong Song <yonghong.song@linux.dev>,
John Fastabend <john.fastabend@gmail.com>,
KP Singh <kpsingh@kernel.org>,
Stanislav Fomichev <sdf@fomichev.me>, Hao Luo <haoluo@google.com>,
Masahiro Yamada <masahiroy@kernel.org>,
Ian Rogers <irogers@google.com>,
ssouhlal@freebsd.org, bpf@vger.kernel.org,
linux-kernel@vger.kernel.org, llvm@lists.linux.dev,
stable@vger.kernel.org
Subject: Re: [PATCH v2] tools/resolve_btfids: Fix build when cross compiling kernel with clang.
Date: Fri, 6 Jun 2025 10:11:53 +0200 [thread overview]
Message-ID: <aEKiyUwKGDUAs3sf@krava> (raw)
In-Reply-To: <20250606074538.1608546-1-suleiman@google.com>
On Fri, Jun 06, 2025 at 04:45:38PM +0900, Suleiman Souhlal wrote:
> When cross compiling the kernel with clang, we need to override
> CLANG_CROSS_FLAGS when preparing the step libraries.
>
> Prior to commit d1d096312176 ("tools: fix annoying "mkdir -p ..." logs
> when building tools in parallel"), MAKEFLAGS would have been set to a
> value that wouldn't set a value for CLANG_CROSS_FLAGS, hiding the
> fact that we weren't properly overriding it.
>
> Cc: stable@vger.kernel.org
> Fixes: 56a2df7615fa ("tools/resolve_btfids: Compile resolve_btfids as host program")
> Signed-off-by: Suleiman Souhlal <suleiman@google.com>
lgtm
Acked-by: Jiri Olsa <jolsa@kernel.org>
thanks,
jirka
> ---
> v2:
> - "Signed-off-by:" instead of "Signed-of-by".
>
> v1: https://lore.kernel.org/lkml/20250606052301.810338-1-suleiman@google.com/
> ---
> tools/bpf/resolve_btfids/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/bpf/resolve_btfids/Makefile b/tools/bpf/resolve_btfids/Makefile
> index afbddea3a39c..ce1b556dfa90 100644
> --- a/tools/bpf/resolve_btfids/Makefile
> +++ b/tools/bpf/resolve_btfids/Makefile
> @@ -17,7 +17,7 @@ endif
>
> # Overrides for the prepare step libraries.
> HOST_OVERRIDES := AR="$(HOSTAR)" CC="$(HOSTCC)" LD="$(HOSTLD)" ARCH="$(HOSTARCH)" \
> - CROSS_COMPILE="" EXTRA_CFLAGS="$(HOSTCFLAGS)"
> + CROSS_COMPILE="" CLANG_CROSS_FLAGS="" EXTRA_CFLAGS="$(HOSTCFLAGS)"
>
> RM ?= rm
> HOSTCC ?= gcc
> --
> 2.50.0.rc0.642.g800a2b2222-goog
>
next prev parent reply other threads:[~2025-06-06 8:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-06 7:45 [PATCH v2] tools/resolve_btfids: Fix build when cross compiling kernel with clang Suleiman Souhlal
2025-06-06 8:11 ` Jiri Olsa [this message]
2025-06-10 17:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aEKiyUwKGDUAs3sf@krava \
--to=olsajiri@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=eddyz87@gmail.com \
--cc=haoluo@google.com \
--cc=irogers@google.com \
--cc=john.fastabend@gmail.com \
--cc=kpsingh@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=martin.lau@linux.dev \
--cc=masahiroy@kernel.org \
--cc=sdf@fomichev.me \
--cc=song@kernel.org \
--cc=ssouhlal@freebsd.org \
--cc=stable@vger.kernel.org \
--cc=suleiman@google.com \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox