From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: yunhui cui <cuiyunhui@bytedance.com>,
arnd@arndb.de, benjamin.larsson@genexis.eu,
heikki.krogerus@linux.intel.com, ilpo.jarvinen@linux.intel.com,
jirislaby@kernel.org, jkeeping@inmusicbrands.com,
john.ogness@linutronix.de, linux-kernel@vger.kernel.org,
linux-serial@vger.kernel.org, markus.mayer@linaro.org,
matt.porter@linaro.org, namcao@linutronix.de, paulmck@kernel.org,
pmladek@suse.com, schnelle@linux.ibm.com,
sunilvl@ventanamicro.com, tim.kryger@linaro.org,
stable@vger.kernel.org
Subject: Re: [External] Re: [PATCH v8 1/4] serial: 8250: fix panic due to PSLVERR
Date: Mon, 9 Jun 2025 23:06:13 +0300 [thread overview]
Message-ID: <aEc-taZPSrO520ui@smile.fi.intel.com> (raw)
In-Reply-To: <2025060925-curator-stubbed-bfb4@gregkh>
On Mon, Jun 09, 2025 at 03:44:19PM +0200, Greg KH wrote:
> On Mon, Jun 09, 2025 at 09:18:02PM +0800, yunhui cui wrote:
> > On Mon, Jun 9, 2025 at 6:10 PM Greg KH <gregkh@linuxfoundation.org> wrote:
> > > On Mon, Jun 09, 2025 at 03:43:45PM +0800, Yunhui Cui wrote:
...
> > > - This looks like a new version of a previously submitted patch, but you
> > > did not list below the --- line any changes from the previous version.
> > > Please read the section entitled "The canonical patch format" in the
> > > kernel file, Documentation/process/submitting-patches.rst for what
> > > needs to be done here to properly describe this.
> >
> > Can this issue reported by the bot be ignored?
>
> No, why? How do we know what changed from previous versions? Otherwise
> we assume you just ignored previous review comments?
>
> This series took at least 8 tries for some reason, might as well
> document it, right? :)
+ many to what Greg said. The main problem you have is the absence of cover
letter, where it's naturally to put changelog for the series.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2025-06-09 20:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-09 7:43 [PATCH v8 1/4] serial: 8250: fix panic due to PSLVERR Yunhui Cui
2025-06-09 7:43 ` [PATCH v8 2/4] serial: 8250: avoid potential PSLVERR issue Yunhui Cui
2025-06-09 7:45 ` kernel test robot
2025-06-10 9:07 ` [External] " yunhui cui
2025-06-09 7:43 ` [PATCH v8 3/4] serial: 8250_dw: assert port->lock is held in dw8250_force_idle() Yunhui Cui
2025-06-09 7:43 ` [PATCH v8 4/4] serial: 8250_dw: fix PSLVERR on RX_TIMEOUT Yunhui Cui
2025-06-09 10:09 ` [PATCH v8 1/4] serial: 8250: fix panic due to PSLVERR Greg KH
2025-06-09 13:18 ` [External] " yunhui cui
2025-06-09 13:44 ` Greg KH
2025-06-09 20:06 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aEc-taZPSrO520ui@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=arnd@arndb.de \
--cc=benjamin.larsson@genexis.eu \
--cc=cuiyunhui@bytedance.com \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jirislaby@kernel.org \
--cc=jkeeping@inmusicbrands.com \
--cc=john.ogness@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=markus.mayer@linaro.org \
--cc=matt.porter@linaro.org \
--cc=namcao@linutronix.de \
--cc=paulmck@kernel.org \
--cc=pmladek@suse.com \
--cc=schnelle@linux.ibm.com \
--cc=stable@vger.kernel.org \
--cc=sunilvl@ventanamicro.com \
--cc=tim.kryger@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox