From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8C7CB29A0; Tue, 10 Jun 2025 02:02:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749520950; cv=none; b=Oo7zPzUBHBVzhqcLUHlbI7ITF/Mzp3qMZ9quUukI6BR3XYAg2ON6eO6Wqi0hzj6G/XHu7r3+XZFFbYHJmk9s55B+4wFMfnGQLw1eA8C6m0BuUghhbqKQa5mMlwpe2MNeOIff0/1IPEIl/Se5P7852mgux0FDqn6SYeHgapcmDIA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749520950; c=relaxed/simple; bh=ttDJDhDpFtCMC0+vuZRTUO90BrueMuUcXX2mP6poPGc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=aLXXdBE8H0w1lXFbAPRWTnnhjAWqhxDBwLQhhmwKdmab6L4rvxXKcCIOQL9k5fo+bCieaPsIWghsjTAvTSB4RdSXiM/LbnHspfN7AndbJ9qcolFXTV7FU/Q+SdrkFoyJ6BHCRxBTmDZrjbNGr/Pp4pFNo29sydI4qWTKDxehY3U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Z379nVpM; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Z379nVpM" Received: by smtp.kernel.org (Postfix) with ESMTPSA id BC49AC4CEEB; Tue, 10 Jun 2025 02:02:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1749520950; bh=ttDJDhDpFtCMC0+vuZRTUO90BrueMuUcXX2mP6poPGc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Z379nVpMBO8Y5FQsPdUEPYOAAWPUiJTIxY5Ee2F8SawSdOzBZhzOvuk+1MJzqNaU5 E6TLgmRBCssxuVkoGvRE2eF9encC2DnVZ2WMZQTLlWBuzRWC4kBqsN3wBGwBsFmO46 FaEw4xHNgorgu+GbpNUorxbnfmDFYppQ0ST299sX/dnTz0c50W7wgbwUtO/9URewwl TN5H5puLg18W24XrW9ZmnHw18sro57ND6Go3xq83gyz8koGeL4AJQTPg6edfBF+FGN vuxd4Z1uwwuFq95PWpn9UG6jeXgq1Gla6GwOow94aUwf32gbCtWml/jPOGad2u/LuX uWXV9SURDxb1g== Date: Tue, 10 Jun 2025 02:02:26 +0000 From: Tzung-Bi Shih To: Thomas =?iso-8859-1?Q?Wei=DFschuh?= Cc: Lee Jones , Benson Leung , Guenter Roeck , chrome-platform@lists.linux.dev, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Tom Vincent Subject: Re: [PATCH v2] mfd: cros_ec: Separate charge-control probing from USB-PD Message-ID: References: <20250609-cros-ec-mfd-chctl-probe-v2-1-33b236a7b7bc@weissschuh.net> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20250609-cros-ec-mfd-chctl-probe-v2-1-33b236a7b7bc@weissschuh.net> On Mon, Jun 09, 2025 at 11:39:35AM +0200, Thomas Weißschuh wrote: > The charge-control subsystem in the ChromeOS EC is not strictly tied to > its USB-PD subsystem. > Since commit 7613bc0d116a ("mfd: cros_ec: Don't load charger with UCSI") > the presence of EC_FEATURE_UCSI_PPM would inhibit the probing of the > charge-control driver. > Furthermore recent versions of the EC firmware in Framework laptops > hard-disable EC_FEATURE_USB_PD to avoid probing cros-usbpd-charger, > which then also breaks cros-charge-control. > > Instead use the dedicated EC_FEATURE_CHARGER. > > Link: https://github.com/FrameworkComputer/EmbeddedController/commit/1d7bcf1d50137c8c01969eb65880bc83e424597e > Fixes: 555b5fcdb844 ("mfd: cros_ec: Register charge control subdevice") > Cc: stable@vger.kernel.org > Tested-by: Tom Vincent > Signed-off-by: Thomas Weißschuh Reviewed-by: Tzung-Bi Shih