From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: "Tomita Moeko" <tomitamoeko@gmail.com>,
"Lucas De Marchi" <lucas.demarchi@intel.com>,
"Thomas Hellström" <thomas.hellstrom@linux.intel.com>,
intel-xe@lists.freedesktop.org, stable@vger.kernel.org,
"Michal Wajdeczko" <michal.wajdeczko@intel.com>,
"Badal Nilawar" <badal.nilawar@intel.com>,
"Himal Prasad Ghimiray" <himal.prasad.ghimiray@intel.com>
Subject: Re: [PATCH 6.12 4/4] Revert "drm/xe/forcewake: Add a helper xe_force_wake_ref_has_domain()"
Date: Tue, 29 Jul 2025 17:29:38 -0400 [thread overview]
Message-ID: <aIk9Qh6sZdEks-9I@intel.com> (raw)
In-Reply-To: <2025072932-unjustly-thirty-b125@gregkh>
On Tue, Jul 29, 2025 at 04:51:02PM +0200, Greg KH wrote:
> On Tue, Jul 29, 2025 at 07:05:25PM +0800, Tomita Moeko wrote:
> > This reverts commit deb05f8431f31e08fd6ab99a56069fc98014dbec.
> >
> > The helper function introduced in the reverted commit is for handling
> > the "refcounted domain mask" introduced in commit a7ddcea1f5ac
> > ("drm/xe: Error handling in xe_force_wake_get()"). Since that API change
> > only exists in 6.13 and later, this helper is unnecessary in 6.12 stable
> > kernel.
> >
> > Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>
> > Cc: Badal Nilawar <badal.nilawar@intel.com>
> > Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> > Cc: Himal Prasad Ghimiray <himal.prasad.ghimiray@intel.com>
> > Signed-off-by: Tomita Moeko <tomitamoeko@gmail.com>
> > ---
> > drivers/gpu/drm/xe/xe_force_wake.h | 16 ----------------
> > 1 file changed, 16 deletions(-)
>
> We need acks from the maintainers/developers for all of these before we
> can take the series. Please work on getting that.
Acked-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Looking to the history here it looks these patches were ported as
dependency of a fix:
Stable-dep-of: 5dce85fecb87 ("drm/xe: Move the coredump registration to the
worker thread")
However it is definitely not needed and these reverts here end-up with
the right conflict resolution that should had been done in this
commit 5dce85fecb87 ("drm/xe: Move the coredump registration to the
worker thread").
Thanks for the clean-up,
Rodrigo.
>
> thanks,
>
> greg k-h
next prev parent reply other threads:[~2025-07-29 21:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-29 11:05 [PATCH 6.12 0/4] drm/xe: Fix xe_force_wake_get return handling Tomita Moeko
2025-07-29 11:05 ` [PATCH 6.12 1/4] Revert "drm/xe/gt: Update handling of xe_force_wake_get return" Tomita Moeko
2025-07-29 21:03 ` Sasha Levin
2025-07-29 11:05 ` [PATCH 6.12 2/4] Revert "drm/xe/tests/mocs: Update xe_force_wake_get() return handling" Tomita Moeko
2025-07-29 19:45 ` Sasha Levin
2025-07-29 11:05 ` [PATCH 6.12 3/4] Revert "drm/xe/devcoredump: Update handling of xe_force_wake_get return" Tomita Moeko
2025-07-29 19:45 ` Sasha Levin
2025-07-29 11:05 ` [PATCH 6.12 4/4] Revert "drm/xe/forcewake: Add a helper xe_force_wake_ref_has_domain()" Tomita Moeko
2025-07-29 14:51 ` Greg KH
2025-07-29 21:29 ` Rodrigo Vivi [this message]
2025-07-29 19:37 ` Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aIk9Qh6sZdEks-9I@intel.com \
--to=rodrigo.vivi@intel.com \
--cc=badal.nilawar@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=himal.prasad.ghimiray@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=lucas.demarchi@intel.com \
--cc=michal.wajdeczko@intel.com \
--cc=stable@vger.kernel.org \
--cc=thomas.hellstrom@linux.intel.com \
--cc=tomitamoeko@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox