Linux kernel -stable discussions
 help / color / mirror / Atom feed
From: Salvatore Bonaccorso <carnil@debian.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Jari Ruusu <jariruusu@protonmail.com>,
	Yi Yang <yiyang13@huawei.com>, GONG Ruiqi <gongruiqi1@huawei.com>,
	Helge Deller <deller@gmx.de>, Sasha Levin <sashal@kernel.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	"stable@vger.kernel.org" <stable@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: Text mode VGA-console scrolling is broken in upstream & stable trees
Date: Wed, 30 Jul 2025 17:20:41 +0200	[thread overview]
Message-ID: <aIo4SSJXIrJEanmP@eldamar.lan> (raw)
In-Reply-To: <2025073054-stipend-duller-9622@gregkh>

Hi,

On Wed, Jul 30, 2025 at 04:26:44PM +0200, Greg Kroah-Hartman wrote:
> On Wed, Jul 30, 2025 at 02:06:27PM +0000, Jari Ruusu wrote:
> > The patch that broke text mode VGA-console scrolling is this one:
> > "vgacon: Add check for vc_origin address range in vgacon_scroll()"
> > commit 864f9963ec6b4b76d104d595ba28110b87158003 upstream.
> > 
> > How to preproduce:
> > (1) boot a kernel that is configured to use text mode VGA-console
> > (2) type commands:  ls -l /usr/bin | less -S
> > (3) scroll up/down with cursor-down/up keys
> > 
> > Above mentioned patch seems to have landed in upstream and all
> > kernel.org stable trees with zero testing. Even minimal testing
> > would have shown that it breaks text mode VGA-console scrolling.
> > 
> > Greg, Sasha, Linus,
> > Please consider reverting that buggy patch from all affected trees.
> 
> Please work to fix it in Linus's tree first and then we will be glad to
> backport the needed fix.

FWIW, and maybe just an interesting side node: if it ever get
considered to revert the commit, this will re-introduce/re-open
CVE-2025-38213.

Cf. https://lore.kernel.org/linux-cve-announce/2025070422-CVE-2025-38213-c3e3@gregkh/T/#u

Regards,
Salvatore

  reply	other threads:[~2025-07-30 15:20 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-30 14:06 Text mode VGA-console scrolling is broken in upstream & stable trees Jari Ruusu
2025-07-30 14:26 ` Greg Kroah-Hartman
2025-07-30 15:20   ` Salvatore Bonaccorso [this message]
2025-07-31  7:22 ` Jiri Slaby
2025-07-31 16:12   ` Jari Ruusu
2025-08-02 19:54     ` Helge Deller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aIo4SSJXIrJEanmP@eldamar.lan \
    --to=carnil@debian.org \
    --cc=deller@gmx.de \
    --cc=gongruiqi1@huawei.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jariruusu@protonmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sashal@kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    --cc=yiyang13@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox