From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7BB363002BF for ; Thu, 14 Aug 2025 13:08:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755176919; cv=none; b=kaFkplMkgB9LtvqHu6XXZVMLI//99Q2oxklwwQec2nRO/Jag0n0onUcGj+BAXRE0yHVM+KEOAitHBXYeY/P5eadUSsZwMTb96O5YmgMssFuZr84ySgkL8+wqPFX9WUxNvf8nVD12bRB5oBUaZXMZJfmK+O3t1F8bU47HqNOSte8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755176919; c=relaxed/simple; bh=FuZUXMmhHJGVUjBnFYOgaSI3zy0JsnycBebl5UMzPPY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=EfTATowc9NKlp45wvdGQcY+sS0pSFE7bot2twPij1+ai3IOoP1+Icn64b/l92weCDNa9vbRhFsNr3Tt3ELeqvVVLoxO5iaXW9M7Mzoi3qUOxSp8cVGwDEw+fN9ixERIfm7FiH2wtoS/JRGqCoscFtofmiyzP+xhfnCAVAdV65OU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9E5C2C4CEF1; Thu, 14 Aug 2025 13:08:37 +0000 (UTC) Date: Thu, 14 Aug 2025 14:08:35 +0100 From: Catalin Marinas To: Gu Bowen Cc: Andrew Morton , stable@vger.kernel.org, linux-mm@kvack.org, Waiman Long , Breno Leitao , John Ogness , Lu Jialin , Greg Kroah-Hartman Subject: Re: [PATCH v3] mm: Fix possible deadlock in console_trylock_spinning Message-ID: References: <20250813085310.2260586-1-gubowen5@huawei.com> <20250813155616.d7e5a832ce7cda7764942d10@linux-foundation.org> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Thu, Aug 14, 2025 at 10:33:56AM +0800, Gu Bowen wrote: > On 8/14/2025 6:56 AM, Andrew Morton wrote: > > I'm not sure which kernel version this was against, but kmemleak.c has > > changed quite a lot. > > > > Could we please see a patch against a latest kernel version? Linus > > mainline will suit. > > > > Thanks. > > I discovered this issue in kernel version 5.10. Afterwards, I reviewed the > code of the mainline version and found that this deadlock path no longer > exists due to the refactoring of console_lock in v6.2-rc1. For details on > the refactoring, you can refer to this link : > https://lore.kernel.org/all/20221116162152.193147-1-john.ogness@linutronix.de/. > Therefore, theoretically, this issue existed before the refactoring of > console_lock. Oh, so you can no longer hit this issue with mainline. This wasn't mentioned (or I missed it) in the commit log. So this would be a stable-only fix that does not have a correspondent upstream. Adding Greg for his opinion. -- Catalin