From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 541A2216E2A; Mon, 4 Aug 2025 02:36:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=205.220.165.32 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754274995; cv=fail; b=Lb7y9N5BKTKTq0l4mMvnC3ynfW44VaMh3ldF/01eRXqRK1iiP9GWK2jToJML+musZJQNzM4kSbMHc1sBudgZ9S30eyWhg96BoF0JB4YqTA/4YH/R2O3LViVayNKDBW3/hhy9bNsz3lmdLfHErCR/sndN+Xf8+nhPi2BN7CM7Zrg= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754274995; c=relaxed/simple; bh=1OrRqbhEiccBCwORJ9ebysXO2ppEj63NT4usELse80U=; h=Date:From:To:Cc:Subject:Message-ID:References:Content-Type: Content-Disposition:In-Reply-To:MIME-Version; b=dWePKEQrFPCB5g09dTa0Tx1kd7RBeFZyBe+kNGMFrJBgQz3btZH8O0MyKYp65lES93/C3YPVDErxT5keBSfsqgTZiEebnU7i8KJ0PE4WfXmmkplzeh2MLZ3Kej3H3WnkkDg83sfpXcJSeBHv/k6FV//Rq9vcaklA2ROI2/EQv2w= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com; spf=pass smtp.mailfrom=oracle.com; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b=UZGFzzmd; dkim=pass (1024-bit key) header.d=oracle.onmicrosoft.com header.i=@oracle.onmicrosoft.com header.b=YEMl/sNr; arc=fail smtp.client-ip=205.220.165.32 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oracle.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="UZGFzzmd"; dkim=pass (1024-bit key) header.d=oracle.onmicrosoft.com header.i=@oracle.onmicrosoft.com header.b="YEMl/sNr" Received: from pps.filterd (m0333521.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 573M2NNT026186; Mon, 4 Aug 2025 02:36:13 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=corp-2025-04-25; bh=7qwiqFVSjnCvtrOOij KZLdNZKXNc9knX3BtgLSCxbFE=; b=UZGFzzmdelziVErc1WFQhm1sWRytJnF3mu 1Uu740KeRM770h/5fj0jZJrwJ5QNPZFkjsglJhvY7sSy32eprFDciVvtqKNonoHC f9dfcjmExfIMVCI18muAGzPC23V2u0HWRKkb1/YB1JutBBEdWjP+DzzGZNYke9Bu p57F2G5Q35CgvkBprUHi0AQMCWtcZrd+4S215QpUVI/NjDcl3tqeD77fWWvV+Bof DGmBYpMcCvYXSSoBeopLec5YhBoai31eJcq5W4X6asE7948qn3TzavFeNo/TOsQ4 FfLYjD7ywG45l1umRLOaDehqDb961JxajNh7BWxtsRw4eT0ENWRg== Received: from phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta01.appoci.oracle.com [138.1.114.2]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 4899kf9tch-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 04 Aug 2025 02:36:12 +0000 (GMT) Received: from pps.filterd (phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 573Mj0bu025548; Mon, 4 Aug 2025 02:36:12 GMT Received: from dm1pr04cu001.outbound.protection.outlook.com (mail-centralusazon11010001.outbound.protection.outlook.com [52.101.61.1]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 48a7jrujgx-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 04 Aug 2025 02:36:11 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=TpQqaTO8pW43CT3HBoHQ4YL13luUGPOYbnfu4ONn7UXlHMLWIrub0YBp/YS2b6RuiE2Nw63bd+WBHW433/fgnEYVwKC9K4tG9Cm9gxbNg5aJN8n2FXUBtTMVtquQaOzykUd8v5Oq/Z23+qx90FWMXu4GONwHmfQKWXo9h9DgjESsjGj+aHp89no/qPzts2/+s8frez0Np4HlaTiFp833/ohwHtyEcxNztmWYFhPi1madfWYmEH/JFByMMJqlGcY1aZ1Z4lBELeYBiD0LL/nJJGmdRjfCTHMe5fI8+/+w8TyQu0PIqeKRaq8P8wfPrjd5PpTTlXzrXbOnkU7NddGEsA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7qwiqFVSjnCvtrOOijKZLdNZKXNc9knX3BtgLSCxbFE=; b=cRYLeQFD3aULpUS1q1MVb1kEHIax/M9o8k0WCVtVOUkVELqIfBqrujuJEWvzdZNOWXWqL8CVkMFMu03E9/ss9+iwAyCoj75mU6dY9KzcmuMpzzcXzBjQmTCXdRPDnEzHjv/3qkxekGPIgH5pQCbS1k7CXn5coo5GCPsyRWPK05kkvhlr7JVSvZiUAz0K/MaoQ5hPAl5Gw2goc+sOcLP3mlE/0hdWC2J6/NETrEiVsXnwzCK49+Ti4cs1gG+y9vsMczFYX2SzJBrBC+VaC24zqvy8H1Zd45wtd1i1KjacgRtXOo8vgPyg+8XjBXEF50gHlJjTYzgk3PyY8WG1fi1HEQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7qwiqFVSjnCvtrOOijKZLdNZKXNc9knX3BtgLSCxbFE=; b=YEMl/sNroDrXPaXRBi7d+8OZYscwjavbNlFZd5mMaFW6iq4ujP/Dh6+ND8yVzocFKOSv+VjT3C9vNOf+Ea6/uvOo9HDKAd0nLbAZ7381X4Da/My7xlvcPHxjSj0LYwrUzAbEzWYfInxt37YhMyJRKcJmTZDCsp4RYzcx5utpnAg= Received: from CH3PR10MB7329.namprd10.prod.outlook.com (2603:10b6:610:12c::16) by IA0PR10MB7667.namprd10.prod.outlook.com (2603:10b6:208:48a::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8989.20; Mon, 4 Aug 2025 02:36:08 +0000 Received: from CH3PR10MB7329.namprd10.prod.outlook.com ([fe80::f238:6143:104c:da23]) by CH3PR10MB7329.namprd10.prod.outlook.com ([fe80::f238:6143:104c:da23%7]) with mapi id 15.20.8989.018; Mon, 4 Aug 2025 02:36:08 +0000 Date: Mon, 4 Aug 2025 11:35:57 +0900 From: Harry Yoo To: Li Qiong Cc: Christoph Lameter , David Rientjes , Andrew Morton , Vlastimil Babka , Roman Gushchin , linux-mm@kvack.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH v5] mm/slub: avoid accessing metadata when pointer is invalid in object_err() Message-ID: References: <20250804014626.134396-1-liqiong@nfschina.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: SEWP216CA0016.KORP216.PROD.OUTLOOK.COM (2603:1096:101:2b6::10) To CH3PR10MB7329.namprd10.prod.outlook.com (2603:10b6:610:12c::16) Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH3PR10MB7329:EE_|IA0PR10MB7667:EE_ X-MS-Office365-Filtering-Correlation-Id: f7c2c90a-ce3e-4c8f-45a6-08ddd2ffaafd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014|7053199007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?T3mUwYBG6JclWb5IrQzW8oW4tyY1TcSQ6Xd1Ksv7VcqxBDlrdf50aO5KBZBY?= =?us-ascii?Q?83eKW9QGvUaI86QKqEc6NlZEtaDhqe+xkMtBQz4r1snnI4hku+BP2EhbF8TK?= =?us-ascii?Q?63jr96zu8iUvgbHbbXxzBcOHXssCH5RkDJVJ8rc7+22UrdPQv+u92VRLAarv?= =?us-ascii?Q?LpGpLgT8BGjKVvokqTzF+DTxf4VShGdTYXBBwE8gRBdP2Xva4OE6MRQ+lDAz?= =?us-ascii?Q?rUfSS80IQA8WXK2pdM9HkOekEqyh+wJ/HX3OsRCuf94RwYrpp4yllKjwBy5g?= =?us-ascii?Q?fXyadYIFDTs+L1GYmqLqScXszVPtBP1pICjgwKjbYMJ5M9YpQzFnLpFFrvo2?= =?us-ascii?Q?59SU8HP9mF9pmjr0unmTFSPV+9RPY1ZN1VNPYM5x8mFOJVIiRCHDs425vLSh?= =?us-ascii?Q?6SmuFOvmIt3cxBp+uZW/nal5JzpxTAXTivp8EhvhuZPkNaPv/9CiPiUVKGck?= =?us-ascii?Q?pl24w0su+Vmbc8oKk9rlU5CBLLWlUMme7IdHsBuynj3sg60eVtXRb9sVYVt9?= =?us-ascii?Q?TgcYGqcdPkcEODGNoZfPuNcILpbHuN0CQLHJX9GRH5oD0uZB/PdJGk2ce+62?= =?us-ascii?Q?zjFsz1vU4ITQ0wr/cXIaehEJ+xdVxVncGZf8fZK6FzqPcat3PzMrAcHvbmW4?= =?us-ascii?Q?8niTnMo0s/NLmxgJ+fCzrI8gnzzyfaQBddMHP8zV3CnUyK4pm2ftq795Z+1v?= =?us-ascii?Q?QdJvOAzUcSyOX5d5CdJ3M4lxpv/UBDawlGTn+MFoOZPQs9cp4Q+k/OlRMSdf?= =?us-ascii?Q?zcQBSIPWN7lBZ72H0X4zLnpxdjF59+V+T6NQbGMfKKZ/HkFudk5pvPfnzNWW?= =?us-ascii?Q?8Xb4SRCatubKzKgaxOpzlp3kbCuirifKqZ74tBTy3Sn/+2IYBjjliSS5gHPF?= =?us-ascii?Q?khwW/TEohMD52erfiSNLAE1nUOhZ/tLtK4g8Lcx+sTMv2rpPjRc0PXZt/1ip?= =?us-ascii?Q?xvXYlLnutp7ooC1QZ8QNoLJtyyMOqYcnXsB8tZruNmrsQibeh8kPWRwYerPo?= =?us-ascii?Q?BNqO3Ee2Dw0qPiZD6Pw8XjuZcVoUy+bXK0Nie2HmjEIOSVu81Y/cIP9QAVfA?= =?us-ascii?Q?Zaut0d+sZLTEhiVtCJkTZwxObC5XVbEiGRJxeYes+61N983sbLXuDJV0WOrO?= =?us-ascii?Q?W56m4h9nfnz09WBnEvBe00IIXlg1i2JTOxYusZXkwwCmXPTIOjAV18jTjNZW?= =?us-ascii?Q?Nm7v6sdTCPyTB3DWyHj3iSYsS0a7VxuWbjSO/NFLYBbvQUvC4zNH2/5pcA5p?= =?us-ascii?Q?S/EmZ7h/N79uJghWKZkmxqT1M7S5X7/2kZO7oq6j568u0q08tJg60dgdnm1k?= =?us-ascii?Q?3nPZgC5ggol+uDN6L+26oPu8faf18Tt6XlRpzeLxvkk9bRudNJZYT7JgCfAV?= =?us-ascii?Q?27WQDXCWoFtbbYfUz6vE4rMpTmSO3QvLy1QV+qhmy0O/FJjL8KlvlvfMybdX?= =?us-ascii?Q?dQldj9gMLg4=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH3PR10MB7329.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(376014)(7053199007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?yk4a7bOksyUQHgdhqOiXWlHEj1ccqC36CMl89D0lVaafG29b+vThab9Gdv/O?= =?us-ascii?Q?QIK0kWb6FgF58KXz8HYJpGvcu9Jf5iSLJTEiKXAcyTPHp2N/SBLiHcWHMNP4?= =?us-ascii?Q?hPN0FqgjcmZuLFPYFX4AqKcx5CWODnJI5zSAKggKoStcL+Be7cyjUwn8XSAE?= =?us-ascii?Q?qolXs6JlWqPX/cgS9MCJb67NLCH/wJJG7dmqkjxWARqWSvVE4k6/DP2knWTA?= =?us-ascii?Q?Z7CXTvGTDDBDJS2mN6Ts4TVoi0/I/OZztYDZQCqsOnnZ/f5313TlbxWFmq7d?= =?us-ascii?Q?oMuVnODtKvBoi/yKcyKAK0Hx8pldo8VNTvKlHPdhJIrvsrNau9k3H3svKiY/?= =?us-ascii?Q?03wcyQxLilfeZKk+F7KZLvvRdg9nWEGd/CMVngUthJSUhBzwgdjbEOiM0XNQ?= =?us-ascii?Q?zucJtH5imzuEm988fV0KetIVGFzTuNkiweZlm02SRa+hMBn5FJGRo4nBe4LV?= =?us-ascii?Q?0qi/2Sz4/SJWz8tLGtFw4M4aPkKg2R2asFrNnBbNL2BS2y2CTGyRVYxWMiD1?= =?us-ascii?Q?UP3PTPe4TbZHGY3aDgVkjGh8+RlzrFlLLNkPpzxEj4RiFKpjp1K39Au3QqcM?= =?us-ascii?Q?rmPxJf9xfwDnAH/MFmdm30Glg7mEPkgT185d+JDetHrAC82nhbrHQC2xGcZ/?= =?us-ascii?Q?oA8aFk8J9x+W1YJpq60eBiVghXRl3B6raoxoN43UPDMhODRPi/S7aXkWufOy?= =?us-ascii?Q?dCl3LKCeAZnN73Jo7jyDMZk6Eso7AMNi9sfcBLyPY3c7PzE7MPPqYFXs3eth?= =?us-ascii?Q?fD0t1yFob8j/C1g86rzpMbWcX52T1viS4cGONq7tk+7ciaxLfer96VDuTpUw?= =?us-ascii?Q?cUiMkAkCjuNyDQ0cLW1lZVZmV3Asy/wYYrSLz3U7DriWrlwfPgneiNG8WXDU?= =?us-ascii?Q?W2VI5rzqRQTyi4gELjQCUeFHRvaim14ls17DVk4j8X+0n2lzKAJ98Pq7U1qL?= =?us-ascii?Q?/Yt8ltY0o5Pbjp85V7GumXU57f8zoGwGiorQr3aVFZw61R42d0xuzPNBQV4K?= =?us-ascii?Q?9q09hrRMbrJOxsk+DdYfad644wjRrdDbRnw3i+UG1cMbF2I0pGvpKTQfs0yM?= =?us-ascii?Q?qarPx7vJXdhgS6Zc58V0a377yrBuBwwOoktNG3wB3/ooo45E0SHZb3HSx6xM?= =?us-ascii?Q?l9nhJ7OV6jROWJ15fAO4xd4b4NLWWEmjbuYeOUlgOMiAmLKV/AcatgY990Y7?= =?us-ascii?Q?x5aJDLP//kSoTA5bYySDphxdI8cI+bgBJwAWX/uG4g7XiJrz1UnM2I6tAJI4?= =?us-ascii?Q?z11zFlv0C6Dk/aVBWHPP5xP8BHyav87y1cz59GAFxHhj4xbYJmuSF7ejrjZT?= =?us-ascii?Q?KSCFAjJgB04Zouzxymo+keBuJmKmVQVtPoId3TjefTLNxwfUD2iMvXriU2mA?= =?us-ascii?Q?yzGb+G0oWIBMd+AlkHpMNOGMq2GGxKMb23wMVO08vqrH/kOn34Ch5YVEUvZe?= =?us-ascii?Q?2z5dxqkBbjU23PoX+7HmlUdCP54Ptup+IE6WWZTQ1iBZzZTVl0We8abdBSaC?= =?us-ascii?Q?isgLIEY9JywD2GUss/lYslVidp6l+mFob02UFf31RRD73hduTI+XgaHicvwg?= =?us-ascii?Q?ir2//tzqzpKFqUgub3yEzAuwwxGpVeYCn8N2VI9h?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: iafdeo4g9twIhkwv48FV1j0n5Xm8mTDtBNpYp9x7nfe5bVeeTyxG6LWZ8Rdz098DhPn4dmODeziaWLKKPstA4OPM61+zrD0iTGG8DLarnxyg6dIZuzIxWonG9hRpGr+ebjbhnht8sZ4Vq3V0jjrQd16dLZCpUlCQV9RPqS/cOD2fROgQgN02fELG5QYRBE0q4Cb9iloVdB1YWqdtYebLPZPYPicB73odTJ8vHoEO3jGcLukEZX3UwIxzvhIQbS9Ti+cCy3KJ7+a4ZofyJznRvQCpHbCnoPF8bGxBOU28hw9KgTa5KJHNT2e9t5Y0nBQslZB9X257WeyUqV2F75uPJUZ7nKrrejTgfn0jTrhQuvXjgWckT0bP1dzOyafZq9e6FSv6tFH0Ar/btA0eyLaY4wEKxDj9bFxYJTZPlzzoPhsG5nu6tR8rFkDlW1Y0CTSHCo5R/TWH7CD8CjGIs3oahHDe/uhFA2AWmIGl8aOpp9rEvdMpknGumxkS7n/I71Ee7EGlTOmwdgKj8Y0RSW8OTL65OBFkuswdY19q5/x4WjsPM6xZtU5BVhytt19YvcizFEyimCnIac0J5Gj3bHDP6zQOv5hK46yPfbfxCs/lIes= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: f7c2c90a-ce3e-4c8f-45a6-08ddd2ffaafd X-MS-Exchange-CrossTenant-AuthSource: CH3PR10MB7329.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Aug 2025 02:36:08.4855 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 45rHOq65jYX3qAwvyx+dP0VeFI2X0f4nhsHaUzu21GlKK3Gkb6RN1em4j5r5eDveeJgWR8gsz1+wtOMFsH9WPw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR10MB7667 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-08-04_01,2025-08-01_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 suspectscore=0 mlxscore=0 phishscore=0 mlxlogscore=999 malwarescore=0 spamscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2505160000 definitions=main-2508040012 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwODA0MDAxMiBTYWx0ZWRfX1BzvpqvL0jQE lCintwcepkeAqKNodBFTAJmqmDpmkFyIXUu/j+tgxjQedybcPJnSoKSyT+YHA9V6xA2bfjsjlQc xs/WHhTMFDkpE7+PHJqBEVquMSf7MI2A7e+USeU5Ox0MSZyYDdeiFUvA4t+DQOkirJp12Aw31m8 T2AUUh7rJfae8jwRocaRzgNWyoM9ej832bgJkPTyO7lvcHGosyzAkmJ1TVp7RHoKwtUhv2sUSdM ukvWfYP6pEHt0tmR6lYFHmylLMT0aEZdjZ5FJAydu9jx6T3W+M9YZ1dMs0WkuJj1YBQanVGKZKG EQf5B9u7LzV9PCtY7djJ5zsb6wL6HxVs1CMc6TL+Cg10rCJNvJH00gi/LdrzEJzwNcxm1Zo0qS8 DZab7IGcX4xdz8Z8fEAF/fVp+6RDwLLe7gjDb9wN8Xlmxj4nYXp3VGCSAJix52HuNNYNPU5h X-Proofpoint-GUID: yW4xnxeUMgn0X8tpf6W0WfhzM2Df2oby X-Proofpoint-ORIG-GUID: yW4xnxeUMgn0X8tpf6W0WfhzM2Df2oby X-Authority-Analysis: v=2.4 cv=VMvdn8PX c=1 sm=1 tr=0 ts=68901c9c cx=c_pps a=XiAAW1AwiKB2Y8Wsi+sD2Q==:117 a=XiAAW1AwiKB2Y8Wsi+sD2Q==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=wKuvFiaSGQ0qltdbU6+NXLB8nM8=:19 a=Ol13hO9ccFRV9qXi2t6ftBPywas=:19 a=xqWC_Br6kY4A:10 a=kj9zAlcOel0A:10 a=2OwXVqhp2XgA:10 a=GoEa3M9JfhUA:10 a=VwQbUJbxAAAA:8 a=SlVAvriTAAAA:8 a=yPCof4ZbAAAA:8 a=riyKa_RKWOJBo-HcjdQA:9 a=CjuIK1q_8ugA:10 a=qesGs21RGGeVIEdTuB6w:22 On Mon, Aug 04, 2025 at 11:25:23AM +0900, Harry Yoo wrote: > On Mon, Aug 04, 2025 at 09:46:25AM +0800, Li Qiong wrote: > > object_err() reports details of an object for further debugging, such as > > the freelist pointer, redzone, etc. However, if the pointer is invalid, > > attempting to access object metadata can lead to a crash since it does > > not point to a valid object. > > > > In case check_valid_pointer() returns false for the pointer, only print > > the pointer value and skip accessing metadata. > > > > Fixes: 81819f0fc828 ("SLUB core") > > Cc: > > Signed-off-by: Li Qiong > > --- > > v2: > > - rephrase the commit message, add comment for object_err(). > > v3: > > - check object pointer in object_err(). > > v4: > > - restore changes in alloc_consistency_checks(). > > v5: > > - rephrase message, fix code style. > > --- > > Looks good to me, > Reviewed-by: Harry Yoo > > -- > Cheers, > Harry / Hyeonggon > > > mm/slub.c | 7 ++++++- > > 1 file changed, 6 insertions(+), 1 deletion(-) > > > > diff --git a/mm/slub.c b/mm/slub.c > > index 31e11ef256f9..b3eff1476c85 100644 > > --- a/mm/slub.c > > +++ b/mm/slub.c > > @@ -1104,7 +1104,12 @@ static void object_err(struct kmem_cache *s, struct slab *slab, > > return; > > > > slab_bug(s, reason); > > - print_trailer(s, slab, object); > > + if (!check_valid_pointer(s, slab, object)) { Wait, hold on. check_valid_pointer() returns true when object == NULL. the condition should be (!object || !check_valid_pointer())? > > + print_slab_info(slab); > > + pr_err("Invalid pointer 0x%p\n", object); > > + } else { > > + print_trailer(s, slab, object); > > + } > > add_taint(TAINT_BAD_PAGE, LOCKDEP_NOW_UNRELIABLE); > > > > WARN_ON(1); > > -- > > 2.30.2 -- Cheers, Harry / Hyeonggon