From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A9B2019004A; Mon, 4 Aug 2025 09:02:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=205.220.165.32 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754298144; cv=fail; b=pUC/Zxz2Hshs9cm0CJOWIcwIfgec81KgqgGJ387XBM0qgIsKqI4LayJMQE9WUB7FHGnitQubNoE21OMPxtPcV3pZeS/ASiRMfa3OdjjKMGREI01foqI7E3lvZE+sGgmy53Lxz3j53w5cIr9Xdhvt/qNkzuwuOpjcE9UWIYoj/C0= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754298144; c=relaxed/simple; bh=qX4z02v2QXyRYe/cUTheR+bDx8dnOt+KOPRoLx+dYaY=; h=Date:From:To:Cc:Subject:Message-ID:References:Content-Type: Content-Disposition:In-Reply-To:MIME-Version; b=cRGIpgNZElXRXVSBLYeh+171S1lgxW6DnDYGEz4fgZGBUPvDl4pEdb7+SmeG6EB7qbl3JERRO4j74IWuYEQmYMKQbN7CPlagpxialUlEv7rd0NHWtejKQQEBrLF6WZpRwlG2yQaeRNcwzkVJ1HjKbdpS3jFVMabKYv082CMZrHs= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com; spf=pass smtp.mailfrom=oracle.com; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b=j2C8G5l9; dkim=pass (1024-bit key) header.d=oracle.onmicrosoft.com header.i=@oracle.onmicrosoft.com header.b=xm3GSUz+; arc=fail smtp.client-ip=205.220.165.32 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oracle.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="j2C8G5l9"; dkim=pass (1024-bit key) header.d=oracle.onmicrosoft.com header.i=@oracle.onmicrosoft.com header.b="xm3GSUz+" Received: from pps.filterd (m0246629.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 5747gBxw029420; Mon, 4 Aug 2025 09:02:00 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=corp-2025-04-25; bh=d0V5rK1AF/xaAJYJhA Me08WVMCaLe6/g+296+ifuEQI=; b=j2C8G5l936RwxSeAfD1BwBjsdx5rQuyyYa BwE4zADnjTVsihLEgres9Jzf5vrHPxZYmWU8DM4chDoNjUcpaE12dQBSwOccSVxk NI62sdoJDVYNf8YK49hoDX7OL/WLbWQX5qUmHLxqwc1FpB0Pr9lwkx53uz+AAoZt XM8n2dZHluJFSht7YG63Kt94e9VCTBwOvlYdrkLlLLEWKyqkAdERjLhTj+0m7rWR Ohh4wfTemQF4wxJuzQta0TvHnynzsFcUqy+qjwB7HybRZoDxEO6AKjbvBbfwQ6Wb ZYn//SiH0p2JeCDR5fQWn0FGpaz455P1orZ6HebtLMjSPdNQdBeQ== Received: from iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta02.appoci.oracle.com [147.154.18.20]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 489ajdj6r6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 04 Aug 2025 09:01:59 +0000 (GMT) Received: from pps.filterd (iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 5746nLCm013574; Mon, 4 Aug 2025 09:01:58 GMT Received: from bn8pr05cu002.outbound.protection.outlook.com (mail-eastus2azon11011063.outbound.protection.outlook.com [52.101.57.63]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 48a7mr57pq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 04 Aug 2025 09:01:58 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=g4OTZdZbaYGsNOBMC1kdJGq5MZVBBJxIyKUp5I0mIS8syozTXA4Z7wqTMZRyu3M7JBQe2t2c5VXJPE4AM8y+S2xK0FVPFZzPU0ry3/WoIdl3J9PUnxu78KO7jJVkD9/IMtR5BIUlV03PG2CoyXeGQ2+rUqIOdeEdy9Gv5Kl5OcUCDe2rqm68DCa3ScdIHMbGjpcG2GW+YuarhOj+r3ZApY9JqgqaB/gti0ZJXod+/OsuSWl45vVE2zUIqOYGQYgPz3yI2GgjP+8KgVwhBXIsvMAjG/GpQWLJVGzxmjxt7tRMUxxaAPLAr3TRRpNfwxApx4FylY5nWeO4vvyqJyWPMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=d0V5rK1AF/xaAJYJhAMe08WVMCaLe6/g+296+ifuEQI=; b=GZR66swn1M260jzMYRwFY4ZKWslgKrF3TqV8iEtCNSisY+eVTjpg7WSV2HJYl3OqIjCHyAJzcdLhl7AzbPY1x+eB8EB12Lo6fL9k/rU8+bq987gSQQuT5FphytgGuq0UTzWGs0J34WIc7KNzQu2PB6tIzKSFwi6fO768nhT42Z1WXkcqWEbTd3UmRBTlhiJP/T0rA3lIwX87028K5tB+AmKTmVIGuFiCTEvG/VaGYyKMXlpR1CVzbKrBSKtL1u9D6eNDc/k2SZ5LdX95M370Au1xCQrmsnDNK4Em6B6v8eoT0hq8W72dTsJFL7tHkBGZUmF+tQSrYEzpFRFhENs6pQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=d0V5rK1AF/xaAJYJhAMe08WVMCaLe6/g+296+ifuEQI=; b=xm3GSUz+nL6pwTOgB0kG93e08D+VUEOy5qUn/vHFSmU9vt96bjaIQotd8Pjt4PD59LWcrkWtsKCzmSSf170Nai0Eub8uDucnaI7fFaXSoaJ8LI8GulhK2joDAIVJ3GzCum30OX+ihB11brkzOZ7Q49xKgAMk1J1uIrJlOf32yQM= Received: from CH3PR10MB7329.namprd10.prod.outlook.com (2603:10b6:610:12c::16) by MW6PR10MB7638.namprd10.prod.outlook.com (2603:10b6:303:248::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8989.18; Mon, 4 Aug 2025 09:01:56 +0000 Received: from CH3PR10MB7329.namprd10.prod.outlook.com ([fe80::f238:6143:104c:da23]) by CH3PR10MB7329.namprd10.prod.outlook.com ([fe80::f238:6143:104c:da23%7]) with mapi id 15.20.8989.018; Mon, 4 Aug 2025 09:01:55 +0000 Date: Mon, 4 Aug 2025 18:01:50 +0900 From: Harry Yoo To: Li Qiong Cc: Christoph Lameter , David Rientjes , Andrew Morton , Vlastimil Babka , Roman Gushchin , linux-mm@kvack.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH v6] mm/slub: avoid accessing metadata when pointer is invalid in object_err() Message-ID: References: <20250804025759.382343-1-liqiong@nfschina.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250804025759.382343-1-liqiong@nfschina.com> X-ClientProxiedBy: SEWP216CA0020.KORP216.PROD.OUTLOOK.COM (2603:1096:101:2b6::12) To CH3PR10MB7329.namprd10.prod.outlook.com (2603:10b6:610:12c::16) Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH3PR10MB7329:EE_|MW6PR10MB7638:EE_ X-MS-Office365-Filtering-Correlation-Id: 2567ccb2-b388-408a-9c94-08ddd3358fac X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014|7053199007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?l0CooW5pc2/fGozC0LOSa08P2RBk3+mvc19baPzEVo0qRurCl90veyU9Ohye?= =?us-ascii?Q?j4fqOZ6YP+0bPX3TrNcVZCW2it+scnNDSlFLKSRKEm0p6KOTNcoYZYXbnuFw?= =?us-ascii?Q?lPh2F/lpspa3A0yNAV/BfO8O5E+f7LfjIVje/NDNs6ps4eYvfbEliByetlO8?= =?us-ascii?Q?cYV6ZdNxn2JTjrmBLpyKG8Ip/kFOWmh6Ej5gHDR+/B5Agit+KhnHAsuSXWF2?= =?us-ascii?Q?eCQ8+JleB3KbuCRQj6OKW5XM/C9g4qMAlyYMCgwn57hrdORXzx3mNI/akkyj?= =?us-ascii?Q?LQ1jCBy8oUyEowj3/rGSZCK2qOaP3kfvyUH/QEgb5/cQAha3DzrsCL4JnKiU?= =?us-ascii?Q?EDNOIuBGM4X7U/Q7KoVdAQ1taYhTJk+M9OJmAjntOHfvXS67w+q4aPKJ64NW?= =?us-ascii?Q?ugxXM/MbNFsAWk6PEaoKA1u1LWjX5BfyFuY6HGsd7JOCnhxYzb9mvCpHHGbg?= =?us-ascii?Q?JUEl6p5EBC6f75aq9FsBliUrSHEXPsuv40h5ad2hanPzEbFmlfl+v/Ziy1HI?= =?us-ascii?Q?Z5pvB19z+AU4rodOI+4M9Vl7c6psHslaD1TKY9CrnrqEr7onvBpauc4OpwNn?= =?us-ascii?Q?4Qd/OYCB1jhTwNUW2CNSSpgGUvgdzoO5OIIekUbL3NmJ/aoFG8DC0fqAkXrG?= =?us-ascii?Q?UdAjlfxVbvdryo21OTmXpVwN9yt/yhGftKnhezqFi79lSpJDYw86tBRiqSUm?= =?us-ascii?Q?JA4mOLjr9WnnHoavwVDIosH3moScMAEPgMwWqqMp7WKJC8hf+7QV48F9L/zK?= =?us-ascii?Q?4kgdBQqLaz+D7dDjoQqXllkrXMftpH1nqQ5TFh4IhsGPeSKJMYsbHUaoq3jA?= =?us-ascii?Q?2BP6mytGoYVekuNPdDcStdZ3iePDwtaJVhHgxoSLuenpzoMDQ5brMHD4CPIt?= =?us-ascii?Q?qOaXOFRVCxKY7BDDdAgf6v9KeH9mu//130bGTyoXaPoBQwGI3CZcJakXbB6n?= =?us-ascii?Q?8C9BpJY/FlPy+WivQ389SlBPKr5B1tdLyEioiyVYPnME2l3ANQJV53cU/D0e?= =?us-ascii?Q?Cmo82KqydkW1MCMRmpYxgmMqCCXSO//ZtzWDWSdMq2LlEDuUA+h0QRDNRQAQ?= =?us-ascii?Q?OelOE01IAWOOZiqv5QHjf3HuvGKBqlIU3ldxbeXarQgEeHEDukuwwg+32Mmt?= =?us-ascii?Q?RUSXo5N02u5Oduo8/GxRBvd6TSUXE1y21boE6XRlAN8fhn1natv1Rr9orgm+?= =?us-ascii?Q?0lO841Tge7fMoteqYNto6kNGE6XY3fdyCyzjdoj372gm424jP29qafrn/e4e?= =?us-ascii?Q?x926UA7hM9lc45bYvZRAgsYgf6SzllzwyUG7mQ1f61+K064CQUmKPm5FwUxE?= =?us-ascii?Q?x7vmqr12M2PDNwiotYdm0HwiSZ1YOZOLq/o2uZ621S0P0cJsCXLRqWC8PfCa?= =?us-ascii?Q?GGvQVO8o+2Nf81GCQDxmwSLwmQduvQ+hTaUtQ8nl7z9bv0odEYcWAy9iWSOI?= =?us-ascii?Q?BkqFZL2RfBM=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH3PR10MB7329.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(376014)(7053199007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?lQ48BG+GA+jAu5HMDuverSyx4fIafeZfdvvbxNQSG1CbBNTkPgPr7E/NFGcj?= =?us-ascii?Q?W1kWTbbzXJY3wl2pCtXbZM+mR+7rTYVV/IhnSf3v/q4jXT76lovJ8L1BW8Te?= =?us-ascii?Q?zd9kgbVsS3pTV4N4NqoikY4zgzUg/K1gPGUvkgUxdeU3gKg2hE8mLPNa3lc7?= =?us-ascii?Q?uME+SYfC9Mj+TYOb1vPvfmwfODQePpF2GS6ZokSxgHJruwbRmniJeFYHiEo+?= =?us-ascii?Q?mf1Q2v9P4+W9idQHWJAOqABr7bHQIEBuxLJ4B+SwIZJtsi21ivBcsRDTFHMz?= =?us-ascii?Q?+EHLQZV8BU91kxrl9cD/8uS69myJTunz0FId9QAvwRUC7MJiEc3V6oOoSCNL?= =?us-ascii?Q?MHvz4V5FerTSC+GJPVup7fpE+HV4SmoXoLb24/OiQ60cMubWLqJveWV9w+4t?= =?us-ascii?Q?XLk8FYkUPlv95AZuBO2UfwJlkFpLGn/BoN/hixzegTX/amZwmsR+UPLas+Bj?= =?us-ascii?Q?9h9EN4pf2Io2UA4QGjpeevh2jiYrwKHS6w05krv+m1AhWLwDzpVq8uIwx4Kt?= =?us-ascii?Q?DKhEFqzkC8tSLKk0i8j3wd5G7OOHs4qXb9fDrqoLqA7v8+eNG/uPc299EdfX?= =?us-ascii?Q?sea1SsEkij+amhZGx0Pd9j9LPhFsR/BAlaRy7A8KQUIJGGzU0WG+AbgS4QP2?= =?us-ascii?Q?FSH1gA45jC5kRf5LFY3avLn2DtpS2GVVTMMLployz73GxDhED1v5RcqVK1df?= =?us-ascii?Q?VCF3zX0UIPSun+7tynhSAUpTGq/bUYvsHReDV2HTfMW90u2CsRf2WTNhrLIc?= =?us-ascii?Q?q6MdWnxf8bOk+rBUbT5rl0AWKSN4u7xLqC4rjwW/STdbAmsmOCv0enptGkEH?= =?us-ascii?Q?OVU5KPntpda9Kqs4TcdRvwWux5pSRseNCVhNIDirfxxGup+xKnrjHEWRsQ7v?= =?us-ascii?Q?RtJMZTU9dSvUIO/lIg6hS53prktp/gZ3nD/6EKzqTavGAd0eoRYcvzBpzHAb?= =?us-ascii?Q?G6L8hZGAy7PJGzSwoz8Ihm+34embE6vPs2NWAuirAyErp6OwA92eeU/ubFna?= =?us-ascii?Q?SiE1OpB23ejNnmowQNcLiN5KpqdXweHe65fA39S9ztGqP7JbS5X4N3PO6uAe?= =?us-ascii?Q?kHVLY6kpxlOZUH8+P09p7VAeFuE0FMemPVdkWSsX9iXtpqSvRl3/YSWPtyup?= =?us-ascii?Q?P2ySYpi8kBACOSVpMHyTzhbF5sUnRl4sJPKIOqgRh8CoPzs/hJv8TFlrfC5Q?= =?us-ascii?Q?3nfswx6uVaeNdA517yyrztUju0+LQPOXgK5lM9kJtls47BE81VPZ1evlEicv?= =?us-ascii?Q?e9I3NtMLNgBxAwlDAq+ZBbx/ba66RNhRzHoom2MHCLkTDc/YJ1gc3cDGJjmd?= =?us-ascii?Q?QGbMfvzHcFq+7K8gukn7inI7Sna8OIf741Zpmfp0K/nhrVTr5bunPIjz00xT?= =?us-ascii?Q?2oBlWXrQKdxCJlakfPq5UY2CRaZk1D1lkU2JrJDVsl9huqmgeGJZvTa/FeI/?= =?us-ascii?Q?x/fqK1uz2o/90D6eLB2zrHNBF85UaMnQ0hz1RihbsXcW758MlCO9GSfms0TA?= =?us-ascii?Q?3jcRlVIIH56wZYSrLtzAZUFxx9Mdcyp9USZcOHZCstDDFGxebt9QsfyH4APT?= =?us-ascii?Q?Gsow9e/kKNJZQ0fLHolbsTiwOx7RU+3PYXk9zlxE?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: PRtSfAzLDRQeg7o7lo7OEFKOw9VN5FKuuk9AykCuoo/hYznxq4SGsrJrewzynWvaL86ZVlsBNXjU/DyF4sjdMulWG6dbDcQ7NZq5Cj757JZYA8f1MosT1eyXnW9i38rlolH1Q3xI9VIWdc6WxvsvkOSfz/xDt9kGZ2tIap2CvBTXxEclyTr9yU20909ReoR04oDpRCknOJvFpXIHmj5Ntj1B+4FJrWmIHnp/XtQkYQPTwEhzB9sCZ+DrP6sgdHPIKjL1FAHlh8CCTBFLAiE8J39lIpFuqLmcpWbyzqSfQdHMUNKfnpL+2Y8gIXqWDR8Jfc55lkaqL/JQO/jigDR/Y4hn9gkUBNJd/UWgJixeU4NR0pwxa+Gdjol7Q0ItDi8jJNBK3Igd/16zzTax7qVB7qsD5PaiCa/vc9yN/0Gwx3RjgphwgXmRWx73PB3KbMPFzsHdCtB5KnyzdOvMZMgxZRoJTGzzAo2JzjCREbEoEVh01iSkXqO0GA1OP5Av4AW57+oTYVUN9HyGISQeqwZ0jztqp9F/LZWBPy17xgj46p5u3hWaXwWKCeY9/BWYLYfx7NtEuzFse8WSWWBQ9aBcqwTaEf4Vhy2hZG+l5oQfwsk= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2567ccb2-b388-408a-9c94-08ddd3358fac X-MS-Exchange-CrossTenant-AuthSource: CH3PR10MB7329.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Aug 2025 09:01:55.6074 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: h/QwdpV/xEtpEeaYjiQuX+7z52DaKH1Dkuc7PgCyjhnbv2/cOMdzodEdhkcCEaC43Is2KqHpdqetGRoZMYcNmw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW6PR10MB7638 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-08-04_03,2025-08-04_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 mlxscore=0 suspectscore=0 adultscore=0 malwarescore=0 mlxlogscore=999 bulkscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2505160000 definitions=main-2508040048 X-Proofpoint-GUID: 0Xce52vPcakWu0Cz5DGd9QUI9W9T46mC X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwODA0MDA0OCBTYWx0ZWRfX4U3xxAVbQ8WY ReVY1mKiPSX5Ghkj18hkS9ckCK8wuWAsH+r6jPw9onGs5mxcx4QGQhnLESsSZYUIB/HRCzSEZGI x3FmPYYUiWpUkehBGVzSK8a1h+h1oazcSSambiS4z1m39oRTXE6srEbtOZuFkemxovevO8qdZFk HyiB6u+SiYEbOMX2j1Y9zkHsLbHjRcIU2ULR+WHCoImIB8YG8+SV5g3i0jfxHoyofKvQXetx5LC i3yuvNLr3qV4epDkMmrUU99BzYDXEkXA1e5LUZIlaX6hUB1+uQ36KviwmkeFyFlNj79kaaXqPrL sG4gPLGEF7Q+Ij69tI73TzLe2JnyHQUmWLMLv9qw2040LtWbRymO41xKXKd7RyaYomIeq2AMULA YT3UhvEk3XH+RSR6CzrQVvCnSEKCXFTmd4fmIE3rZBS/7kDSw3f9XfAspIi3yE5p3JvLjNPg X-Proofpoint-ORIG-GUID: 0Xce52vPcakWu0Cz5DGd9QUI9W9T46mC X-Authority-Analysis: v=2.4 cv=FIobx/os c=1 sm=1 tr=0 ts=68907707 b=1 cx=c_pps a=e1sVV491RgrpLwSTMOnk8w==:117 a=e1sVV491RgrpLwSTMOnk8w==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=wKuvFiaSGQ0qltdbU6+NXLB8nM8=:19 a=Ol13hO9ccFRV9qXi2t6ftBPywas=:19 a=xqWC_Br6kY4A:10 a=kj9zAlcOel0A:10 a=2OwXVqhp2XgA:10 a=GoEa3M9JfhUA:10 a=VwQbUJbxAAAA:8 a=SlVAvriTAAAA:8 a=yPCof4ZbAAAA:8 a=95r7aR4FhjnzYnCyAq4A:9 a=CjuIK1q_8ugA:10 a=qesGs21RGGeVIEdTuB6w:22 cc=ntf awl=host:13596 On Mon, Aug 04, 2025 at 10:57:59AM +0800, Li Qiong wrote: > object_err() reports details of an object for further debugging, such as > the freelist pointer, redzone, etc. However, if the pointer is invalid, > attempting to access object metadata can lead to a crash since it does > not point to a valid object. > > In case the pointer is NULL or check_valid_pointer() returns false for > the pointer, only print the pointer value and skip accessing metadata. > > Fixes: 81819f0fc828 ("SLUB core") > Cc: > Signed-off-by: Li Qiong > --- > v2: > - rephrase the commit message, add comment for object_err(). > v3: > - check object pointer in object_err(). > v4: > - restore changes in alloc_consistency_checks(). > v5: > - rephrase message, fix code style. > v6: > - add checking 'object' if NULL. > --- Reviewed-by: Harry Yoo > mm/slub.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/mm/slub.c b/mm/slub.c > index 31e11ef256f9..972cf2bb2ee6 100644 > --- a/mm/slub.c > +++ b/mm/slub.c > @@ -1104,7 +1104,12 @@ static void object_err(struct kmem_cache *s, struct slab *slab, > return; > > slab_bug(s, reason); > - print_trailer(s, slab, object); > + if (!object || !check_valid_pointer(s, slab, object)) { > + print_slab_info(slab); > + pr_err("Invalid pointer 0x%p\n", object); > + } else { > + print_trailer(s, slab, object); > + } > add_taint(TAINT_BAD_PAGE, LOCKDEP_NOW_UNRELIABLE); > > WARN_ON(1); > -- > 2.30.2 > -- Cheers, Harry / Hyeonggon