public inbox for stable@vger.kernel.org
 help / color / mirror / Atom feed
From: Sasha Levin <sashal@kernel.org>
To: "Markus Blöchl" <markus@blochl.de>
Cc: stable@vger.kernel.org
Subject: Re: [PATCH] ice/ptp: fix crosstimestamp reporting
Date: Thu, 7 Aug 2025 09:54:39 -0400	[thread overview]
Message-ID: <aJSwHwQWAAseN871@lappy> (raw)
In-Reply-To: <ngpaxbcoagu6uiusrnqds7i62qv3c3nk6ppqv4eovrltnnlvqs@opvhzljlgpib>

On Thu, Aug 07, 2025 at 02:34:10PM +0200, Markus Blöchl wrote:
>Hi Sasha,
>
>Sorry, I don't really know how to handle this response from your bot:
>
>On Fri, Jul 25, 2025 at 09:37:11PM -0400, Sasha Levin wrote:
>> [ Sasha's backport helper bot ]
>>
>> Hi,
>>
>> Summary of potential issues:
>> ❌ Patch application failures detected
>> ⚠️ Found matching upstream commit but patch is missing proper reference to it
>
>The patch clearly mentions `commit a5a441ae283d upstream.` to me.
>Am I too blind to spot a typo or similar?

It should be the fully 40 char sha1, not a shortened version.

>>
>> Found matching upstream commit: a5a441ae283d54ec329aadc7426991dc32786d52
>>
>> WARNING: Author mismatch between patch and found commit:
>> Backport author: Markus Blöchl <markus@blochl.de>
>> Commit author: Anton Nadezhdin <anton.nadezhdin@intel.com>
>
>This mismatch is intentional.
>I did not author the original fix. I merely backported it to 6.12.y.
>So I kept the original author when cherry-picking.

That ok, it's mostly just a warning for us to see if we need to get
additional acks or do a more careful review.

>>
>> Note: Could not generate a diff with upstream commit:
>> ---
>> Note: Could not generate diff - patch failed to apply for comparison
>> ---
>>
>> Results of testing on various branches:
>>
>> | Branch                    | Patch Apply | Build Test |
>> |---------------------------|-------------|------------|
>> | origin/linux-6.15.y       | Failed      | N/A        |
>> | origin/linux-6.12.y       | Success     | Success    |
>> | origin/linux-6.6.y        | Failed      | N/A        |
>> | origin/linux-6.1.y        | Failed      | N/A        |
>> | origin/linux-5.15.y       | Failed      | N/A        |
>> | origin/linux-5.10.y       | Failed      | N/A        |
>> | origin/linux-5.4.y        | Failed      | N/A        |
>
>As written, the backport is for 6.12.y only.

Normally you'd indicate which trees you want the patch to be applied to
in the subject line. In this case it would be something like:

	[PATCH 6.12] ice/ptp: fix crosstimestamp reporting

-- 
Thanks,
Sasha

  reply	other threads:[~2025-08-07 13:54 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-25 20:33 [PATCH] ice/ptp: fix crosstimestamp reporting Markus Blöchl
2025-07-26  1:37 ` Sasha Levin
2025-08-07 12:34   ` Markus Blöchl
2025-08-07 13:54     ` Sasha Levin [this message]
2025-08-24  7:52 ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aJSwHwQWAAseN871@lappy \
    --to=sashal@kernel.org \
    --cc=markus@blochl.de \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox