From: Giovanni Cabiddu <giovanni.cabiddu@intel.com>
To: Greg KH <greg@kroah.com>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
Sasha Levin <sashal@kernel.org>, <stable@vger.kernel.org>,
Eric Biggers <ebiggers@kernel.org>
Subject: Re: [PATCH 6.16.y 2/2] crypto: acomp - Fix CFI failure due to type punning
Date: Fri, 22 Aug 2025 11:49:29 +0100 [thread overview]
Message-ID: <aKhLOeaAfKUyUvZh@gcabiddu-mobl.ger.corp.intel.com> (raw)
In-Reply-To: <2025082239-ablaze-sneer-a79b@gregkh>
On Fri, Aug 22, 2025 at 09:54:46AM +0200, Greg KH wrote:
> On Fri, Aug 22, 2025 at 03:48:46PM +0800, Herbert Xu wrote:
> > On Fri, Aug 22, 2025 at 08:16:36AM +0100, Giovanni Cabiddu wrote:
> > >
> > > Wouldn't it be simpler to drop the below changes to crypto/zstd.c in
> > > this patch and avoid backporting commit f5ad93ffb541 ("crypto: zstd -
> > > convert to acomp") to stable?
> > >
> > > f5ad93ffb541 appears to be more of a feature than a fix, and there are
> > > related follow-up changes that aren't marked with a Fixes tag:
> > >
> > > 03ba056e63d3 ("crypto: zstd - fix duplicate check warning")
> > > 25f4e1d7193d ("crypto: zstd - replace zero-length array with flexible array member")
> > >
> > > Eric, Herbert, what's your take?
> >
> > Yes there is no reason to backport that patch at all.
>
> Both now dropped, thanks.
Thanks Greg.
I'm going to send a backport for the second patch, 962ddc5a7a4b
("crypto: acomp - Fix CFI failure due to type punning"), which includes
only the required logic for deflate.
Regards,
--
Giovanni
prev parent reply other threads:[~2025-08-22 10:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-21 12:54 FAILED: patch "[PATCH] crypto: acomp - Fix CFI failure due to type punning" failed to apply to 6.16-stable tree gregkh
2025-08-21 19:21 ` [PATCH 6.16.y 1/2] crypto: zstd - convert to acomp Sasha Levin
2025-08-21 19:21 ` [PATCH 6.16.y 2/2] crypto: acomp - Fix CFI failure due to type punning Sasha Levin
2025-08-22 7:16 ` Giovanni Cabiddu
2025-08-22 7:48 ` Herbert Xu
2025-08-22 7:54 ` Greg KH
2025-08-22 10:49 ` Giovanni Cabiddu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aKhLOeaAfKUyUvZh@gcabiddu-mobl.ger.corp.intel.com \
--to=giovanni.cabiddu@intel.com \
--cc=ebiggers@kernel.org \
--cc=greg@kroah.com \
--cc=herbert@gondor.apana.org.au \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).