Linux kernel -stable discussions
 help / color / mirror / Atom feed
From: Johan Hovold <johan@kernel.org>
To: Sudeep Holla <sudeep.holla@arm.com>
Cc: Cristian Marussi <cristian.marussi@arm.com>,
	arm-scmi@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, stable@vger.kernel.org,
	Jan Palus <jpalus@fastmail.com>
Subject: Re: [PATCH] firmware: arm_scmi: quirk: fix write to string constant
Date: Fri, 29 Aug 2025 16:29:48 +0200	[thread overview]
Message-ID: <aLG5XFHXKgcBida8@hovoldconsulting.com> (raw)
In-Reply-To: <20250829132152.28218-1-johan@kernel.org>

On Fri, Aug 29, 2025 at 03:21:52PM +0200, Johan Hovold wrote:
> The quirk version range is typically a string constant and must not be
> modified (e.g. as it may be stored in read-only memory):
> 
> 	Unable to handle kernel write to read-only memory at virtual
> 	address ffffc036d998a947
> 
> Fix the range parsing so that it operates on a copy of the version range
> string, and mark all the quirk strings as const to reduce the risk of
> introducing similar future issues.

With Jan's permission, let's add:

Reported-by: Jan Palus <jpalus@fastmail.com>

> Closes: https://bugzilla.kernel.org/show_bug.cgi?id=220437
> Fixes: 487c407d57d6 ("firmware: arm_scmi: Add common framework to handle firmware quirks")
> Cc: stable@vger.kernel.org	# 6.16
> Cc: Cristian Marussi <cristian.marussi@arm.com>
> Signed-off-by: Johan Hovold <johan@kernel.org>

Johan

  reply	other threads:[~2025-08-29 14:29 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-29 13:21 [PATCH] firmware: arm_scmi: quirk: fix write to string constant Johan Hovold
2025-08-29 14:29 ` Johan Hovold [this message]
2025-09-02  9:59   ` Johan Hovold
2025-09-02 10:16     ` Sudeep Holla
2025-09-02 10:27       ` Johan Hovold
2025-09-02 11:18         ` Sudeep Holla
2025-08-29 21:13 ` Cristian Marussi
2025-09-08 10:17 ` Sudeep Holla

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aLG5XFHXKgcBida8@hovoldconsulting.com \
    --to=johan@kernel.org \
    --cc=arm-scmi@vger.kernel.org \
    --cc=cristian.marussi@arm.com \
    --cc=jpalus@fastmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=sudeep.holla@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox