public inbox for stable@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH v1] arm64: dts: qcom: monaco-evk: Use correct sound card compatible to match SoC
@ 2025-09-10  4:45 Mohammad Rafi Shaik
  2025-09-10  4:47 ` kernel test robot
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Mohammad Rafi Shaik @ 2025-09-10  4:45 UTC (permalink / raw)
  To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley
  Cc: linux-arm-msm, devicetree, linux-kernel, stable, kernel,
	prasad.kumpatla, ajay.nandam

The Monaco-EVK board is based on Qualcomm's QCS8300 SoC. The DTS
previously reused the sound card compatible as "qcom,qcs8275-sndcard",
which is based on existing coverage. To maintain clarity and consistency,
the naming conventions for the compatible should reflect actual SoC
rather than the board. Therefore, update the sound card compatible as
"qcom,qcs8300-sndcard" to avoid potential confusion.

Signed-off-by: Mohammad Rafi Shaik <mohammad.rafi.shaik@oss.qualcomm.com>
---
This patch series depends on patch series:
https://lore.kernel.org/linux-sound/20250905142647.2566951-1-mohammad.rafi.shaik@oss.qualcomm.com/
---
 arch/arm64/boot/dts/qcom/monaco-evk.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/qcom/monaco-evk.dts b/arch/arm64/boot/dts/qcom/monaco-evk.dts
index f3c5d363921e..7187c1760ef5 100644
--- a/arch/arm64/boot/dts/qcom/monaco-evk.dts
+++ b/arch/arm64/boot/dts/qcom/monaco-evk.dts
@@ -38,7 +38,7 @@ max98357a: audio-codec-1 {
 	};
 
 	sound {
-		compatible = "qcom,qcs8275-sndcard";
+		compatible = "qcom,qcs8300-sndcard";
 		model = "MONACO-EVK";
 
 		pinctrl-0 = <&hs0_mi2s_active>, <&mi2s1_active>;
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH v1] arm64: dts: qcom: monaco-evk: Use correct sound card compatible to match SoC
  2025-09-10  4:45 [PATCH v1] arm64: dts: qcom: monaco-evk: Use correct sound card compatible to match SoC Mohammad Rafi Shaik
@ 2025-09-10  4:47 ` kernel test robot
  2025-09-10  7:24 ` Krzysztof Kozlowski
  2025-09-10  9:45 ` Krzysztof Kozlowski
  2 siblings, 0 replies; 4+ messages in thread
From: kernel test robot @ 2025-09-10  4:47 UTC (permalink / raw)
  To: Mohammad Rafi Shaik; +Cc: stable, oe-kbuild-all

Hi,

Thanks for your patch.

FYI: kernel test robot notices the stable kernel rule is not satisfied.

The check is based on https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html#option-1

Rule: add the tag "Cc: stable@vger.kernel.org" in the sign-off area to have the patch automatically included in the stable tree.
Subject: [PATCH v1] arm64: dts: qcom: monaco-evk: Use correct sound card compatible to match SoC
Link: https://lore.kernel.org/stable/20250910044512.1369640-1-mohammad.rafi.shaik%40oss.qualcomm.com

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki




^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v1] arm64: dts: qcom: monaco-evk: Use correct sound card compatible to match SoC
  2025-09-10  4:45 [PATCH v1] arm64: dts: qcom: monaco-evk: Use correct sound card compatible to match SoC Mohammad Rafi Shaik
  2025-09-10  4:47 ` kernel test robot
@ 2025-09-10  7:24 ` Krzysztof Kozlowski
  2025-09-10  9:45 ` Krzysztof Kozlowski
  2 siblings, 0 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2025-09-10  7:24 UTC (permalink / raw)
  To: Mohammad Rafi Shaik, Bjorn Andersson, Konrad Dybcio, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley
  Cc: linux-arm-msm, devicetree, linux-kernel, stable, kernel,
	prasad.kumpatla, ajay.nandam

On 10/09/2025 06:45, Mohammad Rafi Shaik wrote:
> The Monaco-EVK board is based on Qualcomm's QCS8300 SoC. The DTS
> previously reused the sound card compatible as "qcom,qcs8275-sndcard",

So who is going to use qcom,qcs8275-sndcard compatible? I don't see any
DTS using it.

> which is based on existing coverage. To maintain clarity and consistency,
> the naming conventions for the compatible should reflect actual SoC
> rather than the board. Therefore, update the sound card compatible as
> "qcom,qcs8300-sndcard" to avoid potential confusion.
> 
> Signed-off-by: Mohammad Rafi Shaik <mohammad.rafi.shaik@oss.qualcomm.com>

Best regards,
Krzysztof

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v1] arm64: dts: qcom: monaco-evk: Use correct sound card compatible to match SoC
  2025-09-10  4:45 [PATCH v1] arm64: dts: qcom: monaco-evk: Use correct sound card compatible to match SoC Mohammad Rafi Shaik
  2025-09-10  4:47 ` kernel test robot
  2025-09-10  7:24 ` Krzysztof Kozlowski
@ 2025-09-10  9:45 ` Krzysztof Kozlowski
  2 siblings, 0 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2025-09-10  9:45 UTC (permalink / raw)
  To: Mohammad Rafi Shaik, Bjorn Andersson, Konrad Dybcio, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley
  Cc: linux-arm-msm, devicetree, linux-kernel, stable, kernel,
	prasad.kumpatla, ajay.nandam

On 10/09/2025 06:45, Mohammad Rafi Shaik wrote:
> The Monaco-EVK board is based on Qualcomm's QCS8300 SoC. The DTS
> previously reused the sound card compatible as "qcom,qcs8275-sndcard",
> which is based on existing coverage. To maintain clarity and consistency,
> the naming conventions for the compatible should reflect actual SoC
> rather than the board. Therefore, update the sound card compatible as
> "qcom,qcs8300-sndcard" to avoid potential confusion.
> 
> Signed-off-by: Mohammad Rafi Shaik <mohammad.rafi.shaik@oss.qualcomm.com>
> ---
> This patch series depends on patch series:
> https://lore.kernel.org/linux-sound/20250905142647.2566951-1-mohammad.rafi.shaik@oss.qualcomm.com/
> ---
>  arch/arm64/boot/dts/qcom/monaco-evk.dts | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/monaco-evk.dts b/arch/arm64/boot/dts/qcom/monaco-evk.dts
> index f3c5d363921e..7187c1760ef5 100644
> --- a/arch/arm64/boot/dts/qcom/monaco-evk.dts
> +++ b/arch/arm64/boot/dts/qcom/monaco-evk.dts
> @@ -38,7 +38,7 @@ max98357a: audio-codec-1 {
>  	};
>  
>  	sound {
> -		compatible = "qcom,qcs8275-sndcard";
> +		compatible = "qcom,qcs8300-sndcard";

The other patch claims that changing binding would be ABI break, so
obviously here is actual impact on users.

Also, the other patch explains that it is the same hardware, so we are
back at previous discussions (sc8380xp, sa8775p etc): we do not rename
compatibles just because your prefer something else now.

That's a NAK.

Best regards,
Krzysztof

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2025-09-10  9:45 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-09-10  4:45 [PATCH v1] arm64: dts: qcom: monaco-evk: Use correct sound card compatible to match SoC Mohammad Rafi Shaik
2025-09-10  4:47 ` kernel test robot
2025-09-10  7:24 ` Krzysztof Kozlowski
2025-09-10  9:45 ` Krzysztof Kozlowski

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox