* [PATCH] media: mediatek: vcodec: Fix a reference leak in mtk_vcodec_fw_vpu_init()
@ 2025-09-15 12:09 Haoxiang Li
2025-09-15 15:35 ` Markus Elfring
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Haoxiang Li @ 2025-09-15 12:09 UTC (permalink / raw)
To: tiffany.lin, andrew-ct.chen, yunfei.dong, mchehab, matthias.bgg,
angelogioacchino.delregno, haoxiang_li2024, hverkuil, tzungbi,
jiasheng
Cc: linux-media, linux-kernel, linux-arm-kernel, linux-mediatek,
stable
vpu_get_plat_device() increases the reference count of the returned
platform device. However, when devm_kzalloc() fails, the reference
is not released, causing a reference leak.
Fix this by calling put_device() on fw_pdev->dev before returning
on the error path.
Fixes: e25a89f743b1 ("media: mtk-vcodec: potential dereference of null pointer")
Cc: stable@vger.kernel.org
Signed-off-by: Haoxiang Li <haoxiang_li2024@163.com>
---
.../media/platform/mediatek/vcodec/common/mtk_vcodec_fw_vpu.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/media/platform/mediatek/vcodec/common/mtk_vcodec_fw_vpu.c b/drivers/media/platform/mediatek/vcodec/common/mtk_vcodec_fw_vpu.c
index d7027d600208..1c94316f2d7d 100644
--- a/drivers/media/platform/mediatek/vcodec/common/mtk_vcodec_fw_vpu.c
+++ b/drivers/media/platform/mediatek/vcodec/common/mtk_vcodec_fw_vpu.c
@@ -117,8 +117,10 @@ struct mtk_vcodec_fw *mtk_vcodec_fw_vpu_init(void *priv, enum mtk_vcodec_fw_use
vpu_wdt_reg_handler(fw_pdev, mtk_vcodec_vpu_reset_enc_handler, priv, rst_id);
fw = devm_kzalloc(&plat_dev->dev, sizeof(*fw), GFP_KERNEL);
- if (!fw)
+ if (!fw) {
+ put_device(&fw_pdev->dev);
return ERR_PTR(-ENOMEM);
+ }
fw->type = VPU;
fw->ops = &mtk_vcodec_vpu_msg;
fw->pdev = fw_pdev;
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] media: mediatek: vcodec: Fix a reference leak in mtk_vcodec_fw_vpu_init()
2025-09-15 12:09 [PATCH] media: mediatek: vcodec: Fix a reference leak in mtk_vcodec_fw_vpu_init() Haoxiang Li
@ 2025-09-15 15:35 ` Markus Elfring
2025-09-16 3:44 ` Tzung-Bi Shih
2025-09-17 11:55 ` AngeloGioacchino Del Regno
2 siblings, 0 replies; 4+ messages in thread
From: Markus Elfring @ 2025-09-15 15:35 UTC (permalink / raw)
To: Haoxiang Li, linux-mediatek, linux-arm-kernel, linux-media
Cc: stable, LKML, Andrew-CT Chen, Angelo Gioacchino Del Regno,
Hans Verkuil, Jiasheng Jiang, Matthias Brugger,
Mauro Carvalho Chehab, Tiffany Lin, Tzung-Bi Shih, Yunfei Dong
…
> Fix this by calling put_device() on fw_pdev->dev before returning
> on the error path.
How do you think about to increase the application of scope-based resource management?
Regards,
Markus
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] media: mediatek: vcodec: Fix a reference leak in mtk_vcodec_fw_vpu_init()
2025-09-15 12:09 [PATCH] media: mediatek: vcodec: Fix a reference leak in mtk_vcodec_fw_vpu_init() Haoxiang Li
2025-09-15 15:35 ` Markus Elfring
@ 2025-09-16 3:44 ` Tzung-Bi Shih
2025-09-17 11:55 ` AngeloGioacchino Del Regno
2 siblings, 0 replies; 4+ messages in thread
From: Tzung-Bi Shih @ 2025-09-16 3:44 UTC (permalink / raw)
To: Haoxiang Li
Cc: tiffany.lin, andrew-ct.chen, yunfei.dong, mchehab, matthias.bgg,
angelogioacchino.delregno, hverkuil, jiasheng, linux-media,
linux-kernel, linux-arm-kernel, linux-mediatek, stable
On Mon, Sep 15, 2025 at 08:09:38PM +0800, Haoxiang Li wrote:
> vpu_get_plat_device() increases the reference count of the returned
> platform device. However, when devm_kzalloc() fails, the reference
> is not released, causing a reference leak.
>
> Fix this by calling put_device() on fw_pdev->dev before returning
> on the error path.
>
> Fixes: e25a89f743b1 ("media: mtk-vcodec: potential dereference of null pointer")
> Cc: stable@vger.kernel.org
> Signed-off-by: Haoxiang Li <haoxiang_li2024@163.com>
The reference, taking via of_find_device_by_node(), needs to be dropped after
use. mtk_vcodec_vpu_release() does but the error handling path doesn't.
Reviewed-by: Tzung-Bi Shih <tzungbi@kernel.org>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] media: mediatek: vcodec: Fix a reference leak in mtk_vcodec_fw_vpu_init()
2025-09-15 12:09 [PATCH] media: mediatek: vcodec: Fix a reference leak in mtk_vcodec_fw_vpu_init() Haoxiang Li
2025-09-15 15:35 ` Markus Elfring
2025-09-16 3:44 ` Tzung-Bi Shih
@ 2025-09-17 11:55 ` AngeloGioacchino Del Regno
2 siblings, 0 replies; 4+ messages in thread
From: AngeloGioacchino Del Regno @ 2025-09-17 11:55 UTC (permalink / raw)
To: Haoxiang Li, tiffany.lin, andrew-ct.chen, yunfei.dong, mchehab,
matthias.bgg, hverkuil, tzungbi, jiasheng
Cc: linux-media, linux-kernel, linux-arm-kernel, linux-mediatek,
stable
Il 15/09/25 14:09, Haoxiang Li ha scritto:
> vpu_get_plat_device() increases the reference count of the returned
> platform device. However, when devm_kzalloc() fails, the reference
> is not released, causing a reference leak.
>
> Fix this by calling put_device() on fw_pdev->dev before returning
> on the error path.
>
> Fixes: e25a89f743b1 ("media: mtk-vcodec: potential dereference of null pointer")
> Cc: stable@vger.kernel.org
> Signed-off-by: Haoxiang Li <haoxiang_li2024@163.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-09-17 11:55 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-09-15 12:09 [PATCH] media: mediatek: vcodec: Fix a reference leak in mtk_vcodec_fw_vpu_init() Haoxiang Li
2025-09-15 15:35 ` Markus Elfring
2025-09-16 3:44 ` Tzung-Bi Shih
2025-09-17 11:55 ` AngeloGioacchino Del Regno
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox