[PATCH v2 0/5] mm, swap: misc cleanup and bugfix

[PATCH v2 0/5] mm, swap: misc cleanup and bugfix

[Kairui Song]

A few cleanups and a bugfix that are either suitable after the swap
table phase I or found during code review.

Patch 1 is a bugfix and needs to be included in the stable branch,
the rest have no behavior change.

---
Changes in v2:
- Update commit message for patch 1, it's a sub-optimal fix and a better
  fix can be done later. [ Chris Li ]
- Fix a lock balance issue in patch 1. [ YoungJun Park ]
- Add a trivial cleanup patch to remove an unused argument,
  no behavior change.
- Update kernel doc.
- Fix minor issue with commit message [ Nhat Pham ]
- Link to v1: https://lore.kernel.org/r/20251007-swap-clean-after-swap-table-p1-v1-0-74860ef8ba74@tencent.com

---
Kairui Song (5):
      mm, swap: do not perform synchronous discard during allocation
      mm, swap: rename helper for setup bad slots
      mm, swap: cleanup swap entry allocation parameter
      mm/migrate, swap: drop usage of folio_index
      mm, swap: remove redundant argument for isolating a cluster

 include/linux/swap.h |  4 +--
 mm/migrate.c         |  4 +--
 mm/shmem.c           |  2 +-
 mm/swap.h            | 21 ----------------
 mm/swapfile.c        | 71 +++++++++++++++++++++++++++++++++++-----------------
 mm/vmscan.c          |  4 +--
 6 files changed, 55 insertions(+), 51 deletions(-)
---
base-commit: 5b5c3e53c939318f6a0698c895c7ec40758bff6a
change-id: 20251007-swap-clean-after-swap-table-p1-b9a7635ee3fa

Best regards,
-- 
Kairui Song <kasong@tencent.com>

Re: [PATCH v2 0/5] mm, swap: misc cleanup and bugfix

[Lorenzo Stoakes]

On Fri, Oct 24, 2025 at 02:00:38AM +0800, Kairui Song wrote:
> A few cleanups and a bugfix that are either suitable after the swap
> table phase I or found during code review.
>
> Patch 1 is a bugfix and needs to be included in the stable branch,
> the rest have no behavior change.
>
> ---
> Changes in v2:
> - Update commit message for patch 1, it's a sub-optimal fix and a better
>   fix can be done later. [ Chris Li ]
> - Fix a lock balance issue in patch 1. [ YoungJun Park ]
> - Add a trivial cleanup patch to remove an unused argument,
>   no behavior change.
> - Update kernel doc.
> - Fix minor issue with commit message [ Nhat Pham ]
> - Link to v1: https://lore.kernel.org/r/20251007-swap-clean-after-swap-table-p1-v1-0-74860ef8ba74@tencent.com
>
> ---
> Kairui Song (5):
>       mm, swap: do not perform synchronous discard during allocation

FYI For some reason this commit is not present on lore, see [0]

[0]: https://lore.kernel.org/all/20251024-swap-clean-after-swap-table-p1-v2-0-a709469052e7@tencent.com/

>       mm, swap: rename helper for setup bad slots
>       mm, swap: cleanup swap entry allocation parameter
>       mm/migrate, swap: drop usage of folio_index
>       mm, swap: remove redundant argument for isolating a cluster
>
>  include/linux/swap.h |  4 +--
>  mm/migrate.c         |  4 +--
>  mm/shmem.c           |  2 +-
>  mm/swap.h            | 21 ----------------
>  mm/swapfile.c        | 71 +++++++++++++++++++++++++++++++++++-----------------
>  mm/vmscan.c          |  4 +--
>  6 files changed, 55 insertions(+), 51 deletions(-)
> ---
> base-commit: 5b5c3e53c939318f6a0698c895c7ec40758bff6a
> change-id: 20251007-swap-clean-after-swap-table-p1-b9a7635ee3fa
>
> Best regards,
> --
> Kairui Song <kasong@tencent.com>
>

Re: [PATCH v2 0/5] mm, swap: misc cleanup and bugfix

[Kairui Song]

On Fri, Oct 24, 2025 at 9:18 PM Lorenzo Stoakes
<lorenzo.stoakes@oracle.com> wrote:
>
> On Fri, Oct 24, 2025 at 02:00:38AM +0800, Kairui Song wrote:
> > A few cleanups and a bugfix that are either suitable after the swap
> > table phase I or found during code review.
> >
> > Patch 1 is a bugfix and needs to be included in the stable branch,
> > the rest have no behavior change.
> >
> > ---
> > Changes in v2:
> > - Update commit message for patch 1, it's a sub-optimal fix and a better
> >   fix can be done later. [ Chris Li ]
> > - Fix a lock balance issue in patch 1. [ YoungJun Park ]
> > - Add a trivial cleanup patch to remove an unused argument,
> >   no behavior change.
> > - Update kernel doc.
> > - Fix minor issue with commit message [ Nhat Pham ]
> > - Link to v1: https://lore.kernel.org/r/20251007-swap-clean-after-swap-table-p1-v1-0-74860ef8ba74@tencent.com
> >
> > ---
> > Kairui Song (5):
> >       mm, swap: do not perform synchronous discard during allocation
>
> FYI For some reason this commit is not present on lore, see [0]
>
> [0]: https://lore.kernel.org/all/20251024-swap-clean-after-swap-table-p1-v2-0-a709469052e7@tencent.com/

Thanks for letting me know, strangely, it is here:
https://lkml.kernel.org/r/20251024-swap-clean-after-swap-table-p1-v2-1-c5b0e1092927@tencent.com

But the In-reply-to id is wrong. I'm using b4 and somehow patch 1 was
blocked by gmail's SMTP so I had to try to resend patch 1 again,
something went wrong with that part. I'll try to find out the problem
and avoid that from happening again.

I'm seeing that patch 1 is being merged into mm tree just fine, I
guess that should be OK.

If anyone is reading the threads, this url above should be helpful.

Re: [PATCH v2 0/5] mm, swap: misc cleanup and bugfix

[Baoquan He]

On 10/24/25 at 09:26pm, Kairui Song wrote:
> On Fri, Oct 24, 2025 at 9:18 PM Lorenzo Stoakes
> <lorenzo.stoakes@oracle.com> wrote:
> >
> > On Fri, Oct 24, 2025 at 02:00:38AM +0800, Kairui Song wrote:
> > > A few cleanups and a bugfix that are either suitable after the swap
> > > table phase I or found during code review.
> > >
> > > Patch 1 is a bugfix and needs to be included in the stable branch,
> > > the rest have no behavior change.
> > >
> > > ---
> > > Changes in v2:
> > > - Update commit message for patch 1, it's a sub-optimal fix and a better
> > >   fix can be done later. [ Chris Li ]
> > > - Fix a lock balance issue in patch 1. [ YoungJun Park ]
> > > - Add a trivial cleanup patch to remove an unused argument,
> > >   no behavior change.
> > > - Update kernel doc.
> > > - Fix minor issue with commit message [ Nhat Pham ]
> > > - Link to v1: https://lore.kernel.org/r/20251007-swap-clean-after-swap-table-p1-v1-0-74860ef8ba74@tencent.com
> > >
> > > ---
> > > Kairui Song (5):
> > >       mm, swap: do not perform synchronous discard during allocation
> >
> > FYI For some reason this commit is not present on lore, see [0]
> >
> > [0]: https://lore.kernel.org/all/20251024-swap-clean-after-swap-table-p1-v2-0-a709469052e7@tencent.com/
> 
> Thanks for letting me know, strangely, it is here:
> https://lkml.kernel.org/r/20251024-swap-clean-after-swap-table-p1-v2-1-c5b0e1092927@tencent.com

I don't receive the patch 1/5, thanks to the link.

> 
> But the In-reply-to id is wrong. I'm using b4 and somehow patch 1 was
> blocked by gmail's SMTP so I had to try to resend patch 1 again,
> something went wrong with that part. I'll try to find out the problem
> and avoid that from happening again.
> 
> I'm seeing that patch 1 is being merged into mm tree just fine, I
> guess that should be OK.
> 
> If anyone is reading the threads, this url above should be helpful.
>