* [PATCH] usb: typec: altmodes/displayport: Drop the device reference in dp_altmode_probe()
@ 2025-12-06 7:04 Haoxiang Li
2025-12-11 13:42 ` Heikki Krogerus
0 siblings, 1 reply; 2+ messages in thread
From: Haoxiang Li @ 2025-12-06 7:04 UTC (permalink / raw)
To: heikki.krogerus, gregkh, rdbabiera
Cc: linux-usb, linux-kernel, Haoxiang Li, stable
In error paths, call typec_altmode_put_plug() to drop the device reference
obtained by typec_altmode_get_plug().
Fixes: 71ba4fe56656 ("usb: typec: altmodes/displayport: add SOP' support")
Cc: stable@vger.kernel.org
Signed-off-by: Haoxiang Li <lihaoxiang@isrc.iscas.ac.cn>
---
drivers/usb/typec/altmodes/displayport.c | 10 +++++++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/drivers/usb/typec/altmodes/displayport.c b/drivers/usb/typec/altmodes/displayport.c
index 1dcb77faf85d..5d02c97e256e 100644
--- a/drivers/usb/typec/altmodes/displayport.c
+++ b/drivers/usb/typec/altmodes/displayport.c
@@ -764,12 +764,16 @@ int dp_altmode_probe(struct typec_altmode *alt)
if (!(DP_CAP_PIN_ASSIGN_DFP_D(port->vdo) &
DP_CAP_PIN_ASSIGN_UFP_D(alt->vdo)) &&
!(DP_CAP_PIN_ASSIGN_UFP_D(port->vdo) &
- DP_CAP_PIN_ASSIGN_DFP_D(alt->vdo)))
- return -ENODEV;
+ DP_CAP_PIN_ASSIGN_DFP_D(alt->vdo))) {
+ typec_altmode_put_plug(plug);
+ return -ENODEV;
+ }
dp = devm_kzalloc(&alt->dev, sizeof(*dp), GFP_KERNEL);
- if (!dp)
+ if (!dp) {
+ typec_altmode_put_plug(plug);
return -ENOMEM;
+ }
INIT_WORK(&dp->work, dp_altmode_work);
mutex_init(&dp->lock);
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] usb: typec: altmodes/displayport: Drop the device reference in dp_altmode_probe()
2025-12-06 7:04 [PATCH] usb: typec: altmodes/displayport: Drop the device reference in dp_altmode_probe() Haoxiang Li
@ 2025-12-11 13:42 ` Heikki Krogerus
0 siblings, 0 replies; 2+ messages in thread
From: Heikki Krogerus @ 2025-12-11 13:42 UTC (permalink / raw)
To: Haoxiang Li; +Cc: gregkh, rdbabiera, linux-usb, linux-kernel, stable
Sat, Dec 06, 2025 at 03:04:45PM +0800, Haoxiang Li kirjoitti:
> In error paths, call typec_altmode_put_plug() to drop the device reference
> obtained by typec_altmode_get_plug().
>
> Fixes: 71ba4fe56656 ("usb: typec: altmodes/displayport: add SOP' support")
> Cc: stable@vger.kernel.org
> Signed-off-by: Haoxiang Li <lihaoxiang@isrc.iscas.ac.cn>
Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> ---
> drivers/usb/typec/altmodes/displayport.c | 10 +++++++---
> 1 file changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/usb/typec/altmodes/displayport.c b/drivers/usb/typec/altmodes/displayport.c
> index 1dcb77faf85d..5d02c97e256e 100644
> --- a/drivers/usb/typec/altmodes/displayport.c
> +++ b/drivers/usb/typec/altmodes/displayport.c
> @@ -764,12 +764,16 @@ int dp_altmode_probe(struct typec_altmode *alt)
> if (!(DP_CAP_PIN_ASSIGN_DFP_D(port->vdo) &
> DP_CAP_PIN_ASSIGN_UFP_D(alt->vdo)) &&
> !(DP_CAP_PIN_ASSIGN_UFP_D(port->vdo) &
> - DP_CAP_PIN_ASSIGN_DFP_D(alt->vdo)))
> - return -ENODEV;
> + DP_CAP_PIN_ASSIGN_DFP_D(alt->vdo))) {
> + typec_altmode_put_plug(plug);
> + return -ENODEV;
> + }
>
> dp = devm_kzalloc(&alt->dev, sizeof(*dp), GFP_KERNEL);
> - if (!dp)
> + if (!dp) {
> + typec_altmode_put_plug(plug);
> return -ENOMEM;
> + }
>
> INIT_WORK(&dp->work, dp_altmode_work);
> mutex_init(&dp->lock);
> --
> 2.25.1
--
heikki
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-12-11 13:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-12-06 7:04 [PATCH] usb: typec: altmodes/displayport: Drop the device reference in dp_altmode_probe() Haoxiang Li
2025-12-11 13:42 ` Heikki Krogerus
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox