Re: [PATCH v2 4/6] Revert "PCI: qcom: Enable MSI interrupts together with Link up if 'Global IRQ' is supported"

[Niklas Cassel <cassel@kernel.org>]

On Mon, Dec 22, 2025 at 12:18:32PM +0530, Krishna Chaitanya Chundru wrote:
> > @@ -1982,8 +1981,7 @@ static int qcom_pcie_probe(struct platform_device *pdev)
> >   			goto err_host_deinit;
> >   		}
> > -		writel_relaxed(PARF_INT_ALL_LINK_UP | PARF_INT_MSI_DEV_0_7,
> > -			       pcie->parf + PARF_INT_ALL_MASK);
> MSI's needs to be enabled irrespective of this series as part of global IRQ
> otherwise
> MSI's will not be triggered in few platforms.
> 
> Mani, exclude this patch while applying.

From the commit message of the reverted patch:

  The MSI bits in PARF_INT_ALL_MASK register are enabled
  by default in the hardware, but commit 4581403f6792 ("PCI: qcom: Enumerate
  endpoints based on Link up event in 'global_irq' interrupt") disabled them
  and enabled only the Link up interrupt.


Thus, applying this patch should be safe, or at least bring back the
original behavior as it was before the Link Up IRQ patches got applied.

But if you prefer to enable the MSI bits explicitly, in order to not
rely on HW defaults, that should also be fine.


Kind regards,
Niklas