Re: [PATCH RESEND] Revert "gpio: swnode: don't use the swnode's name as the key for GPIO lookup"

[Charles Keepax <ckeepax@opensource.cirrus.com>]

On Tue, Jan 06, 2026 at 03:42:13PM +0100, Greg KH wrote:
> On Tue, Jan 06, 2026 at 11:18:38AM +0000, Charles Keepax wrote:
> > This reverts commit 25decf0469d4c91d90aa2e28d996aed276bfc622.
> 
> For 6.18?  There is no such commit in that branch :(
> 
> Shouldn't it be e5d527be7e6984882306b49c067f1fec18920735?
> 
> > 
> > This software node change doesn't actually fix any current issues
> > with the kernel, it is an improvement to the lookup process rather
> > than fixing a live bug. It also causes a couple of regressions with
> > shipping laptops, which relied on the label based lookup.
> > 
> > There is a fix for the regressions in mainline, the first 5 patches
> > of [1]. However, those patches are fairly substantial changes and
> > given the patch causing the regression doesn't actually fix a bug
> > it seems better to just revert it in stable.
> > 
> > CC: stable@vger.kernel.org # 6.18
> > Link: https://lore.kernel.org/linux-sound/20251120-reset-gpios-swnodes-v7-0-a100493a0f4b@linaro.org/ [1]
> > Closes: https://github.com/thesofproject/linux/issues/5599
> > Closes: https://github.com/thesofproject/linux/issues/5603
> > Acked-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> > Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>
> > ---
> > 
> > This fix for the software node lookups is also required on 6.18 stable,
> > see the discussion for 6.12/6.17 in [2] for why we are doing a revert
> > rather than backporting the other fixes. The "full" fixes are merged in
> > 6.19 so this should be the last kernel we need to push this revert onto.
> 
> Can you resend with the proper commit id in it?
> 

Apologies I will fix that up and do a v2.

Thanks,
Charles