From: Boqun Feng <boqun.feng@gmail.com>
To: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
Cc: "Alexandre Courbot" <acourbot@nvidia.com>,
"Danilo Krummrich" <dakr@kernel.org>,
"Alice Ryhl" <aliceryhl@google.com>,
"Daniel Almeida" <daniel.almeida@collabora.com>,
"Miguel Ojeda" <ojeda@kernel.org>, "Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <lossin@kernel.org>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Trevor Gross" <tmgross@umich.edu>,
"Rafael J. Wysocki" <rafael@kernel.org>,
"Viresh Kumar" <viresh.kumar@linaro.org>,
"Will Deacon" <will@kernel.org>,
"Peter Zijlstra" <peterz@infradead.org>,
"Mark Rutland" <mark.rutland@arm.com>,
rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-pm@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH v3 5/7] rust: sync: refcount: always inline functions using build_assert with arguments
Date: Thu, 15 Jan 2026 16:40:35 +0800 [thread overview]
Message-ID: <aWinBMASjagM8gNQ@tardis-2.local> (raw)
In-Reply-To: <CANiq72=U93ceCxLH_HYesCvCywpCsou98kM2Z53x=cx=iVXm0Q@mail.gmail.com>
On Thu, Jan 15, 2026 at 08:49:05AM +0100, Miguel Ojeda wrote:
> On Mon, Dec 8, 2025 at 3:47 AM Alexandre Courbot <acourbot@nvidia.com> wrote:
> >
> > `build_assert` relies on the compiler to optimize out its error path.
> > Functions using it with its arguments must thus always be inlined,
> > otherwise the error path of `build_assert` might not be optimized out,
> > triggering a build error.
> >
> > Cc: stable@vger.kernel.org
> > Fixes: bb38f35b35f9 ("rust: implement `kernel::sync::Refcount`")
> > Reviewed-by: Daniel Almeida <daniel.almeida@collabora.com>
> > Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>
>
> Boqun et al.: do you want to pick this one or should I take it with
> your Acked-by?
>
Acked-by: Boqun Feng <boqun.feng@gmail.com>
Going via rust-next seems more appropriate to me, thanks!
Regards,
Boqun
> Thanks!
>
> Cheers,
> Miguel
next prev parent reply other threads:[~2026-01-15 8:40 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-08 2:46 [PATCH v3 0/7] rust: build_assert: document and fix use with function arguments Alexandre Courbot
2025-12-08 2:47 ` [PATCH v3 2/7] rust: io: always inline functions using build_assert with arguments Alexandre Courbot
2026-01-14 19:26 ` Timur Tabi
2025-12-08 2:47 ` [PATCH v3 3/7] rust: cpufreq: " Alexandre Courbot
2025-12-08 13:55 ` Gary Guo
2025-12-09 0:52 ` Alexandre Courbot
2025-12-09 12:02 ` Gary Guo
2025-12-09 1:01 ` Miguel Ojeda
2025-12-15 5:06 ` Viresh Kumar
2025-12-15 11:14 ` Gary Guo
2025-12-16 6:48 ` Viresh Kumar
2025-12-08 2:47 ` [PATCH v3 4/7] rust: bits: " Alexandre Courbot
2025-12-08 2:47 ` [PATCH v3 5/7] rust: sync: refcount: " Alexandre Courbot
2026-01-15 7:49 ` Miguel Ojeda
2026-01-15 8:40 ` Boqun Feng [this message]
2025-12-08 2:47 ` [PATCH v3 6/7] rust: irq: " Alexandre Courbot
2025-12-08 13:49 ` [PATCH v3 0/7] rust: build_assert: document and fix use with function arguments Gary Guo
2025-12-09 0:54 ` Alexandre Courbot
2026-01-14 19:37 ` Danilo Krummrich
2026-01-18 19:45 ` Miguel Ojeda
2026-01-19 8:19 ` Miguel Ojeda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aWinBMASjagM8gNQ@tardis-2.local \
--to=boqun.feng@gmail.com \
--cc=a.hindborg@kernel.org \
--cc=acourbot@nvidia.com \
--cc=aliceryhl@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=dakr@kernel.org \
--cc=daniel.almeida@collabora.com \
--cc=gary@garyguo.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=mark.rutland@arm.com \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=ojeda@kernel.org \
--cc=peterz@infradead.org \
--cc=rafael@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=tmgross@umich.edu \
--cc=viresh.kumar@linaro.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox