* [PATCH] clk: tegra: tegra124-emc: Fix potential memory leak in tegra124_clk_register_emc()
@ 2026-01-15 5:05 Haoxiang Li
2026-01-15 15:50 ` Markus Elfring
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Haoxiang Li @ 2026-01-15 5:05 UTC (permalink / raw)
To: pdeschrijver, pgaikwad, mturquette, sboyd, thierry.reding,
jonathanh, mperttunen, tomeu
Cc: linux-clk, linux-tegra, linux-kernel, Haoxiang Li, stable
If clk_register() fails, call kfree to release "tegra".
Fixes: 2db04f16b589 ("clk: tegra: Add EMC clock driver")
Cc: stable@vger.kernel.org
Signed-off-by: Haoxiang Li <lihaoxiang@isrc.iscas.ac.cn>
---
drivers/clk/tegra/clk-tegra124-emc.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/clk/tegra/clk-tegra124-emc.c b/drivers/clk/tegra/clk-tegra124-emc.c
index 2a6db0434281..0f6fb776b229 100644
--- a/drivers/clk/tegra/clk-tegra124-emc.c
+++ b/drivers/clk/tegra/clk-tegra124-emc.c
@@ -538,8 +538,10 @@ struct clk *tegra124_clk_register_emc(void __iomem *base, struct device_node *np
tegra->hw.init = &init;
clk = clk_register(NULL, &tegra->hw);
- if (IS_ERR(clk))
+ if (IS_ERR(clk)) {
+ kfree(tegra);
return clk;
+ }
tegra->prev_parent = clk_hw_get_parent_by_index(
&tegra->hw, emc_get_parent(&tegra->hw))->clk;
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] clk: tegra: tegra124-emc: Fix potential memory leak in tegra124_clk_register_emc()
2026-01-15 5:05 [PATCH] clk: tegra: tegra124-emc: Fix potential memory leak in tegra124_clk_register_emc() Haoxiang Li
@ 2026-01-15 15:50 ` Markus Elfring
2026-01-16 1:22 ` Brian Masney
2026-01-16 18:38 ` Thierry Reding
2 siblings, 0 replies; 4+ messages in thread
From: Markus Elfring @ 2026-01-15 15:50 UTC (permalink / raw)
To: Haoxiang Li, linux-clk, linux-tegra, Michael Turquette,
Mikko Perttunen, Jonathan Hunter, Peter De Schrijver,
Prashant Gaikwad, Stephen Boyd, Thierry Reding, Tomeu Vizoso
Cc: stable, LKML
> If clk_register() fails, call kfree to release "tegra".
()?
How do you think about to avoid a bit of duplicate source code here?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?h=v6.19-rc5#n526
Regards,
Markus
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] clk: tegra: tegra124-emc: Fix potential memory leak in tegra124_clk_register_emc()
2026-01-15 5:05 [PATCH] clk: tegra: tegra124-emc: Fix potential memory leak in tegra124_clk_register_emc() Haoxiang Li
2026-01-15 15:50 ` Markus Elfring
@ 2026-01-16 1:22 ` Brian Masney
2026-01-16 18:38 ` Thierry Reding
2 siblings, 0 replies; 4+ messages in thread
From: Brian Masney @ 2026-01-16 1:22 UTC (permalink / raw)
To: Haoxiang Li
Cc: pdeschrijver, pgaikwad, mturquette, sboyd, thierry.reding,
jonathanh, mperttunen, tomeu, linux-clk, linux-tegra,
linux-kernel, stable
On Thu, Jan 15, 2026 at 01:05:42PM +0800, Haoxiang Li wrote:
> If clk_register() fails, call kfree to release "tegra".
>
> Fixes: 2db04f16b589 ("clk: tegra: Add EMC clock driver")
> Cc: stable@vger.kernel.org
> Signed-off-by: Haoxiang Li <lihaoxiang@isrc.iscas.ac.cn>
Reviewed-by: Brian Masney <bmasney@redhat.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] clk: tegra: tegra124-emc: Fix potential memory leak in tegra124_clk_register_emc()
2026-01-15 5:05 [PATCH] clk: tegra: tegra124-emc: Fix potential memory leak in tegra124_clk_register_emc() Haoxiang Li
2026-01-15 15:50 ` Markus Elfring
2026-01-16 1:22 ` Brian Masney
@ 2026-01-16 18:38 ` Thierry Reding
2 siblings, 0 replies; 4+ messages in thread
From: Thierry Reding @ 2026-01-16 18:38 UTC (permalink / raw)
To: pdeschrijver, pgaikwad, mturquette, sboyd, thierry.reding,
jonathanh, mperttunen, tomeu, Haoxiang Li
Cc: linux-clk, linux-tegra, linux-kernel, stable
From: Thierry Reding <treding@nvidia.com>
On Thu, 15 Jan 2026 13:05:42 +0800, Haoxiang Li wrote:
> If clk_register() fails, call kfree to release "tegra".
>
>
Applied, thanks!
[1/1] clk: tegra: tegra124-emc: Fix potential memory leak in tegra124_clk_register_emc()
commit: fce0d0bd9c20fefd180ea9e8362d619182f97a1d
Best regards,
--
Thierry Reding <treding@nvidia.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-01-16 18:39 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-01-15 5:05 [PATCH] clk: tegra: tegra124-emc: Fix potential memory leak in tegra124_clk_register_emc() Haoxiang Li
2026-01-15 15:50 ` Markus Elfring
2026-01-16 1:22 ` Brian Masney
2026-01-16 18:38 ` Thierry Reding
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox