From: Brian Masney <bmasney@redhat.com>
To: Haoxiang Li <lihaoxiang@isrc.iscas.ac.cn>
Cc: mturquette@baylibre.com, sboyd@kernel.org,
linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH 1/7] clk: st: clkgen-pll: Fix a memory leak in clkgen_odf_register()
Date: Fri, 16 Jan 2026 10:29:23 -0500 [thread overview]
Message-ID: <aWpZUz46SQLGf8WX@redhat.com> (raw)
In-Reply-To: <20260116113847.1827694-2-lihaoxiang@isrc.iscas.ac.cn>
On Fri, Jan 16, 2026 at 07:38:41PM +0800, Haoxiang Li wrote:
> If clk_register_composite() fails, call kfree() to release
> div and gate.
>
> Fixes: b9b8e614b580 ("clk: st: Support for PLLs inside ClockGenA(s)")
> Cc: stable@vger.kernel.org
> Signed-off-by: Haoxiang Li <lihaoxiang@isrc.iscas.ac.cn>
Reviewed-by: Brian Masney <bmasney@redhat.com>
Note for next time: I sent out a Reviewed-by tag on this patch on the
previous version. Please include those tags on the future versions.
The only time it's appropriate to not include the tag is if you make
changes to the patch beyond a trivial change.
Also you may want to consider using b4 for your workflow since it really
simplifies your workflow. There's some documentation available at:
https://b4.docs.kernel.org/en/latest/
Basically, here's a quick workflow of what I do:
# Start with a clean branch (say today's linux-next)
# Create a new b4-managed branch
b4 prep -n my-branch-name
# Apply your patches
b4 prep --edit-cover
b4 prep --auto-to-cc
b4 prep --check
b4 send --dry-run
# Send out your patch series for real
b4 send
Later if you need to send out a new version, just use the same b4
managed branch. It'll track the patch version number for you (the
PATCH v2 in the subject).
You can use 'b4 trailers'
(https://b4.docs.kernel.org/en/latest/contributor/trailers.html) to pick
up tags from the list.
There's also a b4 web submission endpoint you can use instead of sending
it through a SMTP server:
https://b4.docs.kernel.org/en/latest/contributor/send.html
Brian
next prev parent reply other threads:[~2026-01-16 15:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20260116113847.1827694-1-lihaoxiang@isrc.iscas.ac.cn>
2026-01-16 11:38 ` [PATCH 1/7] clk: st: clkgen-pll: Fix a memory leak in clkgen_odf_register() Haoxiang Li
2026-01-16 15:29 ` Brian Masney [this message]
2026-01-17 10:15 ` Markus Elfring
2026-01-16 11:38 ` [PATCH 4/7] clk: st: clkgen-pll: Add iounmap() in clkgen_c32_pll_setup() Haoxiang Li
2026-01-16 15:40 ` Brian Masney
2026-01-17 12:57 ` Markus Elfring
2026-01-16 11:38 ` [PATCH 5/7] clk: st: clkgen-pll: Add clk_unregister for pll_clk " Haoxiang Li
2026-01-16 15:43 ` Brian Masney
2026-01-16 11:38 ` [PATCH 7/7] clk: st: clkgen-pll: Add clk_unregister for odf_clk " Haoxiang Li
2026-01-16 15:53 ` Brian Masney
2026-01-17 13:43 ` Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aWpZUz46SQLGf8WX@redhat.com \
--to=bmasney@redhat.com \
--cc=lihaoxiang@isrc.iscas.ac.cn \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox