* [PATCH net-next] net: stmmac: Correct spelling from clk_scr_i to clk_csr_i
@ 2026-02-01 2:36 Huacai Chen
2026-02-01 4:43 ` Yao Zi
` (2 more replies)
0 siblings, 3 replies; 8+ messages in thread
From: Huacai Chen @ 2026-02-01 2:36 UTC (permalink / raw)
To: Huacai Chen, Andrew Lunn, David S . Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni
Cc: Yanteng Si, Alexandre Torgue, Jose Abreu, Serge Semin, loongarch,
netdev, linux-kernel, Huacai Chen, stable
In include/linux/stmmac.h clk_csr_i is spelled as clk_scr_i by mistake,
so correct it.
Cc: stable@vger.kernel.org
Signed-off-by: Huacai Chen <chenhuacai@loongson.cn>
---
include/linux/stmmac.h | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/include/linux/stmmac.h b/include/linux/stmmac.h
index f1054b9c2d8a..1ba583ef6e03 100644
--- a/include/linux/stmmac.h
+++ b/include/linux/stmmac.h
@@ -28,14 +28,14 @@
* This could also be configured at run time using CPU freq framework. */
/* MDC Clock Selection define*/
-#define STMMAC_CSR_60_100M 0x0 /* MDC = clk_scr_i/42 */
-#define STMMAC_CSR_100_150M 0x1 /* MDC = clk_scr_i/62 */
-#define STMMAC_CSR_20_35M 0x2 /* MDC = clk_scr_i/16 */
-#define STMMAC_CSR_35_60M 0x3 /* MDC = clk_scr_i/26 */
-#define STMMAC_CSR_150_250M 0x4 /* MDC = clk_scr_i/102 */
-#define STMMAC_CSR_250_300M 0x5 /* MDC = clk_scr_i/124 */
-#define STMMAC_CSR_300_500M 0x6 /* MDC = clk_scr_i/204 */
-#define STMMAC_CSR_500_800M 0x7 /* MDC = clk_scr_i/324 */
+#define STMMAC_CSR_60_100M 0x0 /* MDC = clk_csr_i/42 */
+#define STMMAC_CSR_100_150M 0x1 /* MDC = clk_csr_i/62 */
+#define STMMAC_CSR_20_35M 0x2 /* MDC = clk_csr_i/16 */
+#define STMMAC_CSR_35_60M 0x3 /* MDC = clk_csr_i/26 */
+#define STMMAC_CSR_150_250M 0x4 /* MDC = clk_csr_i/102 */
+#define STMMAC_CSR_250_300M 0x5 /* MDC = clk_csr_i/124 */
+#define STMMAC_CSR_300_500M 0x6 /* MDC = clk_csr_i/204 */
+#define STMMAC_CSR_500_800M 0x7 /* MDC = clk_csr_i/324 */
/* MTL algorithms identifiers */
#define MTL_TX_ALGORITHM_WRR 0x0
--
2.47.3
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH net-next] net: stmmac: Correct spelling from clk_scr_i to clk_csr_i
2026-02-01 2:36 [PATCH net-next] net: stmmac: Correct spelling from clk_scr_i to clk_csr_i Huacai Chen
@ 2026-02-01 4:43 ` Yao Zi
2026-02-01 7:19 ` Huacai Chen
2026-02-02 1:36 ` Yanteng Si
2026-02-03 0:07 ` Jakub Kicinski
2 siblings, 1 reply; 8+ messages in thread
From: Yao Zi @ 2026-02-01 4:43 UTC (permalink / raw)
To: Huacai Chen, Huacai Chen, Andrew Lunn, David S . Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni
Cc: Yanteng Si, Alexandre Torgue, Jose Abreu, Serge Semin, loongarch,
netdev, linux-kernel, stable
On Sun, Feb 01, 2026 at 10:36:19AM +0800, Huacai Chen wrote:
> In include/linux/stmmac.h clk_csr_i is spelled as clk_scr_i by mistake,
> so correct it.
>
> Cc: stable@vger.kernel.org
> Signed-off-by: Huacai Chen <chenhuacai@loongson.cn>
> ---
> include/linux/stmmac.h | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/include/linux/stmmac.h b/include/linux/stmmac.h
> index f1054b9c2d8a..1ba583ef6e03 100644
> --- a/include/linux/stmmac.h
> +++ b/include/linux/stmmac.h
> @@ -28,14 +28,14 @@
> * This could also be configured at run time using CPU freq framework. */
>
> /* MDC Clock Selection define*/
> -#define STMMAC_CSR_60_100M 0x0 /* MDC = clk_scr_i/42 */
> -#define STMMAC_CSR_100_150M 0x1 /* MDC = clk_scr_i/62 */
> -#define STMMAC_CSR_20_35M 0x2 /* MDC = clk_scr_i/16 */
> -#define STMMAC_CSR_35_60M 0x3 /* MDC = clk_scr_i/26 */
> -#define STMMAC_CSR_150_250M 0x4 /* MDC = clk_scr_i/102 */
> -#define STMMAC_CSR_250_300M 0x5 /* MDC = clk_scr_i/124 */
> -#define STMMAC_CSR_300_500M 0x6 /* MDC = clk_scr_i/204 */
> -#define STMMAC_CSR_500_800M 0x7 /* MDC = clk_scr_i/324 */
> +#define STMMAC_CSR_60_100M 0x0 /* MDC = clk_csr_i/42 */
> +#define STMMAC_CSR_100_150M 0x1 /* MDC = clk_csr_i/62 */
> +#define STMMAC_CSR_20_35M 0x2 /* MDC = clk_csr_i/16 */
> +#define STMMAC_CSR_35_60M 0x3 /* MDC = clk_csr_i/26 */
> +#define STMMAC_CSR_150_250M 0x4 /* MDC = clk_csr_i/102 */
> +#define STMMAC_CSR_250_300M 0x5 /* MDC = clk_csr_i/124 */
> +#define STMMAC_CSR_300_500M 0x6 /* MDC = clk_csr_i/204 */
> +#define STMMAC_CSR_500_800M 0x7 /* MDC = clk_csr_i/324 */
This seems only a fix to typo in comments, instead of real functionality
bugs, should this be backported?
> It must either fix a real bug that bothers people or just add a device
> ID. To elaborate on the former:
> ...
> - No “trivial” fixes without benefit for users (spelling changes,
> whitespace cleanups, etc).[1]
> /* MTL algorithms identifiers */
> #define MTL_TX_ALGORITHM_WRR 0x0
> --
> 2.47.3
>
>
Regards,
Yao Zi
[1]: https://docs.kernel.org/6.15/process/stable-kernel-rules.html
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH net-next] net: stmmac: Correct spelling from clk_scr_i to clk_csr_i
2026-02-01 4:43 ` Yao Zi
@ 2026-02-01 7:19 ` Huacai Chen
0 siblings, 0 replies; 8+ messages in thread
From: Huacai Chen @ 2026-02-01 7:19 UTC (permalink / raw)
To: Yao Zi
Cc: Huacai Chen, Andrew Lunn, David S . Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, Yanteng Si, Alexandre Torgue,
Jose Abreu, Serge Semin, loongarch, netdev, linux-kernel, stable
On Sun, Feb 1, 2026 at 12:44 PM Yao Zi <me@ziyao.cc> wrote:
>
> On Sun, Feb 01, 2026 at 10:36:19AM +0800, Huacai Chen wrote:
> > In include/linux/stmmac.h clk_csr_i is spelled as clk_scr_i by mistake,
> > so correct it.
> >
> > Cc: stable@vger.kernel.org
> > Signed-off-by: Huacai Chen <chenhuacai@loongson.cn>
> > ---
> > include/linux/stmmac.h | 16 ++++++++--------
> > 1 file changed, 8 insertions(+), 8 deletions(-)
> >
> > diff --git a/include/linux/stmmac.h b/include/linux/stmmac.h
> > index f1054b9c2d8a..1ba583ef6e03 100644
> > --- a/include/linux/stmmac.h
> > +++ b/include/linux/stmmac.h
> > @@ -28,14 +28,14 @@
> > * This could also be configured at run time using CPU freq framework. */
> >
> > /* MDC Clock Selection define*/
> > -#define STMMAC_CSR_60_100M 0x0 /* MDC = clk_scr_i/42 */
> > -#define STMMAC_CSR_100_150M 0x1 /* MDC = clk_scr_i/62 */
> > -#define STMMAC_CSR_20_35M 0x2 /* MDC = clk_scr_i/16 */
> > -#define STMMAC_CSR_35_60M 0x3 /* MDC = clk_scr_i/26 */
> > -#define STMMAC_CSR_150_250M 0x4 /* MDC = clk_scr_i/102 */
> > -#define STMMAC_CSR_250_300M 0x5 /* MDC = clk_scr_i/124 */
> > -#define STMMAC_CSR_300_500M 0x6 /* MDC = clk_scr_i/204 */
> > -#define STMMAC_CSR_500_800M 0x7 /* MDC = clk_scr_i/324 */
> > +#define STMMAC_CSR_60_100M 0x0 /* MDC = clk_csr_i/42 */
> > +#define STMMAC_CSR_100_150M 0x1 /* MDC = clk_csr_i/62 */
> > +#define STMMAC_CSR_20_35M 0x2 /* MDC = clk_csr_i/16 */
> > +#define STMMAC_CSR_35_60M 0x3 /* MDC = clk_csr_i/26 */
> > +#define STMMAC_CSR_150_250M 0x4 /* MDC = clk_csr_i/102 */
> > +#define STMMAC_CSR_250_300M 0x5 /* MDC = clk_csr_i/124 */
> > +#define STMMAC_CSR_300_500M 0x6 /* MDC = clk_csr_i/204 */
> > +#define STMMAC_CSR_500_800M 0x7 /* MDC = clk_csr_i/324 */
>
> This seems only a fix to typo in comments, instead of real functionality
> bugs, should this be backported?
I think it is worthy, but the maintainer is free to remove "Cc stable".
Huacai
>
> > It must either fix a real bug that bothers people or just add a device
> > ID. To elaborate on the former:
> > ...
> > - No “trivial” fixes without benefit for users (spelling changes,
> > whitespace cleanups, etc).[1]
>
> > /* MTL algorithms identifiers */
> > #define MTL_TX_ALGORITHM_WRR 0x0
> > --
> > 2.47.3
> >
> >
>
> Regards,
> Yao Zi
>
> [1]: https://docs.kernel.org/6.15/process/stable-kernel-rules.html
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH net-next] net: stmmac: Correct spelling from clk_scr_i to clk_csr_i
2026-02-01 2:36 [PATCH net-next] net: stmmac: Correct spelling from clk_scr_i to clk_csr_i Huacai Chen
2026-02-01 4:43 ` Yao Zi
@ 2026-02-02 1:36 ` Yanteng Si
2026-02-02 7:29 ` Huacai Chen
2026-02-03 0:07 ` Jakub Kicinski
2 siblings, 1 reply; 8+ messages in thread
From: Yanteng Si @ 2026-02-02 1:36 UTC (permalink / raw)
To: Huacai Chen, Huacai Chen, Andrew Lunn, David S . Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni
Cc: Alexandre Torgue, Jose Abreu, Serge Semin, loongarch, netdev,
linux-kernel, stable
在 2026/2/1 10:36, Huacai Chen 写道:
> In include/linux/stmmac.h clk_csr_i is spelled as clk_scr_i by mistake,
> so correct it.
>
> Cc: stable@vger.kernel.org
> Signed-off-by: Huacai Chen <chenhuacai@loongson.cn>
fix tag?
But this is just a comment, no need to backport it (I'm fine either way).
If no fix tag, please update the subject to typo fix instead.
Thanks,
Yanteng
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH net-next] net: stmmac: Correct spelling from clk_scr_i to clk_csr_i
2026-02-02 1:36 ` Yanteng Si
@ 2026-02-02 7:29 ` Huacai Chen
2026-02-02 7:43 ` Yanteng Si
0 siblings, 1 reply; 8+ messages in thread
From: Huacai Chen @ 2026-02-02 7:29 UTC (permalink / raw)
To: Yanteng Si
Cc: Huacai Chen, Andrew Lunn, David S . Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, Alexandre Torgue, Jose Abreu,
Serge Semin, loongarch, netdev, linux-kernel, stable
On Mon, Feb 2, 2026 at 9:36 AM Yanteng Si <si.yanteng@linux.dev> wrote:
>
>
> 在 2026/2/1 10:36, Huacai Chen 写道:
> > In include/linux/stmmac.h clk_csr_i is spelled as clk_scr_i by mistake,
> > so correct it.
> >
> > Cc: stable@vger.kernel.org
> > Signed-off-by: Huacai Chen <chenhuacai@loongson.cn>
>
> fix tag?
>
> But this is just a comment, no need to backport it (I'm fine either way).
>
> If no fix tag, please update the subject to typo fix instead.
Why? Is the subject line wrong?
Huacai
>
>
> Thanks,
>
> Yanteng
>
>
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH net-next] net: stmmac: Correct spelling from clk_scr_i to clk_csr_i
2026-02-02 7:29 ` Huacai Chen
@ 2026-02-02 7:43 ` Yanteng Si
0 siblings, 0 replies; 8+ messages in thread
From: Yanteng Si @ 2026-02-02 7:43 UTC (permalink / raw)
To: Huacai Chen
Cc: Huacai Chen, Andrew Lunn, David S . Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, Alexandre Torgue, Jose Abreu,
Serge Semin, loongarch, netdev, linux-kernel, stable
在 2026/2/2 15:29, Huacai Chen 写道:
> On Mon, Feb 2, 2026 at 9:36 AM Yanteng Si <si.yanteng@linux.dev> wrote:
>>
>> 在 2026/2/1 10:36, Huacai Chen 写道:
>>> In include/linux/stmmac.h clk_csr_i is spelled as clk_scr_i by mistake,
>>> so correct it.
>>>
>>> Cc: stable@vger.kernel.org
>>> Signed-off-by: Huacai Chen <chenhuacai@loongson.cn>
>> fix tag?
>>
>> But this is just a comment, no need to backport it (I'm fine either way).
>>
>> If no fix tag, please update the subject to typo fix instead.
> Why? Is the subject line wrong?
You're absolutely right, and "typo" specifically refers to a typographical
error in written content—this patch is a correction to a comment, so using
"typo" is perfectly appropriate.
I might be misinterpreting the wording here – what I really want is to tell
exactly what a patch modifies from the subject alone, without having to
check the patch content. Maybe "correct comment" is a better fit. I know
I'm splitting hairs a bit, but I couldn't just stay silent after receiving your
patch, right?
Thanks,
Yanteng
>
> Huacai
>
>>
>> Thanks,
>>
>> Yanteng
>>
>>
>>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH net-next] net: stmmac: Correct spelling from clk_scr_i to clk_csr_i
2026-02-01 2:36 [PATCH net-next] net: stmmac: Correct spelling from clk_scr_i to clk_csr_i Huacai Chen
2026-02-01 4:43 ` Yao Zi
2026-02-02 1:36 ` Yanteng Si
@ 2026-02-03 0:07 ` Jakub Kicinski
2026-02-03 2:48 ` Huacai Chen
2 siblings, 1 reply; 8+ messages in thread
From: Jakub Kicinski @ 2026-02-03 0:07 UTC (permalink / raw)
To: Huacai Chen
Cc: Huacai Chen, Andrew Lunn, David S . Miller, Eric Dumazet,
Paolo Abeni, Yanteng Si, Alexandre Torgue, Jose Abreu,
Serge Semin, loongarch, netdev, linux-kernel, stable
On Sun, 1 Feb 2026 10:36:19 +0800 Huacai Chen wrote:
> In include/linux/stmmac.h clk_csr_i is spelled as clk_scr_i by mistake,
> so correct it.
>
> Cc: stable@vger.kernel.org
> Signed-off-by: Huacai Chen <chenhuacai@loongson.cn>
The CC stable is unnecessary, please repost without it.
--
pw-bot: cr
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH net-next] net: stmmac: Correct spelling from clk_scr_i to clk_csr_i
2026-02-03 0:07 ` Jakub Kicinski
@ 2026-02-03 2:48 ` Huacai Chen
0 siblings, 0 replies; 8+ messages in thread
From: Huacai Chen @ 2026-02-03 2:48 UTC (permalink / raw)
To: Jakub Kicinski
Cc: Huacai Chen, Andrew Lunn, David S . Miller, Eric Dumazet,
Paolo Abeni, Yanteng Si, Alexandre Torgue, Jose Abreu,
Serge Semin, loongarch, netdev, linux-kernel, stable
On Tue, Feb 3, 2026 at 8:07 AM Jakub Kicinski <kuba@kernel.org> wrote:
>
> On Sun, 1 Feb 2026 10:36:19 +0800 Huacai Chen wrote:
> > In include/linux/stmmac.h clk_csr_i is spelled as clk_scr_i by mistake,
> > so correct it.
> >
> > Cc: stable@vger.kernel.org
> > Signed-off-by: Huacai Chen <chenhuacai@loongson.cn>
>
> The CC stable is unnecessary, please repost without it.
OK, will do.
Huacai
> --
> pw-bot: cr
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2026-02-03 2:48 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-02-01 2:36 [PATCH net-next] net: stmmac: Correct spelling from clk_scr_i to clk_csr_i Huacai Chen
2026-02-01 4:43 ` Yao Zi
2026-02-01 7:19 ` Huacai Chen
2026-02-02 1:36 ` Yanteng Si
2026-02-02 7:29 ` Huacai Chen
2026-02-02 7:43 ` Yanteng Si
2026-02-03 0:07 ` Jakub Kicinski
2026-02-03 2:48 ` Huacai Chen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox