From: Michael Tretter <m.tretter@pengutronix.de>
To: Steve Longerbeam <slongerbeam@gmail.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
Hans Verkuil <hans.verkuil@cisco.com>,
linux-media@vger.kernel.org, imx@lists.linux.dev,
linux-arm-kernel@lists.infradead.org, stable@vger.kernel.org,
Michael Tretter <michael.tretter@pengutronix.de>,
Frank Li <Frank.Li@nxp.com>
Subject: Re: [PATCH v2 0/2] media: staging: imx: fix multiple video input
Date: Fri, 23 Jan 2026 17:58:57 +0100 [thread overview]
Message-ID: <aXOo0cc07cRi7-rF@pengutronix.de> (raw)
In-Reply-To: <aUPEs4wUHgAyMrPX@pengutronix.de>
On Thu, 18 Dec 2025 10:09:07 +0100, Michael Tretter wrote:
> On Fri, 07 Nov 2025 11:34:32 +0100, Michael Tretter wrote:
> > If the IMX media pipeline is configured to receive multiple video
> > inputs, the second input stream may be broken on start. This happens if
> > the IMX CSI hardware has to be reconfigured for the second stream, while
> > the first stream is already running.
> >
> > The IMX CSI driver configures the IMX CSI in the link_validate callback.
> > The media pipeline is only validated on the first start. Thus, any later
> > start of the media pipeline skips the validation and directly starts
> > streaming. This may leave the hardware in an inconsistent state compared
> > to the driver configuration. Moving the hardware configuration to the
> > stream start to make sure that the hardware is configured correctly.
> >
> > Patch 1 removes the caching of the upstream mbus_config in
> > csi_link_validate and explicitly request the mbus_config in csi_start,
> > to get rid of this implicit dependency.
> >
> > Patch 2 actually moves the hardware register setting from
> > csi_link_validate to csi_start to fix the skipped hardware
> > reconfiguration.
>
> Gentle ping.
Is there anything still missing to get these patches applied?
Michael
> >
> > Signed-off-by: Michael Tretter <michael.tretter@pengutronix.de>
> > ---
> > Changes in v2:
> > - Document changed locking in commit message
> > - Link to v1: https://lore.kernel.org/r/20251105-media-imx-fixes-v1-0-99e48b4f5cbc@pengutronix.de
> >
> > ---
> > Michael Tretter (2):
> > media: staging: imx: request mbus_config in csi_start
> > media: staging: imx: configure src_mux in csi_start
> >
> > drivers/staging/media/imx/imx-media-csi.c | 84 ++++++++++++++++++-------------
> > 1 file changed, 48 insertions(+), 36 deletions(-)
> > ---
> > base-commit: 27afd6e066cfd80ddbe22a4a11b99174ac89cced
> > change-id: 20251105-media-imx-fixes-acef77c7ba12
next prev parent reply other threads:[~2026-01-23 16:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-07 10:34 [PATCH v2 0/2] media: staging: imx: fix multiple video input Michael Tretter
2025-11-07 10:34 ` [PATCH v2 1/2] media: staging: imx: request mbus_config in csi_start Michael Tretter
2025-11-07 10:36 ` Philipp Zabel
2025-11-07 10:34 ` [PATCH v2 2/2] media: staging: imx: configure src_mux " Michael Tretter
2025-11-07 10:36 ` Philipp Zabel
2025-11-07 16:01 ` Frank Li
2025-12-18 9:09 ` [PATCH v2 0/2] media: staging: imx: fix multiple video input Michael Tretter
2026-01-23 16:58 ` Michael Tretter [this message]
2026-01-23 19:34 ` Frank Li
2026-03-18 12:01 ` Michael Tretter
2026-03-18 12:36 ` Laurent Pinchart
2026-03-18 13:35 ` Frank Li
2026-03-27 14:42 ` Frank Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aXOo0cc07cRi7-rF@pengutronix.de \
--to=m.tretter@pengutronix.de \
--cc=Frank.Li@nxp.com \
--cc=festevam@gmail.com \
--cc=hans.verkuil@cisco.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=michael.tretter@pengutronix.de \
--cc=p.zabel@pengutronix.de \
--cc=slongerbeam@gmail.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox