From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com [136.143.188.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 94B3443ABC; Thu, 12 Feb 2026 14:58:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=136.143.188.112 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770908303; cv=pass; b=gNcgksE0YVcHWTYnJbFSGvnFQU3JBImzmkGNol6BS4NlUhwmUdvvettrr2xfKg1r6g9CcAJXjcdCPLngQWM6hByKyV2u+GCrCgfoUD3Hh202TasnPlgrpzjRyn2UmiRANtcVbB6AmK0hDbIAstGNvyy71+0KxQnes8zVVQ0gA6Y= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770908303; c=relaxed/simple; bh=Uqg+1i9fzmYpJWilVjNVALXs0GMRJU++P8SXvGfrlbg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=k1yFbWIiwYBWCobJ5WdetQeCFq8G0K3Sq8BjEPTP26j2NAIMVAPGrW41gS0E951Au4v6aG+W74sTAWg3Q8auTNVijG/Nnssed2NEDX+lNrMP383inCpaxpc/HI+ED8xhx1gyzvPtzZM7NbXIvYgdsnU1+NJdJG355JQEZ92pZmg= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (1024-bit key) header.d=collabora.com header.i=sebastian.reichel@collabora.com header.b=Gvu6J4Wa; arc=pass smtp.client-ip=136.143.188.112 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=collabora.com header.i=sebastian.reichel@collabora.com header.b="Gvu6J4Wa" ARC-Seal: i=1; a=rsa-sha256; t=1770908288; cv=none; d=zohomail.com; s=zohoarc; b=bdBJfciw+SLKHwce3M1xZeBNSh9/dUONzlxiisNvSAhA9Y/azTwPYL7lBuRhhDNN0vpXmD0e0M9w9bnORC8xpArw1JQv4Vc6Ew8HeHpRufv67M7pKk1CLOzy20GP/uxD1oFbaZghR0miSsD3zzsizXeFPmJXUMuZFMAklECth/c= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1770908288; h=Content-Type:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=ewJ17yZssUQQjHgmzfTqhJeBawC3u74ghBag/166lsk=; b=EhP6TrIUfa4578JrGFn6RoN+JGO6Umocs7CWeEJjnfmRombZJWxvbZ5EobxFCaHuf7ivV7raxO3nIl+jnGSvBnvf6l9iU5G31FG+TBzMUzizyG72kmS5FtuaQ++llZzCQzVrs/O8DWMi/Sr05FaiXf9el+1W1eAlwizdHnzx1JI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=sebastian.reichel@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1770908288; s=zohomail; d=collabora.com; i=sebastian.reichel@collabora.com; h=Date:Date:From:From:To:To:Cc:Cc:Subject:Subject:Message-ID:References:MIME-Version:Content-Type:In-Reply-To:Message-Id:Reply-To; bh=ewJ17yZssUQQjHgmzfTqhJeBawC3u74ghBag/166lsk=; b=Gvu6J4Waf/OsLu1RLrAJg6LtJ0jCuzkBxwpJI6yXyprFKG6RAAaD0yvRfbvX10Wi /xV2ZO95dE5GMdDvIxAfdQbOzpYKDyFm0aH0JG3xNczQHAgaJ+mzqANxqKpCOd7+C5m Zf+7drziXG6/xtlkLgF4rrFvuv+JTHQ4av3DBjgU= Received: by mx.zohomail.com with SMTPS id 1770908287347603.7883798586333; Thu, 12 Feb 2026 06:58:07 -0800 (PST) Received: by venus (Postfix, from userid 1000) id 1869F18248B; Thu, 12 Feb 2026 15:58:03 +0100 (CET) Date: Thu, 12 Feb 2026 15:58:03 +0100 From: Sebastian Reichel To: Shawn Lin Cc: Ulf Hansson , Finley Xiao , Frank Zhang , linux-pm@vger.kernel.org, Detlev Casanova , Heiko Stuebner , linux-rockchip@lists.infradead.org, stable@vger.kernel.org Subject: Re: [PATCH] pmdomain: rockchip: Fix rkvdec0/1 and venc0/1 for RK3588 Message-ID: References: <1770891364-52147-1-git-send-email-shawn.lin@rock-chips.com> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="kclqcghfrdw46u3s" Content-Disposition: inline In-Reply-To: <1770891364-52147-1-git-send-email-shawn.lin@rock-chips.com> X-Zoho-Virus-Status: 1 X-Zoho-AV-Stamp: zmail-av-0.1.0.1.4.3/270.907.16 X-ZohoMailClient: External --kclqcghfrdw46u3s Content-Type: text/plain; protected-headers=v1; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [PATCH] pmdomain: rockchip: Fix rkvdec0/1 and venc0/1 for RK3588 MIME-Version: 1.0 Hi, On Thu, Feb 12, 2026 at 06:16:04PM +0800, Shawn Lin wrote: > From the RK3588 TRM Table 1-1 RK3588 Voltage Domain and Power Domain Summ= ary, That's Table 7-1 :) > PD_RKVDEC0/1 and PD_VENC0/1 rely on VD_VCODEC which require extra voltage= s to > be applied, otherwise it breaks RK3588-evb1-v10 board after vdec support = landed[1]. > The panic looks like below: >=20 > rockchip-pm-domain fd8d8000.power-management:power-controller: failed t= o set domain 'rkvdec0' on, val=3D0 > rockchip-pm-domain fd8d8000.power-management:power-controller: failed t= o set domain 'rkvdec1' on, val=3D0 > ... > Hardware name: Rockchip RK3588S EVB1 V10 Board (DT) > Workqueue: pm genpd_power_off_work_fn > Call trace: > show_stack+0x18/0x24 (C) > dump_stack_lvl+0x40/0x84 > dump_stack+0x18/0x24 > vpanic+0x1ec/0x4fc > vpanic+0x0/0x4fc > check_panic_on_warn+0x0/0x94 > arm64_serror_panic+0x6c/0x78 > do_serror+0xc4/0xcc > el1h_64_error_handler+0x3c/0x5c > el1h_64_error+0x6c/0x70 > regmap_mmio_read32le+0x18/0x24 (P) > _regmap_bus_reg_read+0xfc/0x130 > _regmap_read+0x188/0x1ac > regmap_read+0x54/0x78 > rockchip_pd_power+0xcc/0x5f0 > rockchip_pd_power_off+0x1c/0x4c > _genpd_power_off+0x84/0x120 > genpd_power_off+0x1b4/0x260 > genpd_power_off_work_fn+0x38/0x58 > process_scheduled_works+0x194/0x2c4 > worker_thread+0x2ac/0x3d8 > kthread+0x104/0x124 > ret_from_fork+0x10/0x20 > SMP: stopping secondary CPUs > Kernel Offset: disabled > CPU features: 0x3000000,000e0005,40230521,0400720b > Memory Limit: none > ---[ end Kernel panic - not syncing: Asynchronous SError Interrupt ]--- >=20 > [1] https://lore.kernel.org/linux-rockchip/20251020212009.8852-2-detlev.c= asanova@collabora.com/ > Fixes: db6df2e3fc16 ("pmdomain: rockchip: add regulator support") > Cc: stable@vger.kernel.org > Signed-off-by: Shawn Lin Reviewed-by: Sebastian Reichel Greetings, -- Sebastian > --- >=20 > drivers/pmdomain/rockchip/pm-domains.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) >=20 > diff --git a/drivers/pmdomain/rockchip/pm-domains.c b/drivers/pmdomain/ro= ckchip/pm-domains.c > index 997e93c..040aa5f 100644 > --- a/drivers/pmdomain/rockchip/pm-domains.c > +++ b/drivers/pmdomain/rockchip/pm-domains.c > @@ -1315,10 +1315,10 @@ static const struct rockchip_domain_info rk3588_p= m_domains[] =3D { > [RK3588_PD_NPUTOP] =3D DOMAIN_RK3588("nputop", 0x0, BIT(3), 0, = 0x0, BIT(11), BIT(2), 0x0, BIT(1), BIT(1), false, false), > [RK3588_PD_NPU1] =3D DOMAIN_RK3588("npu1", 0x0, BIT(4), 0, 0x= 0, BIT(12), BIT(3), 0x0, BIT(2), BIT(2), false, false), > [RK3588_PD_NPU2] =3D DOMAIN_RK3588("npu2", 0x0, BIT(5), 0, 0x= 0, BIT(13), BIT(4), 0x0, BIT(3), BIT(3), false, false), > - [RK3588_PD_VENC0] =3D DOMAIN_RK3588("venc0", 0x0, BIT(6), 0, 0= x0, BIT(14), BIT(5), 0x0, BIT(4), BIT(4), false, false), > - [RK3588_PD_VENC1] =3D DOMAIN_RK3588("venc1", 0x0, BIT(7), 0, 0= x0, BIT(15), BIT(6), 0x0, BIT(5), BIT(5), false, false), > - [RK3588_PD_RKVDEC0] =3D DOMAIN_RK3588("rkvdec0", 0x0, BIT(8), 0, = 0x0, BIT(16), BIT(7), 0x0, BIT(6), BIT(6), false, false), > - [RK3588_PD_RKVDEC1] =3D DOMAIN_RK3588("rkvdec1", 0x0, BIT(9), 0, = 0x0, BIT(17), BIT(8), 0x0, BIT(7), BIT(7), false, false), > + [RK3588_PD_VENC0] =3D DOMAIN_RK3588("venc0", 0x0, BIT(6), 0, 0= x0, BIT(14), BIT(5), 0x0, BIT(4), BIT(4), false, true), > + [RK3588_PD_VENC1] =3D DOMAIN_RK3588("venc1", 0x0, BIT(7), 0, 0= x0, BIT(15), BIT(6), 0x0, BIT(5), BIT(5), false, true), > + [RK3588_PD_RKVDEC0] =3D DOMAIN_RK3588("rkvdec0", 0x0, BIT(8), 0, = 0x0, BIT(16), BIT(7), 0x0, BIT(6), BIT(6), false, true), > + [RK3588_PD_RKVDEC1] =3D DOMAIN_RK3588("rkvdec1", 0x0, BIT(9), 0, = 0x0, BIT(17), BIT(8), 0x0, BIT(7), BIT(7), false, true), > [RK3588_PD_VDPU] =3D DOMAIN_RK3588("vdpu", 0x0, BIT(10), 0, 0x= 0, BIT(18), BIT(9), 0x0, BIT(8), BIT(8), false, false), > [RK3588_PD_RGA30] =3D DOMAIN_RK3588("rga30", 0x0, BIT(11), 0, 0= x0, BIT(19), BIT(10), 0x0, 0, 0, false, false), > [RK3588_PD_AV1] =3D DOMAIN_RK3588("av1", 0x0, BIT(12), 0, 0x= 0, BIT(20), BIT(11), 0x0, BIT(9), BIT(9), false, false), > --=20 > 2.7.4 >=20 --kclqcghfrdw46u3s Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEE72YNB0Y/i3JqeVQT2O7X88g7+poFAmmN6ncACgkQ2O7X88g7 +ppwDQ/+MgfaLtM2QMPFgYQWMUHMFC/mO4X+3ZKAKoQSPbnUptASff0G8voyFYfZ Ld74ACLB5gLXtv5sIbBHw/4N6WWUZOD+XwAYyHd9ceAU2jKoWycZHP2YcuFOQROS HND+GtGq5Yl4QFruqt2wpo7IW3bRMF0tufXeOz01o5ezyPuYFDPqWeEUQSuBXwVj YzPrz+hUgrTjun8EzWRz73NGtO1NsQkVGarg1o8gvczEK7qyyETZNonKSksZSpBc wHMDmuBowxqQcGPvd58gB/mGRH6WnDnZJV5Pi828STqG0kpGSkvT+XcdUcOZhWjR OdjQJ6YkA6V+a+e+wHCw6B7AsUagiBzojzgsGPq6/pCJ+AJ4oDQuizufPJ6nSLdn bX6/5aLfYH2Ys9sPKpKlOoNnc8xxdmmMZqSA7w7Js+XUNuZRCBN51TAkjy+0g7qx dUneQsnJsD0SVswpbXvdCn2+xrHJ6midhpBclOxWxSVzkVILO7M6OA6Uin9G6OLw faVkLh0SNqZ/lpI3tQ5UN5jTH7kfhp6s3LxpDVQ6CPGjKmmuGCwaZff32nx5JVh4 AsgIfwCZYbNtwm/BQx/Zb4AWN2Z5sssHxz8n0S5ZmV7UwhTNLYnrt+YyNFuKMF3l Y8DuMDmno5RWMlldvN3R8qp0AbUi9BDyNkD3y3LbUPVRzK3p754= =KpAz -----END PGP SIGNATURE----- --kclqcghfrdw46u3s--