From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0F90922339; Tue, 3 Feb 2026 11:53:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.9 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770119587; cv=none; b=pGjP+gLuTwdn8HXQbCqGCwd1/WBSjx0lN559jd/3hxtqMd45adFmT//2A6zZEI+v1Da72wfACHXUJUyXvIpilSiL4QHrCEkH0RQ3f8emHgX0G414iC/+CDkmPXl+PhpURZA+iJ9vO4m2t55/YQefLIFBVdQ57FgOPVPgaiMRq7Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770119587; c=relaxed/simple; bh=+Cv82bqvFKaJG3yiPoUug7CoIWqw/Hg7MAUS9jZ9UN4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=F2OQii1epqxUn2B8WH+EHsXUdogZUeuNYnDM4j124UuN2dOzICXkEYPJmejxye6hXqZEOyI4rKqoSGCb/2XrhHH8xmC3afNs8asjjHjt5zGOayJguANVGC1v9LbpKQ/2i6HRYy2MT5g+s2P2tTR7xmb7uO383/rPzzpqhA0qtt0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=SwJjMnHr; arc=none smtp.client-ip=198.175.65.9 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="SwJjMnHr" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1770119586; x=1801655586; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=+Cv82bqvFKaJG3yiPoUug7CoIWqw/Hg7MAUS9jZ9UN4=; b=SwJjMnHrhkp3iy97zWa1ohr29hGUozfJH2nZK2ncB1jq+FgwCUQZhENg M/xzStI5NK8WLuI5fItGBp1eF/Mjhm65K33n94wOFLI7128s/SogeEDb3 GGoX/QYvRklNyxudTRcy5lV0yf/LwUIxV6C1wNlKrOFU7NGoZ0vOm3u+b kmkquINkwkUvMwhImqoW6wHGRVQCNm//xIdqiRaw63FJDi9SGTSgrlvhI bTP8QLOOFisKfVV48Jzc4kfhhoUI44cL5eWC+DC5mdZ3IAryGBAekufmq Z9H2wtu6U8vDflSkmls4MMk0s8NCtf8PVKfMWksiKRWnNrqDkAx4VeEl3 g==; X-CSE-ConnectionGUID: jU08Vi8uRqi14QoOuVFkew== X-CSE-MsgGUID: PePXCSl3QiaINVU3E6RO1Q== X-IronPort-AV: E=McAfee;i="6800,10657,11690"; a="93940225" X-IronPort-AV: E=Sophos;i="6.21,270,1763452800"; d="scan'208";a="93940225" Received: from orviesa005.jf.intel.com ([10.64.159.145]) by orvoesa101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Feb 2026 03:53:05 -0800 X-CSE-ConnectionGUID: EE5CKyI8SHaMopnW+BfB1Q== X-CSE-MsgGUID: 9irpcCcFQCWik0iINrUH2Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,270,1763452800"; d="scan'208";a="214786053" Received: from pgcooper-mobl3.ger.corp.intel.com (HELO localhost) ([10.245.245.99]) by orviesa005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Feb 2026 03:53:02 -0800 Date: Tue, 3 Feb 2026 13:52:59 +0200 From: Andy Shevchenko To: Oleksij Rempel Cc: Andy Shevchenko , Rob Herring , Conor Dooley , devicetree@vger.kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Nuno =?iso-8859-1?Q?S=E1?= , kernel@pengutronix.de, David Jander , Krzysztof Kozlowski , David Lechner , Jonathan Cameron Subject: Re: [PATCH v4 01/13] iio: dac: ds4424: reject -128 RAW value Message-ID: References: <20260203093434.2548978-1-o.rempel@pengutronix.de> <20260203093434.2548978-2-o.rempel@pengutronix.de> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo On Tue, Feb 03, 2026 at 11:28:45AM +0100, Oleksij Rempel wrote: > On Tue, Feb 03, 2026 at 11:54:35AM +0200, Andy Shevchenko wrote: > > On Tue, Feb 03, 2026 at 10:34:21AM +0100, Oleksij Rempel wrote: ... > > > case IIO_CHAN_INFO_RAW: > > > - if (val < S8_MIN || val > S8_MAX) > > > + if (val <= S8_MIN || val > S8_MAX) > > > return -EINVAL; > > > > I still consider using -127, 127 is better than type _MIN/_MAX. > > This is all due to '='. > > The use of S8_MIN here is intentional to satisfy the requirement for a minimal > stable backport, as requested by Jonathan: > https://lore.kernel.org/all/20260201144226.218a43cb@jic23-huawei/ > > This patch: Strict "Fix only" for stable. Uses minimal logic changes (<= > S8_MIN) to avoid introducing new bugs during backporting. > > N++ patch: Full refactoring. > > Can we accept this temporary state to facilitate the stable process? Ah, if it's request by the maintainer, I can't and won't overrule it. -- With Best Regards, Andy Shevchenko