From: Nicolas Schier <nsc@kernel.org>
To: HeeSu Kim <mlksvender@gmail.com>
Cc: nathan@kernel.org, a.hindborg@kernel.org, aliceryhl@google.com,
bjorn3_gh@protonmail.com, boqun@google.com, charmitro@posteo.net,
dakr@kernel.org, gary@garyguo.net, linux-kbuild@vger.kernel.org,
linux-kernel@vger.kernel.org, lossin@kernel.org,
miguel.ojeda.sandonis@gmail.com, ojeda@kernel.org,
rust-for-linux@vger.kernel.org, stable@vger.kernel.org,
tmgross@umich.edu
Subject: Re: [PATCH v5 1/2] kbuild: add rustc-max-version macro
Date: Thu, 5 Feb 2026 16:55:25 +0100 [thread overview]
Message-ID: <aYS9bRugxr1rUvA3@levanger> (raw)
In-Reply-To: <20260205131815.2943152-1-mlksvender@gmail.com>
On Thu, Feb 05, 2026 at 10:18:14PM +0900, HeeSu Kim wrote:
> Add `rustc-max-version` macro to `scripts/Makefile.compiler` for
> version upper bound checks, mirroring the existing `rustc-min-version`.
>
> This will be used to bound workarounds to specific compiler version
> ranges.
>
> Suggested-by: Miguel Ojeda <ojeda@kernel.org>
> Link: https://lore.kernel.org/rust-for-linux/CANiq72n39eU9WE=Yh0_yJzmqMxo=QAaU2pN0UqP9jZ7bT7rhgA@mail.gmail.com/
> Acked-by: Nathan Chancellor <nathan@kernel.org>
> Signed-off-by: HeeSu Kim <mlksvender@gmail.com>
> ---
> Changes in v5:
> - Split rustc-max-version macro into separate patch for easier backporting
> (was part of the workaround patch in v4)
>
> scripts/Makefile.compiler | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/scripts/Makefile.compiler b/scripts/Makefile.compiler
> index ef91910de265..85268f6f1494 100644
> --- a/scripts/Makefile.compiler
> +++ b/scripts/Makefile.compiler
> @@ -71,6 +71,10 @@ clang-min-version = $(call test-ge, $(CONFIG_CLANG_VERSION), $1)
> # Usage: rustc-$(call rustc-min-version, 108500) += -Cfoo
> rustc-min-version = $(call test-ge, $(CONFIG_RUSTC_VERSION), $1)
>
> +# rustc-max-version
> +# Usage: rustc-$(call rustc-max-version, 109000) += -Cfoo
> +rustc-max-version = $(call test-le, $(CONFIG_RUSTC_VERSION), $1)
> +
Acked-by: Nicolas Schier <nsc@kernel.org>
(nit-picking; not crucial for this very patch set)
For readability, a less-than version check might be easier to read; and
that would probably better match the suggested version range check:
rustc-lt-version = $(if $(call rustc-min-version, $(1)),,y)
rustc-version-range = $(and $(call rustc-lt-version,$(2)), $(call rustc-min-version,$(1)))
so that the actual version check could become
# The bug was fixed in Rust 1.90.0, so only apply for 1.88.x to < 1.90.0
rustdoc_modifiers_workaround := $(if $(call rustc-version-range, 108800, 109000), \
-Cunsafe-allow-abi-mismatch=fixed-x18)
or:
ifeq ($(call rustc-version-range, 108800, 109000),y)
rustdoc_modifiers_workaround := -Cunsafe-allow-abi-mismatch=fixed-x18
endif
--
Nicolas
next prev parent reply other threads:[~2026-02-05 15:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20260203005627.GB52989@ax162>
2026-02-03 23:48 ` [PATCH v4] rust: Makefile: bound rustdoc workaround to affected versions HeeSu Kim
2026-02-03 22:12 ` Nathan Chancellor
2026-02-05 13:18 ` [PATCH v5 1/2] kbuild: add rustc-max-version macro HeeSu Kim
2026-02-05 13:18 ` [PATCH v5 2/2] rust: Makefile: bound rustdoc workaround to affected versions HeeSu Kim
2026-03-12 14:12 ` Miguel Ojeda
2026-02-05 15:55 ` Nicolas Schier [this message]
2026-03-10 22:45 ` [PATCH v5 1/2] kbuild: add rustc-max-version macro Miguel Ojeda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aYS9bRugxr1rUvA3@levanger \
--to=nsc@kernel.org \
--cc=a.hindborg@kernel.org \
--cc=aliceryhl@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun@google.com \
--cc=charmitro@posteo.net \
--cc=dakr@kernel.org \
--cc=gary@garyguo.net \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=mlksvender@gmail.com \
--cc=nathan@kernel.org \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox