From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 17B5A34FF58; Wed, 11 Feb 2026 08:15:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.12 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770797705; cv=none; b=HCFA/cvkZTFr/4lrAybTybsVw1r9iLe03MmVve3VJFfhc5yHAkg+XFvG/gULglyF91lk9aopPTF26VaCL0T3XgjwHRpj2dovtJh0M9VHucOfj1Y7+QW0tVvIk/4gQZ+yHS7QToAdp9+Vl+98hpyBOAs8Z8IjdmcSYBvytCkv3Gg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770797705; c=relaxed/simple; bh=lcm3o7wL5kBg7ZYVDqCsaOcln/wpMYWwqixrap+exkM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=tvIxFi7RgoKK92NJOy8FvlvWHikyLHsFWV0hPmS4bXLZ7bo9NzymW2HgrL0tKyBhdxdsx8w73C9B5nfxPbKoNS7bUDTsWXc8wtd+SMVl18YNblHOeefb31bpOQHYfZNoCE7JvbRWohKA53QsfSKeQbt5Pg+b7Rd7Psd4ra0TVwg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=oDtCCMH0; arc=none smtp.client-ip=198.175.65.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="oDtCCMH0" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1770797705; x=1802333705; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=lcm3o7wL5kBg7ZYVDqCsaOcln/wpMYWwqixrap+exkM=; b=oDtCCMH0wDoOBrawYKhVDfPBxfUxwTTfFwRe8e2mTaDJAMb0NWHXN5H/ CP2ACwPjr36qS5nfgWEn5xPTMC7+tjFnq45Y69kcXQFu63k4sC8HBLNsb QmvNZ55PUlhSR0/aFpJTs4RoHDERPW6fMGe7dExVqHrDi4SiaKtH41cWz Azo5dqwYr9Z1OXK+G2oLqmqKyt2ohAbZr35tS52qDA+hSTjoxsGkEr2QV Agt5l9QbTR11JcGHaxxxXPkZ/4YJqVtYc+lEYaSjqvIrRxf3mim2nxHeO mfsJjbi8lb8bvm2CmKLqf6CFFHctxItuS7IiPxloM1dHSk1EwYJuKHRci g==; X-CSE-ConnectionGUID: afE77VtOTMqSqUiDG3OYug== X-CSE-MsgGUID: H4Dh/0SiSu2pJJq4WKimjw== X-IronPort-AV: E=McAfee;i="6800,10657,11697"; a="83380869" X-IronPort-AV: E=Sophos;i="6.21,283,1763452800"; d="scan'208";a="83380869" Received: from fmviesa006.fm.intel.com ([10.60.135.146]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Feb 2026 00:15:04 -0800 X-CSE-ConnectionGUID: 8UiJQ0k6Q7em/8Llw6CfGw== X-CSE-MsgGUID: mhA5W8wZShqRq0+mZKkrcA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,283,1763452800"; d="scan'208";a="211137503" Received: from egrumbac-mobl6.ger.corp.intel.com (HELO localhost) ([10.245.244.220]) by fmviesa006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Feb 2026 00:15:01 -0800 Date: Wed, 11 Feb 2026 10:14:59 +0200 From: Andy Shevchenko To: Sakari Ailus Cc: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, Daniel Scally , Heikki Krogerus , Greg Kroah-Hartman , "Rafael J. Wysocki" , Danilo Krummrich , stable@vger.kernel.org Subject: Re: [PATCH v1 1/1] device property: Allow secondary lookup in fwnode_get_next_child_node() Message-ID: References: <20260210135822.47335-1-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo On Wed, Feb 11, 2026 at 12:02:57AM +0200, Sakari Ailus wrote: > On Tue, Feb 10, 2026 at 02:58:22PM +0100, Andy Shevchenko wrote: > > When device_get_child_node_count() got split to the fwnode and device > > respective APIs, the fwnode didn't inherit the ability to traverse over > > the secondary fwnode. Hence any user, that switches from device to fwnode > > API misses this feature. In particular, this was revealed by the commit > > 1490cbb9dbfd ("device property: Split fwnode_get_child_node_count()") > > that effectively broke the GPIO enumeration on Intel Galileo boards. > > Fix this by moving the secondary lookup from device to fwnode API. > > > > Note, in general no device_*() API should go into the depth of the fwnode > > implementation. Thanks for the review, my answers below. ... > > + if (IS_ERR_OR_NULL(fwnode)) > > + return NULL; > > This test is already being done by fwnode_call_ptr_op() (via > fwnode_has_op()) so I'd omit it here. That would probably be best put in > another patch though. Up to you. I would like to keep this as is for the matter of backporting. With that done, I can clean up further. ... > As the function becomes trivial, I'd move it to property.h. Yes, but the same applies to many functions in the property.c. I don't want to treat this specially: - exceptionally for this function (what about the rest?) - for the matters of backporting ... TL;DR: I would like to move this patch forward as is. After that I will consider cleaning up as suggested taking into account other places. -- With Best Regards, Andy Shevchenko