From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 38FDC34F27D; Wed, 11 Feb 2026 08:27:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.17 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770798438; cv=none; b=VYlR7cgbmkbDb16FIJsYeMEmNIc4tAWy+QH3Xw8dfMlmUzPCTDdf14ydqdakacnayKE13rki0ui+vlrvSI4baWNrcx8Epg/E3i1V/iB/HsyRbGooXcTho3fywo3ELv8PCfzH9HwjRgUR7Xk8nYHNeyji1rQhrn68j7ArqjkjMPI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770798438; c=relaxed/simple; bh=3k5BEXJiy4RD36/1Q2xs6gyb3RUnCpGcDHV8zJtSCAE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=HtgRLupyZ0H/p5gjUCROEpAsb3qFWwHZuLg7k7BMjuDAUOknZgO4xBKLsqIlTmV2aaH/RdFp4fpXKBYFUYAirZ24YqMVXRyaJB1vuo6hfatGg8ZvTYla62YoWbCbqv5EIwZEwqM/Zr7DUp/sFlizoGtXZdpLp/KqbcmgjY1dRzw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=fpZn5Q14; arc=none smtp.client-ip=198.175.65.17 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="fpZn5Q14" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1770798438; x=1802334438; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=3k5BEXJiy4RD36/1Q2xs6gyb3RUnCpGcDHV8zJtSCAE=; b=fpZn5Q14LoZy0KP3QGAo5lcytIvmuXZ8J5XF2Idq64w2tak30V/YacUf 1XBC+zgaszRVTzIYSBsGtnU01AHrn3VKvyPBfTUN680bRd3t3MfN+9FGn FuQxeno0gfFGSQKUgIU9jeVUfKUju11dlsfAhkFy0U1U5moGIDPEv9UJG +e+8oQsZ7c982v/C0uynvZZsyLIn1Zz2v2bXQX0rBRMIp1vGPvJm38eGP eF2Ji4dILhOu6OQfVTmsTKvXsVQ5WAupV8SaYJI23o0J9M2xOSKlujONe 80tGuDjV2d9RebH04mCck0JqueBWRlNAC+jx+zPga/pn7E1GQfeY5bIIh A==; X-CSE-ConnectionGUID: vW8QYz9DSNCKOoo5UfLKHg== X-CSE-MsgGUID: QL4jQQilQb2MvGOuTmfOfw== X-IronPort-AV: E=McAfee;i="6800,10657,11697"; a="71926542" X-IronPort-AV: E=Sophos;i="6.21,283,1763452800"; d="scan'208";a="71926542" Received: from orviesa009.jf.intel.com ([10.64.159.149]) by orvoesa109.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Feb 2026 00:27:14 -0800 X-CSE-ConnectionGUID: Icr8/pTDTY+lWyHG/nNW3g== X-CSE-MsgGUID: KnBmDAw2S3+P2/0Y4Rym8A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,283,1763452800"; d="scan'208";a="212005392" Received: from pgcooper-mobl3.ger.corp.intel.com (HELO kekkonen.fi.intel.com) ([10.245.244.208]) by orviesa009-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Feb 2026 00:27:13 -0800 Received: from kekkonen.localdomain (localhost [IPv6:::1]) by kekkonen.fi.intel.com (Postfix) with SMTP id 42561121D36; Wed, 11 Feb 2026 10:27:28 +0200 (EET) Date: Wed, 11 Feb 2026 10:27:28 +0200 Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo From: Sakari Ailus To: Andy Shevchenko Cc: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, Daniel Scally , Heikki Krogerus , Greg Kroah-Hartman , "Rafael J. Wysocki" , Danilo Krummrich , stable@vger.kernel.org Subject: Re: [PATCH v1 1/1] device property: Allow secondary lookup in fwnode_get_next_child_node() Message-ID: References: <20260210135822.47335-1-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Hi Andy, On Wed, Feb 11, 2026 at 10:14:59AM +0200, Andy Shevchenko wrote: > On Wed, Feb 11, 2026 at 12:02:57AM +0200, Sakari Ailus wrote: > > On Tue, Feb 10, 2026 at 02:58:22PM +0100, Andy Shevchenko wrote: > > > When device_get_child_node_count() got split to the fwnode and device > > > respective APIs, the fwnode didn't inherit the ability to traverse over > > > the secondary fwnode. Hence any user, that switches from device to fwnode > > > API misses this feature. In particular, this was revealed by the commit > > > 1490cbb9dbfd ("device property: Split fwnode_get_child_node_count()") > > > that effectively broke the GPIO enumeration on Intel Galileo boards. > > > Fix this by moving the secondary lookup from device to fwnode API. > > > > > > Note, in general no device_*() API should go into the depth of the fwnode > > > implementation. > > Thanks for the review, my answers below. > > ... > > > > + if (IS_ERR_OR_NULL(fwnode)) > > > + return NULL; > > > > This test is already being done by fwnode_call_ptr_op() (via > > fwnode_has_op()) so I'd omit it here. That would probably be best put in > > another patch though. Up to you. > > I would like to keep this as is for the matter of backporting. > With that done, I can clean up further. > > ... > > > As the function becomes trivial, I'd move it to property.h. > > Yes, but the same applies to many functions in the property.c. I don't want to > treat this specially: > - exceptionally for this function (what about the rest?) > - for the matters of backporting There are other similar functions in property.h already. Moving the other trivial ones there, too, wouldn't hurt. > > ... > > TL;DR: I would like to move this patch forward as is. After that I will > consider cleaning up as suggested taking into account other places. Sounds good to me. Reviewed-by: Sakari Ailus -- Kind regards, Sakari Ailus