From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from szxga07-in.huawei.com (szxga07-in.huawei.com [45.249.212.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1D6B026B2B1; Fri, 9 May 2025 06:43:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=45.249.212.35 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746773004; cv=none; b=oLvOt+0S4bd0H90az1+J8K8NbR+21sIkSZCEbRcT97ABarEWLNwRAYpn7NhOovF5SDlAwN5fqA3NM4KXQ2uLGOCsTW6BW0XsdckSnvKuDNpma3C/rTMDnjB/fArReEeoOBcsRmUuCDMwLwJT3ncILR0bEv/RZfGBoHXjGqe5WdQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746773004; c=relaxed/simple; bh=I7dVhn7yVkNmKHQ/VobzVVMUVb7PrY8kt5IydB/Sqac=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=I5R0uTiRHfPAm2xD5X+cQ72UEHbt2FsR8mlCyHx3baHSkc3szTRUg5mtii0r5RBKYDX/azWOGQtgf4gIYaDAg5+nTEPXpKqyK9roCZnrEbwL741srp2+DpgQRJc+0HP0cE9ADE76D6byRavrRg7NXSIIwMZoTYYZij9NRpRlKPY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com; spf=pass smtp.mailfrom=huawei.com; arc=none smtp.client-ip=45.249.212.35 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Received: from mail.maildlp.com (unknown [172.19.88.163]) by szxga07-in.huawei.com (SkyGuard) with ESMTP id 4Ztzvc3WMdzsSgn; Fri, 9 May 2025 14:42:36 +0800 (CST) Received: from kwepemj200003.china.huawei.com (unknown [7.202.194.15]) by mail.maildlp.com (Postfix) with ESMTPS id 055B218001B; Fri, 9 May 2025 14:43:14 +0800 (CST) Received: from [10.67.120.170] (10.67.120.170) by kwepemj200003.china.huawei.com (7.202.194.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Fri, 9 May 2025 14:43:13 +0800 Message-ID: Date: Fri, 9 May 2025 14:43:12 +0800 Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/4] dma-mapping: benchmark: Add padding to ensure uABI remained consistent To: Barry Song <21cnbao@gmail.com>, Marek Szyprowski , Robin Murphy CC: , , , , , , , , References: <20250509020238.3378396-1-xiaqinxin@huawei.com> <20250509020238.3378396-2-xiaqinxin@huawei.com> From: Qinxin Xia In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To kwepemj200003.china.huawei.com (7.202.194.15) On 2025/5/9 11:31:09, Barry Song <21cnbao@gmail.com> wrote: > On Fri, May 9, 2025 at 2:02 PM Qinxin Xia wrote: >> The padding field in the structure was previously reserved to >> maintain a stable interface for potential new fields, ensuring >> compatibility with user-space shared data structures. >> However,it was accidentally removed by tiantao in a prior commit, >> which may lead to incompatibility between user space and the kernel. >> >> This patch reinstates the padding to restore the original structure >> layout and preserve compatibility. >> >> Fixes: 8ddde07a3d28 ("dma-mapping: benchmark: extract a common header file for map_benchmark definition") >> Cc: stable@vger.kernel.org >> Signed-off-by: Qinxin Xia > +Marek, +Robin > > Acked-by: Barry Song OK! >> --- >> include/linux/map_benchmark.h | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/include/linux/map_benchmark.h b/include/linux/map_benchmark.h >> index 62674c83bde4..2ac2fe52f248 100644 >> --- a/include/linux/map_benchmark.h >> +++ b/include/linux/map_benchmark.h >> @@ -27,5 +27,6 @@ struct map_benchmark { >> __u32 dma_dir; /* DMA data direction */ >> __u32 dma_trans_ns; /* time for DMA transmission in ns */ >> __u32 granule; /* how many PAGE_SIZE will do map/unmap once a time */ >> + __u8 expansion[76]; /* For future use */ >> }; >> #endif /* _KERNEL_DMA_BENCHMARK_H */ >> -- >> 2.33.0 >> > Thanks > Barry Thanks Qinxin