Re: [PATCH v2] ASoC: SDCA: Fix NULL pointer dereference in sdca_jack_process()

[Charles Keepax <ckeepax@opensource.cirrus.com>]

On Thu, Mar 12, 2026 at 07:32:18AM -0700, gaggery.tsai@intel.com wrote:
> From: TsaiGaggery <gaggery.tsai@intel.com>
> +static void class_function_component_remove(struct snd_soc_component *component)
> +{
> +	struct class_function_drv *drv = snd_soc_component_get_drvdata(component);
> +	struct sdca_class_drv *core = drv->core;
> +
> +	sdca_irq_disable(drv->function, core->irq_info);
> +}

Yeah as Mark notes this is really just postponing the issues till
you rebind the card.

> +	if (!card || !card->snd_card) {
> +		dev_dbg(dev, "card not yet bound, deferring jack event\n");
> +		return -ENODEV;
> +	}
> +
> +	rwsem = &card->snd_card->controls_rwsem;
> +	kctl = state->kctl;
> +

This is really a bit overly defensive, its just a driver bug if
this is called without these.

Let me have a look at this today, I think really the problem is
we shouldn't be devm'ing the IRQs since they are not being
handled at device probe time.

Thanks,
Charles