From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: Mark Brown <broonie@kernel.org>
Cc: gaggery.tsai@intel.com, linux-sound@vger.kernel.org,
mstrozek@opensource.cirrus.com, yung-chuan.liao@linux.intel.com,
pierre-louis.bossart@linux.dev, stable@vger.kernel.org
Subject: Re: [PATCH v2] ASoC: SDCA: Fix NULL pointer dereference in sdca_jack_process()
Date: Fri, 13 Mar 2026 14:28:33 +0000 [thread overview]
Message-ID: <abQfET9Yi3ad5hIF@opensource.cirrus.com> (raw)
In-Reply-To: <809fbe87-2154-46e4-94ca-da75f8d4b817@sirena.org.uk>
On Fri, Mar 13, 2026 at 01:28:23PM +0000, Mark Brown wrote:
> On Fri, Mar 13, 2026 at 09:54:28AM +0000, Charles Keepax wrote:
>
> > Let me have a look at this today, I think really the problem is
> > we shouldn't be devm'ing the IRQs since they are not being
> > handled at device probe time.
>
> Yes, or just request them on normal probe.
If memory serves the issue was as some of the IRQs actually
depend on interfacing with controls created by the card it was
nicer to register the IRQs fairly late, and probably nicer to
remove them if the card goes away. Although that said, we did end
up having to deal with the IRQs happening before the controls
anyway (since there wasn't actually a good callback for that) so
it might be worth re-assessing that decision.
Thanks,
Charles
prev parent reply other threads:[~2026-03-13 14:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-10 18:38 [PATCH] ASoC: SDCA: Fix NULL pointer dereference in sdca_jack_process() gaggery.tsai
2026-03-11 16:31 ` Mark Brown
2026-03-11 17:45 ` Tsai, Gaggery
2026-03-11 17:50 ` Charles Keepax
2026-03-12 14:32 ` [PATCH v2] " gaggery.tsai
2026-03-12 17:32 ` Mark Brown
2026-03-13 9:54 ` Charles Keepax
2026-03-13 13:28 ` Mark Brown
2026-03-13 14:28 ` Charles Keepax [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=abQfET9Yi3ad5hIF@opensource.cirrus.com \
--to=ckeepax@opensource.cirrus.com \
--cc=broonie@kernel.org \
--cc=gaggery.tsai@intel.com \
--cc=linux-sound@vger.kernel.org \
--cc=mstrozek@opensource.cirrus.com \
--cc=pierre-louis.bossart@linux.dev \
--cc=stable@vger.kernel.org \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox