Linux kernel -stable discussions
 help / color / mirror / Atom feed
From: Easwar Hariharan <eahariha@linux.microsoft.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: eahariha@linux.microsoft.com, stable@vger.kernel.org,
	Michael Kelley <mhklinux@outlook.com>,
	"Martin K . Petersen" <martin.petersen@oracle.com>
Subject: Re: [PATCH 6.6.y] scsi: storvsc: Ratelimit warning logs to prevent VM denial of service
Date: Tue, 28 Jan 2025 09:06:02 -0800	[thread overview]
Message-ID: <abc9281b-a8bf-47e9-a3f4-19ed19776516@linux.microsoft.com> (raw)
In-Reply-To: <2025012827-ripcord-dismantle-4091@gregkh>

On 1/27/2025 9:34 PM, Greg KH wrote:
> On Mon, Jan 27, 2025 at 11:25:17AM -0800, Easwar Hariharan wrote:
>> On 1/27/2025 10:29 AM, Easwar Hariharan wrote:
>>> commit d2138eab8cde61e0e6f62d0713e45202e8457d6d upstream
>>>
>>> If there's a persistent error in the hypervisor, the SCSI warning for
>>> failed I/O can flood the kernel log and max out CPU utilization,
>>> preventing troubleshooting from the VM side. Ratelimit the warning so
>>> it doesn't DoS the VM.
>>>
>>> Closes: https://github.com/microsoft/WSL/issues/9173
>>> Signed-off-by: Easwar Hariharan <eahariha@linux.microsoft.com>
>>> Link: https://lore.kernel.org/r/20250107-eahariha-ratelimit-storvsc-v1-1-7fc193d1f2b0@linux.microsoft.com
>>> Reviewed-by: Michael Kelley <mhklinux@outlook.com>
>>> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
>>> Signed-off-by: Easwar Hariharan <eahariha@linux.microsoft.com>
>>> ---
>>>  drivers/scsi/storvsc_drv.c | 8 +++++++-
>>>  1 file changed, 7 insertions(+), 1 deletion(-)
>>>
>>
>> I just remembered that we should wait for Linus to tag the rc before
>> sending backports, so apologies for sending this (and its 6.1 and 6.12
>> friends) out before rc1 was tagged.
> 
> Why was this not tagged for stable in the first place?
> 
> thanks,
> 
> greg k-h

An oversight when I sent the original patch.

- Easwar (he/him)

  reply	other threads:[~2025-01-28 17:06 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-27 18:29 [PATCH 6.6.y] scsi: storvsc: Ratelimit warning logs to prevent VM denial of service Easwar Hariharan
2025-01-27 19:25 ` Easwar Hariharan
2025-01-28  5:34   ` Greg KH
2025-01-28 17:06     ` Easwar Hariharan [this message]
2025-01-28 16:17 ` Sasha Levin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=abc9281b-a8bf-47e9-a3f4-19ed19776516@linux.microsoft.com \
    --to=eahariha@linux.microsoft.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=martin.petersen@oracle.com \
    --cc=mhklinux@outlook.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox