From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>
Cc: Douglas Anderson <dianders@chromium.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J . Wysocki" <rafael@kernel.org>,
Danilo Krummrich <dakr@kernel.org>,
stable@vger.kernel.org, Andrew Lunn <andrew@lunn.ch>,
Daniel Scally <djrscally@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Fabio Estevam <festevam@gmail.com>, Frank Li <Frank.Li@nxp.com>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
Jakub Kicinski <kuba@kernel.org>, Len Brown <lenb@kernel.org>,
Mark Brown <broonie@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Rob Herring <robh@kernel.org>,
Russell King <linux@armlinux.org.uk>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Saravana Kannan <saravanak@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
devicetree@vger.kernel.org, driver-core@lists.linux.dev,
imx@lists.linux.dev, linux-acpi@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH] device property: Make modifications of fwnode "flags" thread safe
Date: Tue, 17 Mar 2026 12:16:50 +0200 [thread overview]
Message-ID: <abkqEni3phP8dqqw@ashevche-desk.local> (raw)
In-Reply-To: <abkT_jpjIki6pvX1@shikoro>
On Tue, Mar 17, 2026 at 09:42:38AM +0100, Wolfram Sang wrote:
>
> > > What's the alignment for the u8 member in your SoC? 4 bytes or 8 bytes?
> > > (I assume it's 64-bit SoC.)
> >
> > FWIW, with the given change it will be still inside 64-byte data structure
> > which most likely occupies a single cache line (before this patch and after
> > as well).
>
> I consider this directon of the discussion irrelevant. If the number is
> (maybe? That's to be discussed!) needlessly bigger than 0, then it
> doesn't matter how big the number is.
That's why it was written 'FWIW', so it doesn't worth :-)
> Why don't you like the idea of taking the lock?
Like Danilo I am also not sure what lock protects fwnode accesses.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-03-17 10:17 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-16 22:42 [PATCH] device property: Make modifications of fwnode "flags" thread safe Douglas Anderson
2026-03-17 7:10 ` Andy Shevchenko
2026-03-17 7:26 ` Wolfram Sang
2026-03-17 7:34 ` Andy Shevchenko
2026-03-17 7:42 ` Wolfram Sang
2026-03-17 8:04 ` Andy Shevchenko
2026-03-17 8:05 ` Andy Shevchenko
2026-03-17 8:42 ` Wolfram Sang
2026-03-17 10:02 ` Danilo Krummrich
2026-03-17 10:16 ` Andy Shevchenko [this message]
2026-03-17 10:34 ` Wolfram Sang
2026-03-17 10:44 ` Rafael J. Wysocki
2026-03-17 14:27 ` Wolfram Sang
2026-03-18 8:41 ` Geert Uytterhoeven
2026-03-18 9:06 ` Andy Shevchenko
2026-03-17 13:42 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=abkqEni3phP8dqqw@ashevche-desk.local \
--to=andriy.shevchenko@linux.intel.com \
--cc=Frank.Li@nxp.com \
--cc=andrew@lunn.ch \
--cc=broonie@kernel.org \
--cc=dakr@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=djrscally@gmail.com \
--cc=driver-core@lists.linux.dev \
--cc=edumazet@google.com \
--cc=festevam@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=hkallweit1@gmail.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=kuba@kernel.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rafael@kernel.org \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=sakari.ailus@linux.intel.com \
--cc=saravanak@kernel.org \
--cc=stable@vger.kernel.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox