From: Sasha Levin <sashal@kernel.org>
To: Dawid Osuchowski <dawid.osuchowski@linux.intel.com>
Cc: stable@vger.kernel.org,
Jakub Staniszewski <jakub.staniszewski@linux.intel.com>,
Michal Schmidt <mschmidt@redhat.com>,
Aleksandr Loktionov <aleksandr.loktionov@intel.com>,
Przemek Kitszel <przemyslaw.kitszel@intel.com>,
Paul Menzel <pmenzel@molgen.mpg.de>,
Rinitha S <sx.rinitha@intel.com>,
Tony Nguyen <anthony.l.nguyen@intel.com>
Subject: Re: [PATCH 6.1.y 3/3] ice: reintroduce retry mechanism for indirect AQ
Date: Thu, 19 Mar 2026 12:45:58 -0400 [thread overview]
Message-ID: <abwoRsrQ-dOKp8TF@laps> (raw)
In-Reply-To: <fd3ab8b8-708f-43a6-84be-e6cf98fb2463@linux.intel.com>
On Thu, Mar 19, 2026 at 04:49:56PM +0100, Dawid Osuchowski wrote:
>On 2026-03-18 1:09 AM, Sasha Levin wrote:
>>From: Jakub Staniszewski <jakub.staniszewski@linux.intel.com>
>>
>>[ Upstream commit 326256c0a72d4877cec1d4df85357da106233128 ]
>>
>>Add retry mechanism for indirect Admin Queue (AQ) commands. To do so we
>>need to keep the command buffer.
>>
>>This technically reverts commit 43a630e37e25
>>("ice: remove unused buffer copy code in ice_sq_send_cmd_retry()"),
>>but combines it with a fix in the logic by using a kmemdup() call,
>>making it more robust and less likely to break in the future due to
>>programmer error.
>>
>>Cc: Michal Schmidt <mschmidt@redhat.com>
>>Cc: stable@vger.kernel.org
>>Fixes: 3056df93f7a8 ("ice: Re-send some AQ commands, as result of EBUSY AQ error")
>>Signed-off-by: Jakub Staniszewski <jakub.staniszewski@linux.intel.com>
>>Co-developed-by: Dawid Osuchowski <dawid.osuchowski@linux.intel.com>
>>Signed-off-by: Dawid Osuchowski <dawid.osuchowski@linux.intel.com>
>>Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>
>>Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
>>Reviewed-by: Paul Menzel <pmenzel@molgen.mpg.de>
>>Tested-by: Rinitha S <sx.rinitha@intel.com> (A Contingent worker at Intel)
>>Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
>>Signed-off-by: Sasha Levin <sashal@kernel.org>
>
>Hey Sasha,
>
>Thank you for trying to reapply this patch. Unfortunately for
>6.1.167-rc1 this will not work, we tried this with my colleague Jakub
>Staniszewski and got the following output:
>
># git am sasha_levin_ice_6_1_y.mbox
>Applying: ice: reintroduce retry mechanism for indirect AQ
I think that your mbox is missing the first two patches in this series :)
--
Thanks,
Sasha
next prev parent reply other threads:[~2026-03-19 16:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-17 11:37 FAILED: patch "[PATCH] ice: reintroduce retry mechanism for indirect AQ" failed to apply to 6.1-stable tree gregkh
2026-03-18 0:09 ` [PATCH 6.1.y 1/3] ice: remove unused buffer copy code in ice_sq_send_cmd_retry() Sasha Levin
2026-03-18 0:09 ` [PATCH 6.1.y 2/3] ice: sleep, don't busy-wait, in the SQ send retry loop Sasha Levin
2026-03-18 0:09 ` [PATCH 6.1.y 3/3] ice: reintroduce retry mechanism for indirect AQ Sasha Levin
2026-03-19 15:49 ` Dawid Osuchowski
2026-03-19 16:45 ` Sasha Levin [this message]
2026-03-19 17:23 ` Dawid Osuchowski
2026-03-20 9:39 ` Dawid Osuchowski
2026-03-20 15:19 ` Jakub Staniszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=abwoRsrQ-dOKp8TF@laps \
--to=sashal@kernel.org \
--cc=aleksandr.loktionov@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=dawid.osuchowski@linux.intel.com \
--cc=jakub.staniszewski@linux.intel.com \
--cc=mschmidt@redhat.com \
--cc=pmenzel@molgen.mpg.de \
--cc=przemyslaw.kitszel@intel.com \
--cc=stable@vger.kernel.org \
--cc=sx.rinitha@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox