From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 60A093EDAD9 for ; Thu, 19 Mar 2026 16:46:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773938760; cv=none; b=T7b6TzBH2qn/aWyVMXS9Aw0d73Bc7+0kGQk+XbMOxAKcoz4miD2jmCARMiMZvo6TQN6MqUscJoljzb088E0Tl4/i51ARlMqqaehnXqa+c83ui3kZ/ytChzhfjYoFda0ikK5zK4LKm08llYjYN21/aZeBAPkn5oFPpTB7TYVwMOI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773938760; c=relaxed/simple; bh=PFWy5EOPKIGfWdVuBoHVr9k1xwFmTb1ZFIvrQBSACgY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=nmqej6qbbsXV4WmLeRakwj+D7gSpH8ykrxdB3zZqFHsxkRF/+RL2O14us0GQsZoPdaxUHGGErNjYYOj5M4CjBZQYKZlkOpCg5zxMEKbFv1ggwOAQjppCreRd/b0tHdRBWGG0KZkYvCI2QnhIojYFU7fRhgy267nlYfx9GZERJgk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=hCbu2UKM; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="hCbu2UKM" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 69E50C2BCAF; Thu, 19 Mar 2026 16:45:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1773938759; bh=PFWy5EOPKIGfWdVuBoHVr9k1xwFmTb1ZFIvrQBSACgY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=hCbu2UKMKuA6xbrbbt8Lz1G3ViF2kJcmp+nncX53kbV0ZuXwikOA3Mbcaqxt1X0u5 NzfCuBKmQVvIxOaakZlL9yN9cQu6r4qojH60XnoTd9FoJn7XxsL/bJEBCnNIURne+i GJgljvdO+V4fWA5d3y1wAlRDdp/Tot+3MDHdWZPgNItzhdwOp4ALbrq8HQJQp2AdaJ VywugJxI2s4IQi5hFKrZbiGJ9CvogbWiT1+9W6221bweChhLRuaz4NUI0hpe6TCtpj ANcsul/jz6gU7WACe4gUFKqGG9DZFeHWczLsmyCgGRNPig0JQ5Lj+a1ijrUTvXZk5f W+aaQGaXl4zjg== Date: Thu, 19 Mar 2026 12:45:58 -0400 From: Sasha Levin To: Dawid Osuchowski Cc: stable@vger.kernel.org, Jakub Staniszewski , Michal Schmidt , Aleksandr Loktionov , Przemek Kitszel , Paul Menzel , Rinitha S , Tony Nguyen Subject: Re: [PATCH 6.1.y 3/3] ice: reintroduce retry mechanism for indirect AQ Message-ID: References: <2026031701-reapprove-dollar-1839@gregkh> <20260318000947.379271-1-sashal@kernel.org> <20260318000947.379271-3-sashal@kernel.org> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: On Thu, Mar 19, 2026 at 04:49:56PM +0100, Dawid Osuchowski wrote: >On 2026-03-18 1:09 AM, Sasha Levin wrote: >>From: Jakub Staniszewski >> >>[ Upstream commit 326256c0a72d4877cec1d4df85357da106233128 ] >> >>Add retry mechanism for indirect Admin Queue (AQ) commands. To do so we >>need to keep the command buffer. >> >>This technically reverts commit 43a630e37e25 >>("ice: remove unused buffer copy code in ice_sq_send_cmd_retry()"), >>but combines it with a fix in the logic by using a kmemdup() call, >>making it more robust and less likely to break in the future due to >>programmer error. >> >>Cc: Michal Schmidt >>Cc: stable@vger.kernel.org >>Fixes: 3056df93f7a8 ("ice: Re-send some AQ commands, as result of EBUSY AQ error") >>Signed-off-by: Jakub Staniszewski >>Co-developed-by: Dawid Osuchowski >>Signed-off-by: Dawid Osuchowski >>Reviewed-by: Aleksandr Loktionov >>Reviewed-by: Przemek Kitszel >>Reviewed-by: Paul Menzel >>Tested-by: Rinitha S (A Contingent worker at Intel) >>Signed-off-by: Tony Nguyen >>Signed-off-by: Sasha Levin > >Hey Sasha, > >Thank you for trying to reapply this patch. Unfortunately for >6.1.167-rc1 this will not work, we tried this with my colleague Jakub >Staniszewski and got the following output: > ># git am sasha_levin_ice_6_1_y.mbox >Applying: ice: reintroduce retry mechanism for indirect AQ I think that your mbox is missing the first two patches in this series :) -- Thanks, Sasha