From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Lee Jones <lee@kernel.org>
Cc: Brian Mak <makb@juniper.net>,
Herve Codina <herve.codina@bootlin.com>,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH v3] mfd: core: Preserve OF node when ACPI handle is present
Date: Fri, 20 Mar 2026 09:27:16 +0200 [thread overview]
Message-ID: <abz21ANNVYP3-pb2@ashevche-desk.local> (raw)
In-Reply-To: <20260319181231.GC2902881@google.com>
On Thu, Mar 19, 2026 at 06:12:31PM +0000, Lee Jones wrote:
> On Wed, 11 Mar 2026, Brian Mak wrote:
...
> > + if (adev)
> > + set_primary_fwnode(&pdev->dev, acpi_fwnode_handle(adev));
> > + else
> > + set_primary_fwnode(&pdev->dev, acpi_fwnode_handle(parent));
>
> Sorry to mess you around again, but how do you feel about:
>
> set_primary_fwnode(&pdev->dev, acpi_fwnode_handle(adev ?: parent));
If you think it's better, no objections from me.
Some maintainers prefer avoiding ternary, and specifically Elvis, some not —
hard to remember everybody's preferences :-)
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2026-03-20 7:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-11 19:02 [PATCH v3] mfd: core: Preserve OF node when ACPI handle is present Brian Mak
2026-03-11 20:25 ` Andy Shevchenko
2026-03-11 20:36 ` Brian Mak
2026-03-19 18:12 ` Lee Jones
2026-03-20 7:27 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=abz21ANNVYP3-pb2@ashevche-desk.local \
--to=andriy.shevchenko@linux.intel.com \
--cc=herve.codina@bootlin.com \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=makb@juniper.net \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox