From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BDCBE3603E0; Mon, 13 Apr 2026 11:38:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776080297; cv=none; b=iRxsgerbbMix6xNZbPHfMd8hDZonW4y+FjOC4FHcUPcYdVPpyqVXy1coGaJvOda/Uvf53vfv5xrj7aU67ZZI82iMSv9x5d3Oz4uO++ne6yMYOdfTfvF2dmA9BdWF93BXC8MMUEUV+juSCufYCju0Z+mksEDNqPg5fmblhuFhGqE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776080297; c=relaxed/simple; bh=jB7FRDPHSkphE4Zs6YpqIM9woNsbFEbM9sj7YGjDevk=; h=Message-ID:Date:MIME-Version:Cc:Subject:To:References:From: In-Reply-To:Content-Type; b=ijj4WPT9I+KGNsKN5FoxJhpabCpfVHWgQ4l6FZtgsGdGTccmtX++pgbmQv3PAnQ7PfLxbVXyHp8sjKeDMMhUQ8eSnw3a307soE0TeOkajcugzDeRC5y0X+7bpoFXcR/eiYnuoSO4HSeCFQIHiNBqNB05WnjXzSuTT54SgRaE7aA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=j4P8Iu3t; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="j4P8Iu3t" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4112AC116C6; Mon, 13 Apr 2026 11:38:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1776080297; bh=jB7FRDPHSkphE4Zs6YpqIM9woNsbFEbM9sj7YGjDevk=; h=Date:Cc:Subject:To:References:From:In-Reply-To:From; b=j4P8Iu3tDTmbC0HelTqYCVo7vFZJgkmd/M2wjCsjDDFjl8r3xpE60Hm+tTP130ZM3 +fnJzdGZJMw65akNtcurTUtBHOSAbDoERdPGx63GJQUmCzGrx/ghNex0TLEqS2qwXF QRL+KQwC9uQjjHvmTQ/vyrNnsD44S8dzIz3ZkxAncTtADLz75Ky8blBufI3VZk8Emp zImA7d1F58c7nRkSMGkXJ8yhKgaEOJgWssivTLSU8wXDJ5CJ+0VkbBB/gTZNcs8jrN pM5ExA5V9Lxx4DXCcpyYa0Lcqmhztxvr4XPLdkhSd18LhB3zYXlX79q8Nv9V8xVp+w znGa3PUU64vsw== Message-ID: Date: Mon, 13 Apr 2026 19:38:16 +0800 Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: chao@kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] f2fs: fix uninitialized kobject put in f2fs_init_sysfs() To: Guangshuo Li , Jaegeuk Kim , linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org References: <20260410124726.2035729-1-lgs201920130244@gmail.com> Content-Language: en-US From: Chao Yu In-Reply-To: <20260410124726.2035729-1-lgs201920130244@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 4/10/2026 8:47 PM, Guangshuo Li wrote: > In f2fs_init_sysfs(), all failure paths after kset_register() jump to > put_kobject, which unconditionally releases both f2fs_tune and > f2fs_feat. > > If kobject_init_and_add(&f2fs_feat, ...) fails, f2fs_tune has not been > initialized yet, so calling kobject_put(&f2fs_tune) is invalid. > > Fix this by splitting the unwind path so each error path only releases > objects that were successfully initialized. > > Fixes: a907f3a68ee26ba4 ("f2fs: add a sysfs entry to reclaim POSIX_FADV_NOREUSE pages") > Cc: stable@vger.kernel.org > Signed-off-by: Guangshuo Li Reviewed-by: Chao Yu Thanks,