public inbox for stable@vger.kernel.org
 help / color / mirror / Atom feed
From: Matthew Brost <matthew.brost@intel.com>
To: Tejun Heo <tj@kernel.org>
Cc: Waiman Long <longman@redhat.com>,
	<intel-xe@lists.freedesktop.org>,
	<dri-devel@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>,
	"Carlos Santa" <carlos.santa@intel.com>,
	Ryan Neph <ryanneph@google.com>, <stable@vger.kernel.org>,
	Lai Jiangshan <jiangshanlai@gmail.com>
Subject: Re: [PATCH v2] workqueue: Add pool_workqueue to pending_pwqs list when unplugging multiple inactive works
Date: Wed, 1 Apr 2026 21:18:51 -0700	[thread overview]
Message-ID: <ac3uK2ZVRhiPfL6v@gsse-cloud1.jf.intel.com> (raw)
In-Reply-To: <604e3d6aea8767a245160e8c6d3b4b4c@kernel.org>

On Wed, Apr 01, 2026 at 10:20:13AM -1000, Tejun Heo wrote:
> Hello,
> 
> Applied to wq/for-7.0-fixes with the comment updated as below.
> 

+1 on commenr adjustment. Thanks for the quick pull.

Matt

> Thanks.
> 
> --- a/kernel/workqueue.c
> +++ b/kernel/workqueue.c
> @@ -1852,12 +1852,11 @@
>  		if (pwq_activate_first_inactive(pwq, true)) {
>  			/*
> -			 * pwq is unbound. Additional inactive work_items need
> -			 * to reinsert the pwq into nna->pending_pwqs, which
> -			 * was skipped while pwq->plugged was true. See
> -			 * pwq_tryinc_nr_active() for additional details.
> +			 * While plugged, queueing skips activation which
> +			 * includes bumping the nr_active count and adding the
> +			 * pwq to nna->pending_pwqs if the count can't be
> +			 * obtained. We need to restore both for the pwq being
> +			 * unplugged. The first call activates the first
> +			 * inactive work item and the second, if there are more
> +			 * inactive, puts the pwq on pending_pwqs.
>  			 */
> 
> -- 
> tejun

      reply	other threads:[~2026-04-02  4:19 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-01  1:07 [PATCH v2] workqueue: Add pool_workqueue to pending_pwqs list when unplugging multiple inactive works Matthew Brost
2026-04-01 14:44 ` Waiman Long
2026-04-01 15:40   ` Matthew Brost
2026-04-01 18:04     ` Waiman Long
2026-04-01 20:20 ` Tejun Heo
2026-04-02  4:18   ` Matthew Brost [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ac3uK2ZVRhiPfL6v@gsse-cloud1.jf.intel.com \
    --to=matthew.brost@intel.com \
    --cc=carlos.santa@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=jiangshanlai@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=longman@redhat.com \
    --cc=ryanneph@google.com \
    --cc=stable@vger.kernel.org \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox