From: Florian Westphal <fw@strlen.de>
To: Steffen Klassert <steffen.klassert@secunet.com>
Cc: Qi Tang <tpluszz77@gmail.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>, David Ahern <dsahern@kernel.org>,
netdev@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH v2] xfrm: delay dev_put in xfrm_input to after transport reinject
Date: Thu, 2 Apr 2026 12:54:37 +0200 [thread overview]
Message-ID: <ac5K7S3dBsINFafg@strlen.de> (raw)
In-Reply-To: <ac5GnMeqSeNlzBp7@secunet.com>
Steffen Klassert <steffen.klassert@secunet.com> wrote:
> On Tue, Mar 31, 2026 at 05:27:37PM +0800, Qi Tang wrote:
> > int xfrm4_transport_finish(struct sk_buff *skb, int async)
> > {
> > struct xfrm_offload *xo = xfrm_offload(skb);
> > @@ -74,7 +96,8 @@ int xfrm4_transport_finish(struct sk_buff *skb, int async)
> >
> > NF_HOOK(NFPROTO_IPV4, NF_INET_PRE_ROUTING,
> > dev_net(skb->dev), NULL, skb, skb->dev, NULL,
> > - xfrm4_rcv_encap_finish);
> > + async ? xfrm4_rcv_encap_finish_async :
> > + xfrm4_rcv_encap_finish);
>
> What happens if the PRE_ROUTING hook returns NF_DROP, NF_QUEUE, or
> NF_STOLEN before the okfn runs? Looks like we leak the dev refcnt
> then.
Yes, no okfn is run in those cases.
I'd suggest do drop the refcount after NF_HOOK, i.e. something like:
dev = skb->dev;
NF_HOOK(NFPROTO_IPV4, NF_INET_PRE_ROUTING,
...
if (async)
dev_put(dev);
Thats easier to follow.
next prev parent reply other threads:[~2026-04-02 10:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-31 9:27 [PATCH v2] xfrm: delay dev_put in xfrm_input to after transport reinject Qi Tang
2026-04-02 10:36 ` Steffen Klassert
2026-04-02 10:54 ` Florian Westphal [this message]
2026-04-02 11:26 ` Qi Tang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ac5K7S3dBsINFafg@strlen.de \
--to=fw@strlen.de \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=herbert@gondor.apana.org.au \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=stable@vger.kernel.org \
--cc=steffen.klassert@secunet.com \
--cc=tpluszz77@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox