From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6B25F3B2BA; Wed, 25 Mar 2026 19:08:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774465728; cv=none; b=QsU1ci8WYPpt9/OnpcDzoSd6b4y24/18sVQICOZvNhprQZQ3vxFPR2dJEdsJ6mOuOLqA87+5D03o23MxfqF9ZQ5MGIR7CT7d7vcO7aLK9dzTNPErNUE8Wrqg1tEZhfHhG+vrXtrakFehoP32R3W+16cKptV2DttwMZe+k5vCVUw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774465728; c=relaxed/simple; bh=Qo41yGMXvFJziS9alU9r9/+sGjFxjt4T2tB+BRTnfmI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=YT7au5GAwVRyXr0vk9e9fiWEZip3YexNB7hE/nzBzCq741ucE9KwRtX7U5EnUNsFPvBTwPEEjyyeYz+bzDyNI7qXnftLHB5Wbsn+3opkDMvIU1drW7gi8zN+DWUA+2ZneERBjjawbMS8JwyKAKosz4NhMxoD1OqabaAp/8NQnVo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=M6BRRpGN; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="M6BRRpGN" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4DCC1C4CEF7; Wed, 25 Mar 2026 19:08:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1774465727; bh=Qo41yGMXvFJziS9alU9r9/+sGjFxjt4T2tB+BRTnfmI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=M6BRRpGNU+l+t/1WP2LzJARmGEBxhq/iSy4M7oAGkbTjXmU+7qIXz/CXlnURUJZDs TGHiVbNkwtNLGM2foEPW7gFvzL+zlA2JZTkKG+Q5FGEMO1FI89Z3WEDMAStSUc+JKL Ut+u74RH6/EzWcvqBk0QYi0qAmEcXOxXPqPz0LCgZHn7kC1xF4jSygmwAhJM3YncyC GKdiuUAefSRfuhb9BQtP2ajY2FAC1p1bdLzeAu8Da0y3ym91sFhk0oic+nqgklU0GB V/KCvC/5WKUJcxtJAaeqin4+SifD9kCzGujMle1it0FmoUZA4DRuPy80iF13OiKmpb 7cLwwhH1VvjzA== Date: Wed, 25 Mar 2026 21:08:38 +0200 From: Mike Rapoport To: "David Hildenbrand (Arm)" Cc: Jianhui Zhou , SeongJae Park , Andrew Morton , jane.chu@oracle.com, Muchun Song , Oscar Salvador , Peter Xu , Andrea Arcangeli , Mike Kravetz , Hugh Dickins , Sidhartha Kumar , Jonas Zhou , linux-mm@kvack.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, syzbot+f525fd79634858f478e7@syzkaller.appspotmail.com Subject: Re: [PATCH v4] mm/userfaultfd: fix hugetlb fault mutex hash calculation Message-ID: References: <20260324170311.dc5b54fe0765f2e680e3cc90@linux-foundation.org> <20260325010618.85366-1-sj@kernel.org> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Wed, Mar 25, 2026 at 09:49:54AM +0100, David Hildenbrand (Arm) wrote: > On 3/25/26 07:07, Jianhui Zhou wrote: > > On Tue, Mar 25, 2026 at 01:06:00AM +0000, SeongJae Park wrote: > >> Seems userfaulfd.c is the only caller of the new helper function. Why don't > >> you define the function in userfaultfd.c ? > > I kept hugetlb_linear_page_index() in include/linux/hugetlb.h because > > this is hugetlb-specific logic, not userfaultfd-specific logic. > > Yes, and see my comment about either removing it entirely again next, or > actually also using it in hugetlb.c. I think it's better to move large piece of mfill_atomic_hugetlb() to hugetlb.c and git rid of the helper then. And now keep it simple for easier backporting. > -- > Cheers, > > David -- Sincerely yours, Mike.