From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 020C52248A3; Fri, 27 Mar 2026 19:11:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774638695; cv=none; b=eVJ4vBm5wAF9AczbtL2x9hVtdfv6PK7Wik4v1uJL/mIaLXqkygXtNHqMyOICDE158vY9f408Xsf9YKwmXwVYIgYC2mCK9D+pglQeQYSQ/mekAcGXfZGeayCBtEwRNZPwK20rAkBDn9I6mpyvLhD3qon6eR4CT15v49J9iEg42kA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774638695; c=relaxed/simple; bh=t8Yr6+ZLvGtmAjyiVKHKGVaZC9GwRGsV2qawDIHvUE0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=UjlbBssKgHwjvIdFSVgmntMW0ArQbIQDHDU6uWg4BJYo1Ubeec8EEfOuflhayZHJvwyfN1rq+RsTFVr6QTBJnINRDB2mCbHKwaZastfwdurkcX2TZp96jWWdaQ+4TSjfryozeNWwwrOFV23rueUKM+T4j8T9J5krHHNHI3BT1Dc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=c+GfUrat; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="c+GfUrat" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 50F08C19423; Fri, 27 Mar 2026 19:11:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1774638694; bh=t8Yr6+ZLvGtmAjyiVKHKGVaZC9GwRGsV2qawDIHvUE0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=c+GfUratGpESdGIj8JQK9CmlGpyY2f5RSHcSHSOiNGoK624fq0dDRt7r3atKyoLbt MMOAUcMMtKcnS7tr8s4/3177/kRn3qsDdHoJDtZBT8IxXguy5jkP8MEgANVRwj39VZ eZ/BBHRKEJudYPAo5s1nIsfaqDw0bmvvFeHKhdeh+tWF//TdhCcspj+/Np431ec3IZ o9X/LJ6TMwEkw0L3QAIDmJRUjI99MEjdx9XO+ldzPZO0VLJxqXEmpo0VFDitdlk+50 VJoL439a4FBDlrgYWcqH6aJwfoVTNiFvRcj4ZmK0DRXTMJXhOWqW8GHKP5AosZRKq8 5am1xd5oJCR8A== Date: Fri, 27 Mar 2026 20:11:14 +0100 From: Nicolas Schier To: Janne Grunau Cc: Nathan Chancellor , Ahmad Fatoum , Sascha Hauer , Simon Glass , Thomas =?iso-8859-1?Q?Wei=DFschuh?= , linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH v3] kbuild: modules-cpio-pkg: Respect INSTALL_MOD_PATH Message-ID: Mail-Followup-To: Nicolas Schier , Janne Grunau , Nathan Chancellor , Ahmad Fatoum , Sascha Hauer , Simon Glass , Thomas =?iso-8859-1?Q?Wei=DFschuh?= , linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org References: <20260327-kbuild-modules-cpio-pkg-usr-merge-v3-1-ef507dfa006c@jannau.net> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260327-kbuild-modules-cpio-pkg-usr-merge-v3-1-ef507dfa006c@jannau.net> On Fri, Mar 27, 2026 at 09:30:29AM +0100, Janne Grunau wrote: > The modules-cpio-pkg target added in commit 2a9c8c0b59d3 ("kbuild: add > target to build a cpio containing modules") is incompatible with > initramfs with merged /lib and /usr/lib directories [1]. "/lib" cannot > be a link and directory at the same time. > Respect a non-empty INSTALL_MOD_PATH in the modules-cpio-pkg target so > that `make INSTALL_MOD_PATH=/usr modules-cpio-pkg` results in the same > module install location as `make INSTALL_MOD_PATH=/usr modules_install`. > > Tested with Fedora distribution initramfs produced by dracut. > > Link: https://systemd.io/THE_CASE_FOR_THE_USR_MERGE/ [1] > Fixes: 2a9c8c0b59d3 ("kbuild: add target to build a cpio containing modules") > Cc: stable@vger.kernel.org > Reviewed-by: Simon Glass > Reviewed-by: Nathan Chancellor > Reviewed-by: Thomas Weißschuh > Signed-off-by: Janne Grunau > --- > Hej, > > this patch allows to produce modules-cpio initramfs which are compatible > with initramfs with merged /lib and /usr/lib (/lib as symlink to > /usr/lib). I expect initramfs of distributions with merged /usr to have > a merged /usr as well. This is at least true for Fedora initramfs built > with dracut. > > Janne > --- > Changes in v3: > - Drop comment added in v2, change is straight forward after dropping > the repeated slash prevention > - collect Thomas' and Nathan's Rb: > - Link to v2: https://lore.kernel.org/r/20260325-kbuild-modules-cpio-pkg-usr-merge-v2-1-339ac87d82ea@jannau.net > Thanks! Reviewed-by: Nicolas Schier Tested-by: Nicolas Schier -- Nicolas