From: Alison Schofield <alison.schofield@intel.com>
To: Dan Williams <dan.j.williams@intel.com>
Cc: <dave.jiang@intel.com>, <patches@lists.linux.dev>,
<linux-cxl@vger.kernel.org>,
<Smita.KoralahalliChannabasappa@amd.com>,
Jonathan Cameron <Jonathan.Cameron@huawei.com>,
<stable@vger.kernel.org>
Subject: Re: [PATCH 0/9] dax/hmem: Add tests for the dax_hmem takeover capability
Date: Fri, 27 Mar 2026 16:42:39 -0700 [thread overview]
Message-ID: <accV75BCtqJF2dUK@aschofie-mobl2.lan> (raw)
In-Reply-To: <20260327052821.440749-1-dan.j.williams@intel.com>
On Thu, Mar 26, 2026 at 10:28:12PM -0700, Dan Williams wrote:
> Given all the cross subsystem dependencies needed to make this solution
> work, it needs to have a unit test to keep it functional.
>
> On the path to writing that, several fixes fell out, but not to Smita's
> code, to mine. One use-after-free has been there since the original
> automatic region assembly code.
>
> Here is a preview of the core of the test I will submit to the cxl-cli project:
>
> ---
> modprobe cxl_mock_mem && modprobe cxl_test hmem_test=1
>
> dax=$(find_dax_cxl)
> [[ "$dax" == "" ]] && err $LINENO
> dax=$(find_dax_hmem)
> [[ "$dax" != "" ]] && err $LINENO
>
> unload
>
> modprobe cxl_mock_mem && modprobe cxl_test fail_autoassemble hmem_test=1
>
> dax=$(find_dax_cxl)
> [[ "$dax" != "" ]] && err $LINENO
> dax=$(find_dax_hmem)
> [[ "$dax" == "" ]] && err $LINENO
>
> unload
> ---
I tested the new cxl-test patches following your commands above, and
all good. I'll ask about the race condition in that specific patch.
Tested this set on my real hardware too, confirmed this with Smita's
still passes my hotplug test cases.
snip
next prev parent reply other threads:[~2026-03-27 23:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-27 5:28 [PATCH 0/9] dax/hmem: Add tests for the dax_hmem takeover capability Dan Williams
2026-03-27 5:28 ` [PATCH 1/9] cxl/region: Fix use-after-free from auto assembly failure Dan Williams
2026-03-27 16:28 ` Dave Jiang
2026-03-27 19:20 ` Alison Schofield
2026-03-27 21:54 ` Dan Williams
2026-03-27 22:37 ` Alison Schofield
2026-03-27 23:43 ` Alison Schofield
2026-03-30 20:24 ` Ira Weiny
2026-03-27 23:42 ` Alison Schofield [this message]
2026-03-30 21:12 ` [PATCH 0/9] dax/hmem: Add tests for the dax_hmem takeover capability Koralahalli Channabasappa, Smita
2026-03-30 21:17 ` Dave Jiang
2026-03-31 21:57 ` Dave Jiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=accV75BCtqJF2dUK@aschofie-mobl2.lan \
--to=alison.schofield@intel.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=Smita.KoralahalliChannabasappa@amd.com \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=linux-cxl@vger.kernel.org \
--cc=patches@lists.linux.dev \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox