From: Sasha Levin <sashal@kernel.org>
To: Siddharth Chintamaneni <sidchintamaneni@gmail.com>
Cc: apais@microsoft.com, stable@vger.kernel.org, tariqt@nvidia.com,
leon@kernel.org, mbloch@nvidia.com, shshitrit@nvidia.com
Subject: Re: [Regression] net: tls: Change async resync helpers argument
Date: Fri, 27 Mar 2026 20:16:40 -0400 [thread overview]
Message-ID: <accd6CGZat7m84Qg@laps> (raw)
In-Reply-To: <CAE5sdEiLuFj_8m89PGJwFit0QHg1=TL6=O==Mirt39BfbrRkVA@mail.gmail.com>
On Fri, Mar 27, 2026 at 11:13:37AM -0700, Siddharth Chintamaneni wrote:
>Commit 74bf749662a29 [upstream e98cda764aa9c] is backported to match
>the function signature of tls_offload_rx_resync_async_request_cancel
>function that is introduced in Patch 2 of this series -
>https://lore.kernel.org/all/1760943954-909301-1-git-send-email-tariqt@nvidia.com/
>but this break nvidia's mlx-ofa driver build which is still
>referencing the old driver signature.
>
>Build environment:
> - mlnx-ofa_kernel-25.{07,10}
> - kernel: 6.12.68.1-1.azl3
>
>Failure
>
>466 | tls_offload_rx_resync_async_request_end(priv_rx->sk,
>cpu_to_be32(hw_seq));"
> | ~~~~~~~^~~~"
> | |"
> | struct sock *"
>In file included from
>/usr/src/azl/BUILD/mlnx-ofa_kernel-25.10/obj/default/include/net/tls.h:6,"
> from
>/usr/src/azl/BUILD/mlnx-ofa_kernel-25.10/obj/default/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ktls.h:9,"
> from
>/usr/src/azl/BUILD/mlnx-ofa_kernel-25.10/obj/default/drivers/net/ethernet/mellanox/mlx5/core/en_accel/en_accel.h:40,"
> from
>/usr/src/azl/BUILD/mlnx-ofa_kernel-25.10/obj/default/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ktls_rx.c:6:"
>./include/net/tls.h:461:74: note: expected 'struct
>tls_offload_resync_async *' but argument is of type 'struct sock *'"
> 461 | tls_offload_rx_resync_async_request_end(struct
>tls_offload_resync_async *resync_async,"
> |
>~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~"
So it looks like it broke an out of tree driver. Nothing we can do about it
here...
--
Thanks,
Sasha
prev parent reply other threads:[~2026-03-28 0:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-27 18:13 [Regression] net: tls: Change async resync helpers argument Siddharth Chintamaneni
2026-03-28 0:16 ` Sasha Levin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=accd6CGZat7m84Qg@laps \
--to=sashal@kernel.org \
--cc=apais@microsoft.com \
--cc=leon@kernel.org \
--cc=mbloch@nvidia.com \
--cc=shshitrit@nvidia.com \
--cc=sidchintamaneni@gmail.com \
--cc=stable@vger.kernel.org \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox