[Regression] net: tls: Change async resync helpers argument

[Regression] net: tls: Change async resync helpers argument

[Siddharth Chintamaneni]

Commit 74bf749662a29 [upstream e98cda764aa9c] is backported to match
the function signature of tls_offload_rx_resync_async_request_cancel
function that is introduced in Patch 2 of this series -
https://lore.kernel.org/all/1760943954-909301-1-git-send-email-tariqt@nvidia.com/
but this break nvidia's mlx-ofa driver build which is still
referencing the old driver signature.

Build environment:
  - mlnx-ofa_kernel-25.{07,10}
  - kernel: 6.12.68.1-1.azl3

Failure

466 |         tls_offload_rx_resync_async_request_end(priv_rx->sk,
cpu_to_be32(hw_seq));"
      |                                                 ~~~~~~~^~~~"
      |                                                        |"
      |                                                        struct sock *"
In file included from
/usr/src/azl/BUILD/mlnx-ofa_kernel-25.10/obj/default/include/net/tls.h:6,"
                 from
/usr/src/azl/BUILD/mlnx-ofa_kernel-25.10/obj/default/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ktls.h:9,"
                 from
/usr/src/azl/BUILD/mlnx-ofa_kernel-25.10/obj/default/drivers/net/ethernet/mellanox/mlx5/core/en_accel/en_accel.h:40,"
                 from
/usr/src/azl/BUILD/mlnx-ofa_kernel-25.10/obj/default/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ktls_rx.c:6:"
./include/net/tls.h:461:74: note: expected 'struct
tls_offload_resync_async *' but argument is of type 'struct sock *'"
  461 | tls_offload_rx_resync_async_request_end(struct
tls_offload_resync_async *resync_async,"
      |
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~"
/usr/src/azl/BUILD/mlnx-ofa_kernel-25.10/obj/default/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ktls_rx.c:
In function 'resync_update_sn':"
/usr/src/azl/BUILD/mlnx-ofa_kernel-25.10/obj/default/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ktls_rx.c:562:51:
error: passing argument 1 of
'tls_offload_rx_resync_async_request_start' from incompatible pointer
type [-Werror=incompatible-pointer-types]"
  562 |         tls_offload_rx_resync_async_request_start(sk, seq, datalen);"
      |                                                   ^~"
      |                                                   |"
      |                                                   struct sock *"
./include/net/tls.h:451:76: note: expected 'struct
tls_offload_resync_async *' but argument is of type 'struct sock *'"
  451 | tls_offload_rx_resync_async_request_start(struct
tls_offload_resync_async *resync_async,"

Reverting 74bf749662a2 makes the build pass again in our environment.
Let me know if you need more details.

Siddharth

Re: [Regression] net: tls: Change async resync helpers argument

[Sasha Levin]

On Fri, Mar 27, 2026 at 11:13:37AM -0700, Siddharth Chintamaneni wrote:
>Commit 74bf749662a29 [upstream e98cda764aa9c] is backported to match
>the function signature of tls_offload_rx_resync_async_request_cancel
>function that is introduced in Patch 2 of this series -
>https://lore.kernel.org/all/1760943954-909301-1-git-send-email-tariqt@nvidia.com/
>but this break nvidia's mlx-ofa driver build which is still
>referencing the old driver signature.
>
>Build environment:
>  - mlnx-ofa_kernel-25.{07,10}
>  - kernel: 6.12.68.1-1.azl3
>
>Failure
>
>466 |         tls_offload_rx_resync_async_request_end(priv_rx->sk,
>cpu_to_be32(hw_seq));"
>      |                                                 ~~~~~~~^~~~"
>      |                                                        |"
>      |                                                        struct sock *"
>In file included from
>/usr/src/azl/BUILD/mlnx-ofa_kernel-25.10/obj/default/include/net/tls.h:6,"
>                 from
>/usr/src/azl/BUILD/mlnx-ofa_kernel-25.10/obj/default/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ktls.h:9,"
>                 from
>/usr/src/azl/BUILD/mlnx-ofa_kernel-25.10/obj/default/drivers/net/ethernet/mellanox/mlx5/core/en_accel/en_accel.h:40,"
>                 from
>/usr/src/azl/BUILD/mlnx-ofa_kernel-25.10/obj/default/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ktls_rx.c:6:"
>./include/net/tls.h:461:74: note: expected 'struct
>tls_offload_resync_async *' but argument is of type 'struct sock *'"
>  461 | tls_offload_rx_resync_async_request_end(struct
>tls_offload_resync_async *resync_async,"
>      |
>~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~"

So it looks like it broke an out of tree driver. Nothing we can do about it
here...

-- 
Thanks,
Sasha