From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1D22826B098 for ; Mon, 30 Mar 2026 09:38:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774863541; cv=none; b=hy0Oec34UKP3qPdq7DoIv4Ybf33hMdnslSjWEmmJ4XmmFHaxZjLLjMjno1e3Z1cSwKCPesTm50Cb4Q+1H8jp6Q5Cyx/8ElpIcwjL+LO/Mm+bjSPPLDSwGmkSfn8oaI45/GU1MmzCYFriTJQLaSkgeqenWBJAbu3KuatTa7v/N/Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774863541; c=relaxed/simple; bh=MTNOj6ynMachv6R2Eweg4n7R8rKOuF6OM147NJPcIrw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=kxpBVLQM51ZtyBUihBfArPzEQLymy83yzpVeCov/zjLLzpoDJG8E54O8JwLdnxq5XRUG2rvzoC0DhbIoa8J6v8EVL3OMyAlhG6SWek/V/RX/UEBJErShzqlP4kccCc7wySGAP5DDBw14gm08CdepdNyZJq5gvsGoGHcr59UjNNs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=UI9VL4lo; arc=none smtp.client-ip=209.85.214.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="UI9VL4lo" Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-2b0b260d309so118525ad.1 for ; Mon, 30 Mar 2026 02:38:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1774863537; x=1775468337; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=vWT7ljauT3GJtk0p4Kr5YKMZTjRAnUxPGa2dI3sggKc=; b=UI9VL4loOJLQF6edE6XPUFh1w6L0oEFSu4ex7/dk7lhHJ8XPcSQyGGg0+wxdZtn1VY FewjK7+yQLoeYl+A9FpocOIfXY3pZznPubxLICH7GUMb1D2S4wEb5BQSp54JLSvICeJ3 yvTYheLhKQGj82RAyShpQD0yE4E8ljw6viF7aLXIKFP/DydNQ5rLAt4bDRcKvbD5NDb9 oFFEgFq+7l3K+3koqvYF+hBgNraB3KTc7E/Vt7ePS6IT3wANzsIGhsP204qI9HEQtoh4 z6m/HTRVF0BWn70dw5KzakWTMDqRZE47GyoBDLSONSo7rWUiBo0KWs7K5gSnNXI7/veX Zi5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774863537; x=1775468337; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vWT7ljauT3GJtk0p4Kr5YKMZTjRAnUxPGa2dI3sggKc=; b=m18spI2dQ3qEWR/8gN3ZIJttVpO3aYM15HRwiLynW+RAQZcSsJnIz0rh8PZSwQIDdQ xj5G59PkONPaiV+NmKeh3LrsiXxmgFN2UcHkxaWo0OhSfV/HSQ9DluJPIZtRRhelp/fT F+EjcNSG7TAnX4602OvRP3XjIYORrIAxxfmwEqUaqAIPItg28RWYHQq6SbdngxgRGFIc uoYB/lG3tog6U5vvZq4vsQsiHbUBMb5Ux2PQsVK9bp/Q48zQzqQn2LU8JP5LJ2G0oLTv ugwYoPfzl0U/9w7Iw03mXqMHQ84URXrRl8725O99ZjCcMBQhW3UTSRTz2xCgniybC5kb kDGw== X-Forwarded-Encrypted: i=1; AJvYcCXxR1AwPRSLztb+zw7ZoEvZkhrAT+RD0HlTTWwL+2bv/mezHIjt7fzOwRL60TZ2Oeb4CDlYOj8=@vger.kernel.org X-Gm-Message-State: AOJu0YyCOep6Fn6WJVmdcs/IFOC4C9L2Lur1lJyqK+9eZ9OyNDfy6q3M wkCfCE5dtNxQKEs+2BknFnKmc2WQo0AFiTI3GJRVJTbrJez/KNR9V+lVnJiEaT5J8JxZlMGu0vv Kl0P5bw== X-Gm-Gg: ATEYQzxzJdjS5F1RKItVtE+gSI8pNOH6dno2RNGJuuL+5dNxv1865fQ499s9g+jx9aV G+Rg7Rg94b8fkw6VldfkOy6rFKNbeT7zwYytyAM/HWYW7QUUCsYfzl/lOtwaF2uVAqYtwjMP1S0 VqjjIR4LPMkOqgTBiQ7q5mysCWo5+dlhVndfjQZWlxiySCgis/Cd0sqKC8yAFIgd/f3od9iL6cT RH/PNf6IPrijc5tD9shzSH/chczRPqUMfEDrbZkzkF4BfWNIOTPTFvtsvvO0v8o2psz8FLu4a3c QJMIR8T2lNd4OPiEegvNaNTvYsUWpLkj5qdMVvQMqQXLOxRdJ3erlNVIOkfM2xzciJK87Z3lkhp HNSvOvZLBRL/p9gHsnoFSj6JgehrkRc6ZziuSkVNQtm822ni14vkVCYyDjXVn7euiFbzG0AcsuJ UtIeMIo8P8gSYK2h56zlu6BlXFWGxrwZl5VrlxReyc54TNbuxqtbJp3YaOs50/PVSfaWkM X-Received: by 2002:a17:902:e54f:b0:2b0:b458:2dc3 with SMTP id d9443c01a7336-2b242d37d20mr493545ad.21.1774863536692; Mon, 30 Mar 2026 02:38:56 -0700 (PDT) Received: from google.com (10.129.124.34.bc.googleusercontent.com. [34.124.129.10]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b242765b9fsm88519465ad.43.2026.03.30.02.38.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Mar 2026 02:38:55 -0700 (PDT) Date: Mon, 30 Mar 2026 09:38:49 +0000 From: Pranjal Shrivastava To: Zhenzhong Duan Cc: iommu@lists.linux.dev, linux-kernel@vger.kernel.org, jgg@ziepe.ca, kevin.tian@intel.com, joro@8bytes.org, will@kernel.org, robin.murphy@arm.com, baolu.lu@linux.intel.com, stable@vger.kernel.org Subject: Re: [PATCH] iommufd: Fix return value of iommufd_fault_fops_write() Message-ID: References: <20260330030755.12856-1-zhenzhong.duan@intel.com> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260330030755.12856-1-zhenzhong.duan@intel.com> On Sun, Mar 29, 2026 at 11:07:55PM -0400, Zhenzhong Duan wrote: > copy_from_user() may return number of bytes failed to copy, we should > not pass over this number to user space to cheat that write() succeed. > Instead, -EFAULT should be returned. > > Cc: stable@vger.kernel.org > Fixes: 07838f7fd529 ("iommufd: Add iommufd fault object") > Signed-off-by: Zhenzhong Duan > Reviewed-by: Lu Baolu Reviewed-by: Pranjal Shrivastava Thanks, Praan