From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2DC653ACA68; Wed, 1 Apr 2026 08:34:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775032494; cv=none; b=s2OivYcObdS0QG/K3qufisgq2efI7XQnueGYYrYZWaAiLocMg1/bakYQc4Cpwtx21RdO3oqSfC7+PG85QyHj8Aa2NxpmFaMiwhHgVw/jw88rY2oSX6tDuZHpKrSHC1L9wT1QWWEco4aq2WhSbmSSMELz6CHv4A9O80+pwYNFyjM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775032494; c=relaxed/simple; bh=8LWqVYVupsHf2WpfKI7Tx2LrsjGmOFFgtNiUEes0yjk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=lx+UXHayX2SuYsxbxy22lXR8pbuKuBhmyrj4fXNyIuTrgfUxMHj6c8Sv+wOarrisxEea0VxO/0hhXtSIjvGLy7qfEcEHoVR6Gez6y0i575LsyuDdWxJITKRVVMWY57rVDVFsS8UFO/ILSuuFD/0E0U3kH8gTiyB/bqcQNbqNKVA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=t0LgG0zD; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="t0LgG0zD" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8A767C4CEF7; Wed, 1 Apr 2026 08:34:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1775032493; bh=8LWqVYVupsHf2WpfKI7Tx2LrsjGmOFFgtNiUEes0yjk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=t0LgG0zD3dUM/ufKi0thT18QpcgGKAgqSkXhM4b2GEobQAoUo+7ep2Fk6LstJl4Pe QBINrjg8YYoO4E+DuhSth8pCIaXlNTdpBcF7WqfM6NfzFqfbU301w4XWcZbhiC0I8Z UxU9VDG2M/SHLJjC/ohRGMDzXYMABeU4OOtH0pBfnutnO24LuRf7wML072iICRsCgw FZjk6VfblcxMsGMzU6mtONdsuMgDNvbQQnt2KKU8hgD853TsmTb18FuqLafeTOJ6BK gAwgQofQfNbm8og0/5/D4uqNDETWA+dgE/2DkjBFUZ8yQNMZCrupIKbY8RrpGa9r17 bFBXMsdY54SxA== Received: from phl-compute-10.internal (phl-compute-10.internal [10.202.2.50]) by mailfauth.phl.internal (Postfix) with ESMTP id ADA3DF4006B; Wed, 1 Apr 2026 04:34:52 -0400 (EDT) Received: from phl-frontend-03 ([10.202.2.162]) by phl-compute-10.internal (MEProxy); Wed, 01 Apr 2026 04:34:52 -0400 X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefhedrtddtgddvieegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceurghi lhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurh epfffhvfevuffkfhggtggujgesthdtredttddtvdenucfhrhhomhepmfhirhihlhcuufhh uhhtshgvmhgruhcuoehkrghssehkvghrnhgvlhdrohhrgheqnecuggftrfgrthhtvghrnh epffffkeegffejgfekvdejgeegtddtleejkefhhfduieduhfeigfduuefghfehffdunecu ffhomhgrihhnpehkvghrnhgvlhdrohhrghenucevlhhushhtvghrufhiiigvpedtnecurf grrhgrmhepmhgrihhlfhhrohhmpehkihhrihhllhdomhgvshhmthhprghuthhhphgvrhhs ohhnrghlihhthidqudeiudduiedvieehhedqvdekgeeggeejvdekqdhkrghspeepkhgvrh hnvghlrdhorhhgsehshhhuthgvmhhovhdrnhgrmhgvpdhnsggprhgtphhtthhopedviedp mhhouggvpehsmhhtphhouhhtpdhrtghpthhtohepshgrthhhhigrnhgrrhgrhigrnhgrnh drkhhuphhpuhhsfigrmhihsehlihhnuhigrdhinhhtvghlrdgtohhmpdhrtghpthhtohep thhglhigsehkvghrnhgvlhdrohhrghdprhgtphhtthhopehmihhnghhosehrvgguhhgrth drtghomhdprhgtphhtthhopegsphesrghlihgvnhekrdguvgdprhgtphhtthhopegurghv vgdrhhgrnhhsvghnsehlihhnuhigrdhinhhtvghlrdgtohhmpdhrtghpthhtohepgiekie eskhgvrhhnvghlrdhorhhgpdhrtghpthhtohephhhprgesiiihthhorhdrtghomhdprhgt phhtthhopehrihgtkhdrphdrvggughgvtghomhgsvgesihhnthgvlhdrtghomhdprhgtph htthhopehtshihrhhulhhnihhkohhvrdgsohhrhihssehgmhgrihhlrdgtohhm X-ME-Proxy: Feedback-ID: i10464835:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 1 Apr 2026 04:34:52 -0400 (EDT) Date: Wed, 1 Apr 2026 09:34:50 +0100 From: Kiryl Shutsemau To: Kuppuswamy Sathyanarayanan Cc: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H . Peter Anvin" , Rick Edgecombe , Borys Tsyrulnikov , linux-kernel@vger.kernel.org, linux-coco@lists.linux.dev, kvm@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH 1/2] x86/tdx: Fix off-by-one in port I/O handling Message-ID: References: <20260331112430.71425-1-kas@kernel.org> <20260331112430.71425-2-kas@kernel.org> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue, Mar 31, 2026 at 02:57:32PM -0700, Kuppuswamy Sathyanarayanan wrote: > Hi Kirill, > > On 3/31/2026 4:24 AM, Kiryl Shutsemau (Meta) wrote: > > handle_in() and handle_out() in arch/x86/coco/tdx/tdx.c use: > > > > u64 mask = GENMASK(BITS_PER_BYTE * size, 0); > > > > GENMASK(h, l) includes bit h. For size=1 (INB), this produces > > GENMASK(8, 0) = 0x1FF (9 bits) instead of GENMASK(7, 0) = 0xFF (8 > > bits). The mask is one bit too wide for all I/O sizes. > > > > Fix the mask calculation. > > > > Fixes: 03149948832a ("x86/tdx: Port I/O: Add runtime hypercalls") > > Reported-by: Borys Tsyrulnikov > > Signed-off-by: Kiryl Shutsemau (Meta) > > Cc: stable@vger.kernel.org > > --- > > LGTM. Can you include a link to the bug report or related discussion in > the commit log? It will help understand the impact of this issue. Link: https://lore.kernel.org/all/CAKw_Dz96rfSQc6Rn+9QBcUFHhmkK+9zu+P=bxowfZwxrATCBRg@mail.gmail.com/ It is relevant for both. -- Kiryl Shutsemau / Kirill A. Shutemov