From: Matthieu Baerts <matttbe@kernel.org>
To: gregkh@linuxfoundation.org, kuba@kernel.org, martineau@kernel.org
Cc: stable@vger.kernel.org, MPTCP Linux <mptcp@lists.linux.dev>
Subject: Re: FAILED: patch "[PATCH] selftests: mptcp: join: check re-using ID of unused ADD_ADDR" failed to apply to 5.15-stable tree
Date: Fri, 6 Sep 2024 10:26:10 +0200 [thread overview]
Message-ID: <ad315fc3-a33a-4f1b-8619-4da4d177ac7f@kernel.org> (raw)
In-Reply-To: <2024082628-stapling-dad-555c@gregkh>
Hi Greg,
On 26/08/2024 14:09, gregkh@linuxfoundation.org wrote:
>
> The patch below does not apply to the 5.15-stable tree.
> If someone wants it applied there, or to any other stable or longterm
> tree, then please email the backport, including the original git commit
> id to <stable@vger.kernel.org>.
Thank you for the notification!
(...)
> ------------------ original commit in Linus's tree ------------------
>
> From a13d5aad4dd9a309eecdc33cfd75045bd5f376a3 Mon Sep 17 00:00:00 2001
> From: "Matthieu Baerts (NGI0)" <matttbe@kernel.org>
> Date: Mon, 19 Aug 2024 21:45:20 +0200
> Subject: [PATCH] selftests: mptcp: join: check re-using ID of unused ADD_ADDR
>
> This test extends "delete re-add signal" to validate the previous
> commit. An extra address is announced by the server, but this address
> cannot be used by the client. The result is that no subflow will be
> established to this address.
>
> Later, the server will delete this extra endpoint, and set a new one,
> with a valid address, but re-using the same ID. Before the previous
> commit, the server would not have been able to announce this new
> address.
>
> While at it, extra checks have been added to validate the expected
> numbers of MPJ, ADD_ADDR and RM_ADDR.
>
> The 'Fixes' tag here below is the same as the one from the previous
> commit: this patch here is not fixing anything wrong in the selftests,
> but it validates the previous fix for an issue introduced by this commit
> ID.
>
> Fixes: b6c08380860b ("mptcp: remove addr and subflow in PM netlink")
Similar to my previous message mentioning that the 'Fixes' tag here is
pointing at the issue in the code, but the test file cannot easily be
patched to validate the issue: no need to worry about that one for v5.15.
Cheers,
Matt
--
Sponsored by the NGI0 Core fund.
prev parent reply other threads:[~2024-09-06 8:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-26 12:09 FAILED: patch "[PATCH] selftests: mptcp: join: check re-using ID of unused ADD_ADDR" failed to apply to 5.15-stable tree gregkh
2024-09-06 8:26 ` Matthieu Baerts [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ad315fc3-a33a-4f1b-8619-4da4d177ac7f@kernel.org \
--to=matttbe@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=kuba@kernel.org \
--cc=martineau@kernel.org \
--cc=mptcp@lists.linux.dev \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox